[Bug 22408] New: Subscription entry form cleanup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Bug ID: 22408 Summary: Subscription entry form cleanup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Target Milestone: --- Created attachment 85629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85629&action=edit Screenshot showing the proposed interface I would like to make a number of changes to the subscription entry form - Make the default layout single-column (like patron entry) - Switch the layout to two-column only when testing prediction pattern - Change the style of some buttons and links - Clean up some issues with capitalization and spacing - Make it clearer when form fields are read-only -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22250 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250 [Bug 22250] Clean up Mana KB integration with serials and reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 85630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85630&action=edit Bug 22408: Subscription entry form cleanup This patch makes a number of changes to the subscription entry form: - Make the default layout single-column. - Switch the layout to two-column only when testing prediction pattern. - Add a button to hide the prediction pattern test pane. - Change the style of some buttons and links. Add Font Awesome icons to some. - Clean up some issues with capitalization and spacing. - Make it clearer when form fields are read-only: Move "locked" form field style from addbiblio.css to staff-global.css and improve it with regard to mouse interactions To test, apply the patch and regenerate the staff client CSS. Clear your browser cache if necessary. - Go to Serials -> New subscription. - Readonly fields under "Vendor" and "Record" should show a small padlock icon. - Test the process of adding a subscription, paying special attention to the advanced pattern controls: Showing, hiding, modifying, canceling. - Test the process of editing a subscription in the same way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- Hi Owen, This is the mail I've received form the sandbox : The sandbox you've requested is not ready. Some problems occurred applying patches from bug 22408: <h1>Something went wrong !</h1>Applying: Bug 22408: Subscription entry form cleanup fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt). Patch failed at 0001 Bug 22408: Subscription entry form cleanup The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. error: could not build fake ancestor Bug 22408 - Subscription entry form cleanup 85630 - Bug 22408: Subscription entry form cleanup Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-22408-Subscription-entry-form-cleanup-wLHUqi.patch . -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I rebased Bug 22250, which I think was causing the problem. Thanks for testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Bug 22408 depends on bug 22250, which changed state. Bug 22250 Summary: Clean up Mana KB integration with serials and reports https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Applying: Bug 22408: Subscription entry form cleanup error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt). error: could not build fake ancestor Patch failed at 0001 Bug 22408: Subscription entry form cleanup Setting to Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85630|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 88189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88189&action=edit Bug 22408: Subscription entry form cleanup This patch makes a number of changes to the subscription entry form: - Make the default layout single-column. - Switch the layout to two-column only when testing prediction pattern. - Add a button to hide the prediction pattern test pane. - Change the style of some buttons and links. Add Font Awesome icons to some. - Clean up some issues with capitalization and spacing. - Make it clearer when form fields are read-only: Move "locked" form field style from addbiblio.css to staff-global.css and improve it with regard to mouse interactions To test, apply the patch and regenerate the staff client CSS. Clear your browser cache if necessary. - Go to Serials -> New subscription. - Readonly fields under "Vendor" and "Record" should show a small padlock icon. - Test the process of adding a subscription, paying special attention to the advanced pattern controls: Showing, hiding, modifying, canceling. - Test the process of editing a subscription in the same way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Failed QA Steps taken - Set Record for New Subscription and clicked Next, clicking Okay to continue without a Vendor. - Set Issue publication date, set Frequency 1 week, did not specify subscription length - Set subscription start date and end date. - Created an advanced pattern and named it, then created another advanced pattern and chose it as the Numbering pattern above - Clicked test prediction pattern and selected two dates to not publish randomly - Clicked Save subscription - Error! Error trace: Can't call method "title" on an undefined value at /home/vagrant/kohaclone/Koha/Subscription.pm line 165 1. in Koha::Subscription::get_sharable_info at /home/vagrant/kohaclone/Koha/Subscription.pm line 165 162: my $sub_numberpatteern = 163: Koha::Subscription::Numberpatterns->find( $subscription->numberpattern ); 164: 165: my $sub_mana_info = { 166: 'title' => $biblio->title, 167: 'sfdescription' => $sub_frequency->description, 168: 'unit' => $sub_frequency->unit, 2. in Koha::SharedContent::prepare_entity_data at /home/vagrant/kohaclone/Koha/SharedContent.pm line 123 120: my $ressource_mana_info; 121: my $packages = "Koha::".ucfirst($ressourcetype)."s"; 122: my $package = "Koha::".ucfirst($ressourcetype); 123: $ressource_mana_info = $package->get_sharable_info($ressourceid); 124: $ressource_mana_info = { %$ressource_mana_info, %$mana_info }; 125: 126: return $ressource_mana_info; 3. in Koha::SharedContent::send_entity at /home/vagrant/kohaclone/Koha/SharedContent.pm line 82 79: my ($lang, $loggedinuser, $resourceid, $resourcetype, $content) = @_; 80: 81: unless ( $content ) { 82: $content = prepare_entity_data($lang, $loggedinuser, $resourceid, $resourcetype); 83: } 84: 85: my $result = process_request(build_request('post', $resourcetype, $content)); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Sorry, I couldn't reproduce this problem. Do you have Mana turned on and configured? Did you test the same process in master? Thank you for testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88189|0 |1 is obsolete| | --- Comment #8 from Michal Denar <black23@gmail.com> --- Created attachment 88953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88953&action=edit Bug 22408: Subscription entry form cleanup This patch makes a number of changes to the subscription entry form: - Make the default layout single-column. - Switch the layout to two-column only when testing prediction pattern. - Add a button to hide the prediction pattern test pane. - Change the style of some buttons and links. Add Font Awesome icons to some. - Clean up some issues with capitalization and spacing. - Make it clearer when form fields are read-only: Move "locked" form field style from addbiblio.css to staff-global.css and improve it with regard to mouse interactions To test, apply the patch and regenerate the staff client CSS. Clear your browser cache if necessary. - Go to Serials -> New subscription. - Readonly fields under "Vendor" and "Record" should show a small padlock icon. - Test the process of adding a subscription, paying special attention to the advanced pattern controls: Showing, hiding, modifying, canceling. - Test the process of editing a subscription in the same way. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88953|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 88984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88984&action=edit Bug 22408: Subscription entry form cleanup This patch makes a number of changes to the subscription entry form: - Make the default layout single-column. - Switch the layout to two-column only when testing prediction pattern. - Add a button to hide the prediction pattern test pane. - Change the style of some buttons and links. Add Font Awesome icons to some. - Clean up some issues with capitalization and spacing. - Make it clearer when form fields are read-only: Move "locked" form field style from addbiblio.css to staff-global.css and improve it with regard to mouse interactions To test, apply the patch and regenerate the staff client CSS. Clear your browser cache if necessary. - Go to Serials -> New subscription. - Readonly fields under "Vendor" and "Record" should show a small padlock icon. - Test the process of adding a subscription, paying special attention to the advanced pattern controls: Showing, hiding, modifying, canceling. - Test the process of editing a subscription in the same way. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22408 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25696 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25696 [Bug 25696] Test prediction pattern button is invalid HTML -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org