[Bug 17938] New: XSLT: if 583 is repeated, the label will appear multiple times.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Bug ID: 17938 Summary: XSLT: if 583 is repeated, the label will appear multiple times. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: karenliang.student@wegc.school.nz QA Contact: testopia@bugs.koha-community.org This will build on the patch bug 17823. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Karen <karenliang.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 --- Comment #1 from Karen <karenliang.student@wegc.school.nz> --- Created attachment 59204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59204&action=edit Bug 17938 - XSLT: if 583 is repeated, the label will appear multiple times Test plan 1) Edit a record 2) Repeat the Action note tag to add another Action note 3) Save record and confirm that the Action note label appears multiple times. 4) Apply patch and refresh page 5) All Action notes should now be on one line and separated by "|" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Karen <karenliang.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17823 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17823 [Bug 17823] XSLT: Add label for MARC 583 - Action note -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |liz@catalyst.net.nz --- Comment #2 from Liz Rea <liz@catalyst.net.nz> --- Hi Karen, I think there may be a bug in your patch - without an indicator, or with indicator 0, the notes do not display, but the action-note label and associated pipe separators do. Thanks for having a look into this problem though! Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |karenliang.student@wegc.sch | |ool.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|karenliang.student@wegc.sch |katrin.fischer@bsz-bw.de |ool.nz | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Summary|XSLT: if 583 is repeated, |XSLT: if 583 is repeated, |the label will appear |the label will appear |multiple times. |multiple times Depends on| |5919 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5919 [Bug 5919] MARC21 fields 583 and 586 should display in OPAC Details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59204|1 |0 is private| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102025&action=edit Bug 17983: Fix display of label for repeated MARC 583 - Action note fields When there are mulitple 583 on a record, the label "Action note" will be repeated for each. This fixes it, so that the label only appears once and multiple fields are separated by | following the existing pattern. Also makes sure there is a space between $z and other subfields. Note: Ind. 1 = private - These won't display in the OPAC Ind. 1 = 0 or empty - These will display in the OPAC Staff will display all 583 independent from indicator. To test: - Add one or more records with none, one and muliple 583, at least one including $z For examples see: http://www.loc.gov/marc/bibliographic/bd583.html - Verify display problems - Apply patch - Verify display is improved - one label and $z is followed by a space -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 102053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102053&action=edit Bug 17938: Fix display of label for repeated MARC 583 - Action note fields When there are mulitple 583 on a record, the label "Action note" will be repeated for each. This fixes it, so that the label only appears once and multiple fields are separated by | following the existing pattern. Also makes sure there is a space between $z and other subfields. Note: Ind. 1 = private - These won't display in the OPAC Ind. 1 = 0 or empty - These will display in the OPAC Staff will display all 583 independent from indicator. To test: - Add one or more records with none, one and muliple 583, at least one including $z For examples see: http://www.loc.gov/marc/bibliographic/bd583.html - Verify display problems - Apply patch - Verify display is improved - one label and $z is followed by a space https://bugs.koha-community.org/show_bug.cgi?id=17938 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #102025|1 |0 is patch| | Attachment #102025|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102053|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102120&action=edit Bug 17938: Fix display of label for repeated MARC 583 - Action note fields When there are mulitple 583 on a record, the label "Action note" will be repeated for each. This fixes it, so that the label only appears once and multiple fields are separated by | following the existing pattern. Also makes sure there is a space between $z and other subfields. Note: Ind. 1 = private - These won't display in the OPAC Ind. 1 = 0 or empty - These will display in the OPAC Staff will display all 583 independent from indicator. To test: - Add one or more records with none, one and muliple 583, at least one including $z For examples see: http://www.loc.gov/marc/bibliographic/bd583.html - Verify display problems - Apply patch - Verify display is improved - one label and $z is followed by a space Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Katrin, please adjust bug report's title (the most important part to me is the display of the private notes staff-side) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@bugs.koha-c |y.org |ommunity.org Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|XSLT: if 583 is repeated, |XSLT: Label of 583 is |the label will appear |repeated for multiple tags |multiple times |and private notes don't | |display in staff --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #6)
Katrin, please adjust bug report's title (the most important part to me is the display of the private notes staff-side)
You are right - thank you. Actually surprising that it hasn't worked this way before? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | --- Comment #9 from Joy Nelson <joy@bywatersolutions.com> --- backported to 19.11.x branch for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.11 CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17938 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the display for release notes| |records with multiple 583s. | |Previously the label | |"Action note" was repeated, | |now the label appears once | |and multiple fields are | |separated by a |. There is | |now a space between $z and | |other subfields. | | | |Private | |notes are now displayed in | |the staff interface. | | | |Notes: | |Indicator 1 = | |private: These will not | |display in the OPAC. | |Indicator 1 = 0 or empty: | |These will display in the | |OPAC. | |The staff interface | |will display all 583s. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org