http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9012 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch complexity|--- |Trivial patch QA Contact| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Perlcritic failing before and after applying the patch, noting results here: "require" statement with library name as string at line 11, column 12. Use a bareword instead. (Severity: 5) Bareword file handle opened at line 74, column 3. See pages 202,204 of PBP. (Severity: 5) Two-argument "open" used at line 74, column 3. See page 207 of PBP. (Severity: 5) Variable declared in conditional statement at line 439, column 9. Declare variables outside of the condition. (Severity: 5) But patch works nicely, passing QA. -- You are receiving this mail because: You are watching all bug changes.