http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12610 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29860&action=edit Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Tags.t 3) Note all unit tests pass -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29861|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29862&action=edit Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Tags.t 3) Note all unit tests pass -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29862|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29863&action=edit Bug 12610 - Replace use of DBI in C4::Tags with DBIx::Class Test Plan: 1) Apply this patch 2) prove t/db_dependent/Tags.t 3) Note all unit tests pass -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12610 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Kyle M Hall from comment #4)

3) Note all unit tests pass

It would have work if t/db_dependent/Tags.t covered all subroutines from C4::Tags. It is not the case at all, only stratify_tags is covered. Would it be possible to add some unit tests to this file to prove all your changes don't introduce regression? -- You are receiving this mail because: You are watching all bug changes.