[Bug 8935] New: transport cost matrix could be prettier
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8935 Priority: P5 - low Change sponsored?: --- Bug ID: 8935 Assignee: oleonard@myacpl.org Summary: transport cost matrix could be prettier Severity: minor Classification: Unclassified OS: All Reporter: nengard@gmail.com URL: cgi-bin/koha/admin/transport-cost-matrix.pl Hardware: All Status: NEW Version: rel_3_10 Component: Templates Depends on: 8933, 8934 Product: Koha This page might benefit from some style changes to match the styles used throughout the staff client. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8935 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8935 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8935 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12887&action=edit Bug 8935 - transport cost matrix could be prettier Correcting the template so that it follows established interface patterns and coding guidelines: - Form contents in a fieldset - Submit button in a fieldset with class "action" and with a "Cancel" link. - Errors displayed in a <div class="dialog alert"> (no custom error classes necessary). - Valid markup. - No JavaScript errors (to that end, the patch removes a call to a non-existent function, show_transport_cost_matrix) http://bugs.koha-community.org/show_bug.cgi?id=8936 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8935 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12887|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 12888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12888&action=edit [SIGNED-OFF] Bug 8935 - transport cost matrix could be prettier Correcting the template so that it follows established interface patterns and coding guidelines: - Form contents in a fieldset - Submit button in a fieldset with class "action" and with a "Cancel" link. - Errors displayed in a <div class="dialog alert"> (no custom error classes necessary). - Valid markup. - No JavaScript errors (to that end, the patch removes a call to a non-existent function, show_transport_cost_matrix) http://bugs.koha-community.org/show_bug.cgi?id=8936 Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> still works as expected and is much more visually appealing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8935 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8935 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com QA Contact| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment * small patch * template & design only patch, no side effect risk * passes koha-qa.pl passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8935 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master (3.10 only, transport cost matrix being 3.10 specific) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8935 Bug 8935 depends on bug 8933, which changed state. Bug 8933 Summary: transport cost matrix capitalization wrong http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8933 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8935 Bug 8935 depends on bug 8934, which changed state. Bug 8934 Summary: fix typo and language on transport cost matrix http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8934 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8935 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |chris@bigballofwax.co.nz Resolution|--- |FIXED --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org