[Bug 34020] New: Sequence of MARC 264 subfields different on XSLT result list and detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34020 Bug ID: 34020 Summary: Sequence of MARC 264 subfields different on XSLT result list and detail page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: hagud@orex.es QA Contact: testopia@bugs.koha-community.org Related: 15594 MArc260 has been replaced by 264 (RDA) and the improvement of xslt display for 260 has not been moved to 264 As it happened with 260, now 264 is a repeteable field, but it displays in the wrong way in OPAC and staff xslt copied from bug 15594 Sequence of MARC 264 subfields different on XSLT result list and detail page (both in staff client and OPAC) when there are repeating subfields $a and/or $b. For example: On MARC cataloguing screen it is entered as: $aNew York :$bHarperCollins ;$aMelbourne :$bCollins,$c2016 is displayed as: New York : Melbourne : HarperCollins ; Collins, 2016 It needs to match the order it is entered on the MARC cataloguing screen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34020 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15594 CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34020 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34020 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 157307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157307&action=edit Bug 34020: Preserve order of subfields in 264 display When ordered $a$b$a$b$c in the MARC object, 264 subfields are displayed $a$a$b$b$c. This goes against the standard. This patch preserves the order. 1) Edit a record and add/update a 264 fields to have subfields a, b, a, b, c in that order 1) Search for record in staff and opac, see subfields displayed in order "aabbc" in results 2) View the details page for the record in staff and opac, note same order 3) Apply the patch, restart all 4) Confirm staff and opac, results and details now follow the order of the subfields in the record's field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34020 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 157308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157308&action=edit Bug 34020: Add spans to subfields The 260 field has spans for each subfield, we should provide the same for 264 To test: 1 - Apply patch 2 - Inspect the record 264 display on staff and opac, results and details 3 - Confirm spans are constructed correctly and named sensibly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34020 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nick@bywatersolutions.com CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34020 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34020 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157307|0 |1 is obsolete| | Attachment #157308|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157313&action=edit Bug 34020: Preserve order of subfields in 264 display When ordered $a$b$a$b$c in the MARC object, 264 subfields are displayed $a$a$b$b$c. This goes against the standard. This patch preserves the order. 1) Edit a record and add/update a 264 fields to have subfields a, b, a, b, c in that order 1) Search for record in staff and opac, see subfields displayed in order "aabbc" in results 2) View the details page for the record in staff and opac, note same order 3) Apply the patch, restart all 4) Confirm staff and opac, results and details now follow the order of the subfields in the record's field Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34020 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 157314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157314&action=edit Bug 34020: Add spans to subfields The 260 field has spans for each subfield, we should provide the same for 264 To test: 1 - Apply patch 2 - Inspect the record 264 display on staff and opac, results and details 3 - Confirm spans are constructed correctly and named sensibly Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34020 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- dang.. you beat me to it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34020 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157313|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157317&action=edit Bug 34020: Preserve order of subfields in 264 display When ordered $a$b$a$b$c in the MARC object, 264 subfields are displayed $a$a$b$b$c. This goes against the standard. This patch preserves the order. 1) Edit a record and add/update a 264 fields to have subfields a, b, a, b, c in that order 1) Search for record in staff and opac, see subfields displayed in order "aabbc" in results 2) View the details page for the record in staff and opac, note same order 3) Apply the patch, restart all 4) Confirm staff and opac, results and details now follow the order of the subfields in the record's field Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34020 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157314|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157318&action=edit Bug 34020: Add spans to subfields The 260 field has spans for each subfield, we should provide the same for 264 To test: 1 - Apply patch 2 - Inspect the record 264 display on staff and opac, results and details 3 - Confirm spans are constructed correctly and named sensibly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34020 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Doh.. we clashed and came up with pretty much exactly the same solution! Passing QA on yours. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34020 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 157319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157319&action=edit Bug 34020: (QA follow-up) Indentation fix The middle 'if' block was indented a level deeper than expected. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34020 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34020 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34020 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34020 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |MARC Bibliographic data | |support -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org