[Bug 28136] New: Transferred holds are not triggering
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 Bug ID: 28136 Summary: Transferred holds are not triggering Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To test: 1 - Place a hold on an item at Branch B for pickup at Branch A 2 - Check in the item at Branch B - confirm hold and transfer 3 - Check in the item at Branch A - nothing happens? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25690 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- bug 25690 added a new status for ResFound return value in CheckReserves This value is not handled in circ/returns.pl Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119456&action=edit Bug 28136: Handle Transferred status for ResFound bug 25690 added a new 'Transferred' status to 'ResFound', this status needs to be handled in circ/returns.pl To test: 1 - Place a hold on an item at Branch B for pickup at Branch A 2 - Check in the item at Branch B - confirm hold and transfer 3 - Check in the item at Branch A - nothing happens? 4 - Apply patch 5 - Checkin in the item at Branch A - hold popup appears 6 - Clear the hold and place it again 7 - Set system preference 'HoldsAutoFill' to do 8 - Check in the item at Branch B - hold is found and confirmed 9 - Check in the item at Branch A - hold is found and confirmed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m, | |jonathan.druart@bugs.koha-c | |ommunity.org, | |joonas.kylmala@helsinki.fi Keywords| |rel_20_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119456|0 |1 is obsolete| | --- Comment #3 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Created attachment 119508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119508&action=edit Bug 28136: Handle Transferred status for ResFound bug 25690 added a new 'Transferred' status to 'ResFound', this status needs to be handled in circ/returns.pl To test: 1 - Place a hold on an item at Branch B for pickup at Branch A 2 - Check in the item at Branch B - confirm hold and transfer 3 - Check in the item at Branch A - nothing happens? 4 - Apply patch 5 - Checkin in the item at Branch A - hold popup appears 6 - Clear the hold and place it again 7 - Set system preference 'HoldsAutoFill' to do 8 - Check in the item at Branch B - hold is found and confirmed 9 - Check in the item at Branch A - hold is found and confirmed Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 --- Comment #4 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- Thanks Nick. I noticed same bug with the Processing state, I will file separate bug for it and also refactor this code here so that similar bug will not happen in the future if C4::Reserves::CheckReserves return values change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28139 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28139 [Bug 28139] Processing holds are not filled automatically -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119508|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119577&action=edit Bug 28136: Handle Transferred status for ResFound bug 25690 added a new 'Transferred' status to 'ResFound', this status needs to be handled in circ/returns.pl To test: 1 - Place a hold on an item at Branch B for pickup at Branch A 2 - Check in the item at Branch B - confirm hold and transfer 3 - Check in the item at Branch A - nothing happens? 4 - Apply patch 5 - Checkin in the item at Branch A - hold popup appears 6 - Clear the hold and place it again 7 - Set system preference 'HoldsAutoFill' to do 8 - Check in the item at Branch B - hold is found and confirmed 9 - Check in the item at Branch A - hold is found and confirmed Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We just got bitten by this one too.. Works as expected, passes QA scripts, Passing QA. I look forward to some promised refactoring/will happily lend a hand to that refactoring effort... this code is spaghetti that we're slowly getting to unpick :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 --- Comment #8 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- (In reply to Martin Renvoize from comment #6)
I look forward to some promised refactoring/will happily lend a hand to that refactoring effort... this code is spaghetti that we're slowly getting to unpick :)
The refactoring is waiting already for sign-off in bug 28139. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Joonas Kylmälä from comment #8)
(In reply to Martin Renvoize from comment #6)
I look forward to some promised refactoring/will happily lend a hand to that refactoring effort... this code is spaghetti that we're slowly getting to unpick :)
The refactoring is waiting already for sign-off in bug 28139. :)
Excellent.. that's just hit the next item in my list then :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency (bug 25690), not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28136 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org