[Bug 20676] New: svc/barcode should allow barcode to be printed without text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Bug ID: 20676 Summary: svc/barcode should allow barcode to be printed without text Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org svc/barcode currently generates the barcode using $image = GD::Barcode->new( $type, $barcode )->plot()->png();
From perldoc GD::Barcode
plot() $oGd = $oGdBar->plot([Height => $iHeight, NoText => 0 | 1]); creates GD object with barcode image for the $sTxt specified at new method. $iHeight is height of the image. If NoText is 1, the image has no text image of $sTxt. ex. my $oGdB = GD::Barcode->new('EAN13', '123456789012'); my $oGD = $oGdB->plot(NoText=>1, Height => 20); # $sGD is a GD image with Height=>20 pixels, with no text. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 --- Comment #1 from Barton Chittenden <barton@bywatersolutions.com> --- Created attachment 74915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74915&action=edit Bug 20676: svc/barcode should allow barcode to be printed without text Test plan: 1) Point web browser to <staff url>/cgi-bin/koha/svc/barcode?barcode=*12345*&nobarcode This will display a png image of the barcode 12345 with the text 12345 printed below the scannable barcode. 2) Apply patch 3) Refresh the browser. The human readable text no longer appears. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74915|0 |1 is obsolete| | --- Comment #2 from Barton Chittenden <barton@bywatersolutions.com> --- Created attachment 74939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74939&action=edit Bug 20676: svc/barcode should allow barcode to be printed without text Test plan: 1) Point web browser to <staff url>/cgi-bin/koha/svc/barcode?barcode=*12345*¬ext=1 This will display a png image of the barcode *12345* with the text *12345* printed below the scannable barcode. 2) Apply patch 3) Refresh the browser. The human readable text no longer appears. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |barton@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Extends Koha /svc/ HTTP release notes| |API. Add a notext=1 | |parameter to the 'barcode' | |entry point in order to | |prevent display barcode | |text under the barcode's | |image. CC| |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74939|0 |1 is obsolete| | --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 74940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74940&action=edit Bug 20676: svc/barcode should allow barcode to be printed without text Test plan: 1) Point web browser to <staff url>/cgi-bin/koha/svc/barcode?barcode=*12345*¬ext=1 This will display a png image of the barcode *12345* with the text *12345* printed below the scannable barcode. 2) Apply patch 3) Refresh the browser. The human readable text no longer appears. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74940|0 |1 is obsolete| | --- Comment #4 from Barton Chittenden <barton@bywatersolutions.com> --- Created attachment 74942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74942&action=edit Bug 20676: svc/barcode should allow barcode to be printed without text Test plan: 1) Point web browser to <staff url>/cgi-bin/koha/svc/barcode?barcode=*12345*¬ext=1 This will display a png image of the barcode *12345* with the text *12345* printed below the scannable barcode. 2) Apply patch 3) Refresh the browser. The human readable text no longer appears. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 --- Comment #5 from Barton Chittenden <barton@bywatersolutions.com> --- (In reply to Barton Chittenden from comment #4)
Created attachment 74942 [details] [review] Bug 20676: svc/barcode should allow barcode to be printed without text
Test plan:
1) Point web browser to <staff url>/cgi-bin/koha/svc/barcode?barcode=*12345*¬ext=1
This will display a png image of the barcode *12345* with the text *12345* printed below the scannable barcode.
2) Apply patch 3) Refresh the browser. The human readable text no longer appears.
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
This was just removing warnings that I was using for debugging. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74942|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75600&action=edit Bug 20676: svc/barcode should allow barcode to be printed without text Test plan: 1) Point web browser to <staff url>/cgi-bin/koha/svc/barcode?barcode=*12345*¬ext=1 This will display a png image of the barcode *12345* with the text *12345* printed below the scannable barcode. 2) Apply patch 3) Refresh the browser. The human readable text no longer appears. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20894 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, not backporting for 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Extends Koha /svc/ HTTP |Extends Koha /svc/barcode release notes|API. Add a notext=1 |HTTP API. Adds a notext=1 |parameter to the 'barcode' |parameter to the entry |entry point in order to |point in order to prevent |prevent display barcode |the display of barcode text |text under the barcode's |under the barcode's image. |image. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23144 [Bug 23144] Bad POD breaks svc/barcode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13545 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 [Bug 13545] Add barcode image generator service -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Bug 20676 depends on bug 13545, which changed state. Bug 13545 Summary: Add barcode image generator service https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Bug 20676 depends on bug 13545, which changed state. Bug 13545 Summary: Add barcode image generator service https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Bug 20676 depends on bug 13545, which changed state. Bug 13545 Summary: Add barcode image generator service https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20676 Bug 20676 depends on bug 13545, which changed state. Bug 13545 Summary: Add barcode image generator service https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13545 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org