http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11791 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25458&action=edit Bug 11791 - Use validation plugin when creating new city The page for adding a new city includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Cities -> New city. Try submitting the form without entering a city or zip code. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing city should also work correctly. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11791 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25458|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 25477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25477&action=edit Bug 11791 - Use validation plugin when creating new city The page for adding a new city includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Cities -> New city. Try submitting the form without entering a city or zip code. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing city should also work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11791 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25477|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25490&action=edit Bug 11791 - Use validation plugin when creating new city The page for adding a new city includes some custom form validation JavaScript which can be removed in favor of HTML5 validation attributes and Koha's built-in validation plugin. This patch does so. To test, apply the patch and go to Administration -> Cities -> New city. Try submitting the form without entering a city or zip code. This should trigger a validation warning. Submission of the form with valid data should work correctly. Editing an existing city should also work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Note: This patch changes the behavior. Before the patch, only 1 out of city and zip was required. Now both are. Since the 2 inputs were marked as required, I think they should be. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11791 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07 -- You are receiving this mail because: You are watching all bug changes.