[Bug 20756] New: OPAC "Share list" button should be styled with an icon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Bug ID: 20756 Summary: OPAC "Share list" button should be styled with an icon Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The "Share list" button in the OPAC doesn't have an icon. It should be styled to fit in with the other list controls. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75312&action=edit Bug 20756: OPAC "Share list" button should be styled with an icon This patch adds a new "share" icon to the sprite image used to style controls in the OPAC. The "share list" links now have a "sharelist" class which is used to style the links with the new icon. Also changed: Fixed the page structure markup of opac-shareshelf.tt. To test you must have the OpacAllowSharingPrivateLists system preference enabled. - Log in to the OPAC and go to Lists -> Your lists. - Create one or more private lists if necessary. - In the table of your lists there should be a "Share" link with the new icon. - View one of these lists and confirm that the "Share" link at the top of the table of list items. - Click through to the share list page and confirm that the page looks correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75313&action=edit Bug 20756: Compiled CSS This patch contains the compiled CSS file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75312|0 |1 is obsolete| | --- Comment #3 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 75498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75498&action=edit Bug 20756: OPAC "Share list" button should be styled with an icon This patch adds a new "share" icon to the sprite image used to style controls in the OPAC. The "share list" links now have a "sharelist" class which is used to style the links with the new icon. Also changed: Fixed the page structure markup of opac-shareshelf.tt. To test you must have the OpacAllowSharingPrivateLists system preference enabled. - Log in to the OPAC and go to Lists -> Your lists. - Create one or more private lists if necessary. - In the table of your lists there should be a "Share" link with the new icon. - View one of these lists and confirm that the "Share" link at the top of the table of list items. - Click through to the share list page and confirm that the page looks correct. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75313|0 |1 is obsolete| | --- Comment #4 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 75499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75499&action=edit Bug 20756: Compiled CSS This patch contains the compiled CSS file Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #5 from Séverine Queune <severine.queune@bulac.fr> --- Seems good to me on all pages. Thanks Owen ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75498|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75559&action=edit Bug 20756: OPAC "Share list" button should be styled with an icon This patch adds a new "share" icon to the sprite image used to style controls in the OPAC. The "share list" links now have a "sharelist" class which is used to style the links with the new icon. Also changed: Fixed the page structure markup of opac-shareshelf.tt. To test you must have the OpacAllowSharingPrivateLists system preference enabled. - Log in to the OPAC and go to Lists -> Your lists. - Create one or more private lists if necessary. - In the table of your lists there should be a "Share" link with the new icon. - View one of these lists and confirm that the "Share" link at the top of the table of list items. - Click through to the share list page and confirm that the page looks correct. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75499|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75560&action=edit Bug 20756: Compiled CSS This patch contains the compiled CSS file Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to master for 18.11, awesome work all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This patch has been pushed to 18.05.x and will be in 18.05.01 A minor cosmetic improvement that shouldn't confuse existing users, backported, thanks all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Not backported to 17.11.x. I prefer not to change the compiled CSS. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org