[Bug 22626] New: 'Filter paid transactions' broken on Transactions tab in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22626 Bug ID: 22626 Summary: 'Filter paid transactions' broken on Transactions tab in staff Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: oleonard@myacpl.org Target Milestone: --- The filter on the 'Transactions' tab is no longer working. Clicking on it will change the text, but the table will not be fltered. To test: - Go to an account with some paid and unpaid fines and fees - Go to Accounting tab - Click filter link on top of Transactions table - Verify nothing happens I couldn't spot a Javascript error in the console. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22626 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22626 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22626 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87618&action=edit Bug 22626: 'Filter paid transactions' broken on Transactions tab in staff This patch changes a parameter in the function which filters the DataTable of transactions. The addition of more columns to the table changed the index of the column which is being filtered. To test, apply the patch and locate a patron who has multiple fines or charges, some of them paid. Go to Accounting -> Transactions. Test the "Filter paid transactions" link. Table rows which show "0.00" in the "Oustanding" column should be hidden. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22626 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22626 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87618|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87655&action=edit Bug 22626: 'Filter paid transactions' broken on Transactions tab in staff This patch changes a parameter in the function which filters the DataTable of transactions. The addition of more columns to the table changed the index of the column which is being filtered. To test, apply the patch and locate a patron who has multiple fines or charges, some of them paid. Go to Accounting -> Transactions. Test the "Filter paid transactions" link. Table rows which show "0.00" in the "Oustanding" column should be hidden. Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22626 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22626 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87655|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87665&action=edit Bug 22626: 'Filter paid transactions' broken on Transactions tab in staff This patch changes a parameter in the function which filters the DataTable of transactions. The addition of more columns to the table changed the index of the column which is being filtered. To test, apply the patch and locate a patron who has multiple fines or charges, some of them paid. Go to Accounting -> Transactions. Test the "Filter paid transactions" link. Table rows which show "0.00" in the "Oustanding" column should be hidden. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22626 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22626 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22626 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- I don't think 18.05.x need this as that functionality works fine. Adding the patch breaks it. Not backporting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22626 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22626 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23143 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23143 [Bug 23143] [18.11] Filter paid transactions not working -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org