[Bug 8402] New: replace 'install_misc/debian.packages' file with 'koha-debian-deps.pl' script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 Priority: P5 - low Change sponsored?: --- Bug ID: 8402 Assignee: gmcharlt@gmail.com Summary: replace 'install_misc/debian.packages' file with 'koha-debian-deps.pl' script Severity: enhancement Classification: Unclassified OS: All Reporter: mtj@kohaaloha.com Hardware: All Status: NEW Version: master Component: Installation and upgrade (command-line installer) Product: Koha we now have 2 files in the Koha repo with debian package info - install_misc/debian.packages - debian/control thats very bad! deleting 'install_misc/debian.packages' would mean we only have one :) the general plan is to delete the install_misc/debian.packages file from the repo then dynamically-generate(tm) an 'install_misc/debian.packages' file using a script and the debian/control file, when installing Koha something like this... $ ./koha-debian-deps.pl > install_misc/debian.packages $ sudo aptitude $(<install_misc/debian.packages) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- What populates C4/Installer/PerlDependencies.pm? The part that isn't in PerlDependencies.pm are the various applications/commands that need installing as well, which I see are in other sections. I agree there needs to be consistency, but what about the bigger picture of the perl dependencies required for a git install? I noticed you did a "sudo aptitude" command-line. Is this preferred over a: sudo dpkg --set-selections < install_misc/{OS}.packages sudo dselect way of doing it? aptitude may not be installed by default, and yes, neither is dselect. Also, notice I said {OS}.packages? The library names may be different between debian-based OSes, and this is why I like "apt-file" for finding a reasonable name. Check out bug 8517 for a script I wrote which uses koha_perl_deps.pl to add missing items to {OS}.packages. I believe a newer incarnation of it is in the release-tools git repo. As long as apt-file is installed and up to date and PerlDependencies is correct. It can be used to determine missing pieces and add them into the .packages file. Does PerlDependencies.pm get updated more accurately than debian/control? Perhaps the solution isn't to delete debian/control which is likely used to build packages where as install_misc/debian.packages is used for a git install, but rather make sure they are both updated from what may be the source: PerlDependencies.pm? Just some related brainstorming. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- While thinking over the problem of Test::MockModule and DBD::Mock not being installed, I was chatting with "eythian" on the IRC channel. It turns out that that debian/update-control scripts uses the list-deps script which works it magic back to PerlDependencies.pm $ cd debian $ grep ": lib" control | wc -l 1 $ grep "^ lib" control | wc -l 85 $ cd ../install_misc $ grep "^\s*lib" debian.packages | wc -l 102 $ cd ../C4/Installer $ less PerlDependencies.pm # I visually inspected to make sure everything was a tuple $ grep "min_ver" PerlDependencies.pm | wc -l 106 Now here's one possible reason for the difference: two libraries (blah::foo::bar and blah::foo) are in the same package (libblah-foo-perl). Useful commands that came to mind: $ grep "^ '" PerlDependencies.pm | cut -f2 -d"'" | sort > ~/PerlDepsPerl.txt $ grep "^ '" PerlDependencies.pm | cut -f2 -d"'" | sort | sed -e "s#::#-#g" | tr "[:upper:]" "[:lower:]" | perl -e "@data=<STDIN>; for \$line (@data) { chomp \$line; print \"lib\$line-perl\\n\"; }" > ~/PerlDepsLib.txt $ grep "^ '" PerlDependencies.pm | cut -f2 -d"'" | sort | sed -e "s#::#\/#g" | perl -e "@data=<STDIN>; for \$line (@data) { chomp \$line; print \"\$line.pm\\n\"; }" > ~/PerlDepsPath.txt $ cd $ for i in `cat PerlDepsPath.txt`; do echo $i; apt-file search -x "^/usr/((lib|share)/perl5|(lib|share)/perl/[0-9.]+)/$i\$"; done My thoughts are that install_misc/debian.packages could easily be built with a little bit of extra scripting, when the debian/control file is generated. Though, I still need to understand how the |'s are handled in the control file, as they are listed as two lines in the sample for loop above. This beginning to wade into the bowels of debian packaging stuffs also may have demonstrated that I need to tweak that check_deps.sh script some -- choose the non-xpm version of GD. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 --- Comment #3 from Mason James <mtj@kohaaloha.com> --- Created attachment 16906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16906&action=edit bug 8402 - a script to build ./install_misc/debian.packages from ./debian/control to test 1/ delete existing ./install_misc/debian.packages file rm ./install_misc/debian.packages 2/ run script ./install_misc/build-pkg-file.pl -f 3/ view new ./install_misc/debian.packages file more ./install_misc/debian.packages -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16906|0 |1 is obsolete| | --- Comment #4 from Mason James <mtj@kohaaloha.com> --- Created attachment 16907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16907&action=edit bug 8402 - a script to build ./install_misc/debian.packages from ./debian/control to test 1/ delete existing ./install_misc/debian.packages file rm ./install_misc/debian.packages 2/ run script ./install_misc/build-pkg-file.pl -f 3/ view new ./install_misc/debian.packages file more ./install_misc/debian.packages -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16907|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17392&action=edit bug 8402 - a script to build ./install_misc/debian.packages from ./debian/control to test 1/ delete existing ./install_misc/debian.packages file rm ./install_misc/debian.packages 2/ run script ./install_misc/build-pkg-file.pl -f 3/ view new ./install_misc/debian.packages file more ./install_misc/debian.packages Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|replace |generate |'install_misc/debian.packag |'install_misc/debian.packag |es' file with |es' file from |'koha-debian-deps.pl' |debian/control file |script | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17392|0 |1 is obsolete| | --- Comment #6 from Mason James <mtj@kohaaloha.com> --- Created attachment 17676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17676&action=edit bug 8402 - generate 'install_misc/debian.packages' file from debian/control file to test... - rename ./install_misc/debian.packages file mv ./install_misc/debian.packages ./install_misc/debian.packages.old - apply patch git bz apply 8402 - run script ./koha-debian-deps.pl -r > install_misc/debian.packages - compare improved package file diff ./install_misc/debian.packages ./install_misc/debian.packages.old - install packages sudo apt-get install $( < install_misc/debian.packages) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |normal --- Comment #7 from Mason James <mtj@kohaaloha.com> ---
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Works as advertised
i've made some small improvements to the script... perhaps these changes should be re-tested? i've set the patch back to 'needs signoff' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17676|0 |1 is obsolete| | --- Comment #8 from Mason James <mtj@kohaaloha.com> --- Created attachment 17677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17677&action=edit bug 8402 - generate 'install_misc/debian.packages' file from debian/control file to test... - rename ./install_misc/debian.packages file mv ./install_misc/debian.packages ./install_misc/debian.packages.old - apply patch git bz apply 8402 - run script ./koha-debian-deps.pl -r > install_misc/debian.packages - compare improved package file diff ./install_misc/debian.packages ./install_misc/debian.packages.old - install packages sudo apt-get install $( < install_misc/debian.packages) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |srdjan@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m Assignee|gmcharlt@gmail.com |mtj@kohaaloha.com QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: 4 smalls remarks: 1/ FAIL install_misc/koha-debian-deps.pl FAIL pod *** ERROR: Spurious text after =pod in file install_misc/koha-debian-deps.pl Need a blank line under "=pod" 2/ Please use Pod::Usage. 3/ Maybe should you use C4::Context->config('intranetdir') . '/debian/control' instead of using a relative path. I don't know if it is relevant given that is adds a dependence to C4::Context. 4/ It is useless to return 1 at the end of a perl script. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Given that there is the ability to: $ sudo apt-get install koha-deps koha-perldeps Are - install_misc/debian.packages - install_misc/ubuntu.packages - install_misc/ubuntu.12.04.packages - install_misc/ubuntu.10.04.packages - install_misc/ubuntu-packages.sh - this script suggestion even necessary? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 --- Comment #11 from Mason James <mtj@kohaaloha.com> --- (In reply to M. Tompsett from comment #10)
Given that there is the ability to: $ sudo apt-get install koha-deps koha-perldeps
Are - install_misc/debian.packages - install_misc/ubuntu.packages - install_misc/ubuntu.12.04.packages - install_misc/ubuntu.10.04.packages - install_misc/ubuntu-packages.sh - this script suggestion even necessary?
no, i don't think they are necessary i would be happy with a patch that removed these files -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17677|0 |1 is obsolete| | --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 33506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33506&action=edit bug 8402 - generate 'install_misc/debian.packages' file from debian/control file to test... - rename ./install_misc/debian.packages file mv ./install_misc/debian.packages ./install_misc/debian.packages.old - apply patch git bz apply 8402 - run script ./koha-debian-deps.pl -r > install_misc/debian.packages - compare improved package file diff ./install_misc/debian.packages ./install_misc/debian.packages.old - install packages sudo apt-get install $( < install_misc/debian.packages) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33506|0 |1 is obsolete| | --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 33507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33507&action=edit bug 8402 - generate 'install_misc/debian.packages' file from debian/control file to test... - rename ./install_misc/debian.packages file mv ./install_misc/debian.packages ./install_misc/debian.packages.old - apply patch git bz apply 8402 - run script ./koha-debian-deps.pl -r > install_misc/debian.packages - compare improved package file diff ./install_misc/debian.packages ./install_misc/debian.packages.old - install packages sudo apt-get install $( < install_misc/debian.packages) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #9)
QA comment:
4 smalls remarks: 1/ FAIL install_misc/koha-debian-deps.pl FAIL pod *** ERROR: Spurious text after =pod in file install_misc/koha-debian-deps.pl Need a blank line under "=pod"
Added blank line.
2/ Please use Pod::Usage.
Not sure how to do that, but it's likely related to the print_usage() function.
3/ Maybe should you use C4::Context->config('intranetdir') . '/debian/control' instead of using a relative path. I don't know if it is relevant given that is adds a dependence to C4::Context.
Which is good, because then: ./install_misc/koha-debian-deps.pl -r works nicely without having to be in a fixed location.
4/ It is useless to return 1 at the end of a perl script.
removed. Also, I probably should have cleaned up the licensing. ;) I was also disappointed, because the list generated does not include gcc, which is required for some of the makes. So, I think I'll leave this Failed QA. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org