[Bug 16995] New: Remove event attributes from two include files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16995 Bug ID: 16995 Summary: Remove event attributes from two include files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org cat-toolbar.inc and members-toolbar.inc contain event attributes which should be removed in favor of defining events in JavaScript. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16995 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16995 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 53790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53790&action=edit Bug 16995 - Remove event attributes from two include files This patch removes event attributes from two include files: cat-toolbar.inc and members-toolbar.inc. In cat-toolbar.inc an unused <form> tag with an "onsubmit" attribute has been removed. To test, apply the patch and: - View the detail page for any bibliographic record. All toolbar buttons ("New," "Edit," "Save," etc.) should work as expected. - View the detail page for any patron. Click the "Add message" button in the toolbar. Selecting a predefined note should correctly populate the textarea with your selected message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16995 Claire Gravely <c.gravely@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16995 Claire Gravely <c.gravely@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53790|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <c.gravely@arts.ac.uk> --- Created attachment 53812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53812&action=edit Bug 16995 - Remove event attributes from two include files This patch removes event attributes from two include files: cat-toolbar.inc and members-toolbar.inc. In cat-toolbar.inc an unused <form> tag with an "onsubmit" attribute has been removed. To test, apply the patch and: - View the detail page for any bibliographic record. All toolbar buttons ("New," "Edit," "Save," etc.) should work as expected. - View the detail page for any patron. Click the "Add message" button in the toolbar. Selecting a predefined note should correctly populate the textarea with your selected message. Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16995 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16995 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53812|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 53822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53822&action=edit [PASSED QA] Bug 16995 - Remove event attributes from two include files This patch removes event attributes from two include files: cat-toolbar.inc and members-toolbar.inc. In cat-toolbar.inc an unused <form> tag with an "onsubmit" attribute has been removed. To test, apply the patch and: - View the detail page for any bibliographic record. All toolbar buttons ("New," "Edit," "Save," etc.) should work as expected. - View the detail page for any patron. Click the "Add message" button in the toolbar. Selecting a predefined note should correctly populate the textarea with your selected message. Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16995 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org