[Bug 19935] New: Move C4::Members::GetPendingIssues to the Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Bug ID: 19935 Summary: Move C4::Members::GetPendingIssues to the Koha namespace Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19933 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 [Bug 19933] Move C4::Members::patronflags to the Koha namespace - part 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70351&action=edit Bug 19935: Add Koha::Patron->pending_checkouts To move this subroutine out of the C4 namespace we face the same problematic as bug 17553 (with GetOverduesForPatron). We need to provide an equivalent method and so return all the related value for a given checkout. We can acchieve the easily using Koha::Object->unblessed_all_relateds, but we need to keep in mind that it is a temporary move. Indeed we will want to use our API to only access/retrive values we really need. The whole trick could be removed when the current syntax for notices will be deprecated and removed. Note: this method returns the same number of elements than ->checkouts They indeed returns the same things, but it sounds better to me to have a different method to highlight (from the callers) where does it come from (C4::Members::GetPendingIssues). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70352&action=edit Bug 19935: Replace GetPendingIssues - IssueSlip Luckily we have a good test coverage here! Test plan: Print issue slips before and after these patches (with overdues, etc.) They should be the same. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70353&action=edit Bug 19935: Replace GetPendingIssues - ILSDI Here we should only access to what we want in the template, but let do it as it for now. Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=542&show_contact=0&show_loans=1 With 42 a borrowernumber with checkouts Before and after these patches the XML must be the same -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70354&action=edit Bug 19935: Replace GetPendingIssues - Discharges We should actually use Koha::Patron->checkouts here to avoid the prefetch. Test plan: A patron with checkouts cannot get a discharge -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70355&action=edit Bug 19935: Replace GetPendingIssues - deletemem.pl Same as previously, we just want Koha::Patron->checkouts->count to know if a patron has checkouts. Test plan: Confirm that you cannot delete a patron's card if they have pending checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70356&action=edit Bug 19935: Replace GetPendingIssues - summary-print We are in the notices part, so we need to fetch all the data to avoid regressions. Test plan: Print a summary slip before and after this patch. They must be the same -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70357&action=edit Bug 19935: Replace GetPendingIssues - opac-ics.pl We only need the biblio title and the barcode, we should not need the whole prefetch. Test plan: On your OPAC summary page export your checkout list using the "Download as iCal/.ics file" link. Before and after the patchset, the generated files must be the same -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70358&action=edit Bug 19935: Replace GetPendingIssues - opac-user.pl At first glance we just need the biblio title and the subtitle (in addition of the fines info), we should not need the prefetch. Test plan: Loggin at the OPAC, on the summary page you should see your checkouts and overdues with the correct values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70359&action=edit Bug 19935: Replace GetPendingIssues - sco-main Same as previously, we do not need all the prefetched values here, just a few. Test plan: Use the self checkout module to check some items out -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70360&action=edit Bug 19935: Replace GetPendingIssues - SIP Sounds like we do not need related fields or 'overdue' flag here. No idea how to confirm there is no regression here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70361&action=edit Bug 19935: Replace GetPendingIssues - Remove the residue Here we are, no more occurrences of GetPendingIssues, we can remove the tests and subroutine \o/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70355|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71807&action=edit Bug 19935: Replace GetPendingIssues - deletemem.pl Same as previously, we just want Koha::Patron->checkouts->count to know if a patron has checkouts. Test plan: Confirm that you cannot delete a patron's card if they have pending checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70356|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71808&action=edit Bug 19935: Replace GetPendingIssues - summary-print We are in the notices part, so we need to fetch all the data to avoid regressions. Test plan: Print a summary slip before and after this patch. They must be the same -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70357|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71809&action=edit Bug 19935: Replace GetPendingIssues - opac-ics.pl We only need the biblio title and the barcode, we should not need the whole prefetch. Test plan: On your OPAC summary page export your checkout list using the "Download as iCal/.ics file" link. Before and after the patchset, the generated files must be the same -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70358|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71810&action=edit Bug 19935: Replace GetPendingIssues - opac-user.pl At first glance we just need the biblio title and the subtitle (in addition of the fines info), we should not need the prefetch. Test plan: Loggin at the OPAC, on the summary page you should see your checkouts and overdues with the correct values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70359|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71811&action=edit Bug 19935: Replace GetPendingIssues - sco-main Same as previously, we do not need all the prefetched values here, just a few. Test plan: Use the self checkout module to check some items out -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70360|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71812&action=edit Bug 19935: Replace GetPendingIssues - SIP Sounds like we do not need related fields or 'overdue' flag here. No idea how to confirm there is no regression here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70361|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71813&action=edit Bug 19935: Replace GetPendingIssues - Remove the residue Here we are, no more occurrences of GetPendingIssues, we can remove the tests and subroutine \o/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19926 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19926 [Bug 19926] Add the Koha::Object->unblessed_all_relateds method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Benjamin Rokseth <benjamin.rokseth@deichman.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70351|0 |1 is obsolete| | --- Comment #19 from Benjamin Rokseth <benjamin.rokseth@deichman.no> --- Created attachment 72752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72752&action=edit Bug 19935: Add Koha::Patron->pending_checkouts To move this subroutine out of the C4 namespace we face the same problematic as bug 17553 (with GetOverduesForPatron). We need to provide an equivalent method and so return all the related value for a given checkout. We can acchieve the easily using Koha::Object->unblessed_all_relateds, but we need to keep in mind that it is a temporary move. Indeed we will want to use our API to only access/retrive values we really need. The whole trick could be removed when the current syntax for notices will be deprecated and removed. Note: this method returns the same number of elements than ->checkouts They indeed returns the same things, but it sounds better to me to have a different method to highlight (from the callers) where does it come from (C4::Members::GetPendingIssues). Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Benjamin Rokseth <benjamin.rokseth@deichman.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70352|0 |1 is obsolete| | --- Comment #20 from Benjamin Rokseth <benjamin.rokseth@deichman.no> --- Created attachment 72753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72753&action=edit Bug 19935: Replace GetPendingIssues - IssueSlip Luckily we have a good test coverage here! Test plan: Print issue slips before and after these patches (with overdues, etc.) They should be the same. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Benjamin Rokseth <benjamin.rokseth@deichman.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70353|0 |1 is obsolete| | --- Comment #21 from Benjamin Rokseth <benjamin.rokseth@deichman.no> --- Created attachment 72754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72754&action=edit Bug 19935: Replace GetPendingIssues - ILSDI Here we should only access to what we want in the template, but let do it as it for now. Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=542&show_contact=0&show_loans=1 With 42 a borrowernumber with checkouts Before and after these patches the XML must be the same Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Benjamin Rokseth <benjamin.rokseth@deichman.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70354|0 |1 is obsolete| | --- Comment #22 from Benjamin Rokseth <benjamin.rokseth@deichman.no> --- Created attachment 72755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72755&action=edit Bug 19935: Replace GetPendingIssues - Discharges We should actually use Koha::Patron->checkouts here to avoid the prefetch. Test plan: A patron with checkouts cannot get a discharge Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Benjamin Rokseth <benjamin.rokseth@deichman.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71807|0 |1 is obsolete| | --- Comment #23 from Benjamin Rokseth <benjamin.rokseth@deichman.no> --- Created attachment 72756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72756&action=edit Bug 19935: Replace GetPendingIssues - deletemem.pl Same as previously, we just want Koha::Patron->checkouts->count to know if a patron has checkouts. Test plan: Confirm that you cannot delete a patron's card if they have pending checkouts Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Benjamin Rokseth <benjamin.rokseth@deichman.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71808|0 |1 is obsolete| | --- Comment #24 from Benjamin Rokseth <benjamin.rokseth@deichman.no> --- Created attachment 72757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72757&action=edit Bug 19935: Replace GetPendingIssues - summary-print We are in the notices part, so we need to fetch all the data to avoid regressions. Test plan: Print a summary slip before and after this patch. They must be the same Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Benjamin Rokseth <benjamin.rokseth@deichman.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71809|0 |1 is obsolete| | --- Comment #25 from Benjamin Rokseth <benjamin.rokseth@deichman.no> --- Created attachment 72758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72758&action=edit Bug 19935: Replace GetPendingIssues - opac-ics.pl We only need the biblio title and the barcode, we should not need the whole prefetch. Test plan: On your OPAC summary page export your checkout list using the "Download as iCal/.ics file" link. Before and after the patchset, the generated files must be the same Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Benjamin Rokseth <benjamin.rokseth@deichman.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71810|0 |1 is obsolete| | --- Comment #26 from Benjamin Rokseth <benjamin.rokseth@deichman.no> --- Created attachment 72759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72759&action=edit Bug 19935: Replace GetPendingIssues - opac-user.pl At first glance we just need the biblio title and the subtitle (in addition of the fines info), we should not need the prefetch. Test plan: Loggin at the OPAC, on the summary page you should see your checkouts and overdues with the correct values Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Benjamin Rokseth <benjamin.rokseth@deichman.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71811|0 |1 is obsolete| | --- Comment #27 from Benjamin Rokseth <benjamin.rokseth@deichman.no> --- Created attachment 72760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72760&action=edit Bug 19935: Replace GetPendingIssues - sco-main Same as previously, we do not need all the prefetched values here, just a few. Test plan: Use the self checkout module to check some items out Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Benjamin Rokseth <benjamin.rokseth@deichman.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71812|0 |1 is obsolete| | --- Comment #28 from Benjamin Rokseth <benjamin.rokseth@deichman.no> --- Created attachment 72761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72761&action=edit Bug 19935: Replace GetPendingIssues - SIP Sounds like we do not need related fields or 'overdue' flag here. No idea how to confirm there is no regression here. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Benjamin Rokseth <benjamin.rokseth@deichman.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71813|0 |1 is obsolete| | --- Comment #29 from Benjamin Rokseth <benjamin.rokseth@deichman.no> --- Created attachment 72762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72762&action=edit Bug 19935: Replace GetPendingIssues - Remove the residue Here we are, no more occurrences of GetPendingIssues, we can remove the tests and subroutine \o/ Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Benjamin Rokseth <benjamin.rokseth@deichman.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth@deichman.n | |o Status|Needs Signoff |Signed Off --- Comment #30 from Benjamin Rokseth <benjamin.rokseth@deichman.no> --- Tested all affected parts, that I did not even know existed. puh. Great work, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Bug 19935 depends on bug 19933, which changed state. Bug 19933 Summary: Move C4::Members::patronflags to the Koha namespace - part 1 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19933 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #31 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 72755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72755 Bug 19935: Replace GetPendingIssues - Discharges Review of attachment 72755: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19935&attachment=72755) ----------------------------------------------------------------- ::: Koha/Patron/Discharge.pm @@ +9,4 @@
use Koha::Database; use Koha::DateUtils qw( dt_from_string output_pref ); +use Koha::Checkouts;
should remain Koha::Patrons @@ +35,5 @@
+ my $patron = Koha::Patrons->find( $params->{borrowernumber} ); + return unless $patron; + + my $has_pending_checkouts = $patron->pending_checkouts->count;
shouldn't it be this? As said in commit message? $patron->checkouts->count; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #32 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 72756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72756 Bug 19935: Replace GetPendingIssues - deletemem.pl Review of attachment 72756: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19935&attachment=72756) ----------------------------------------------------------------- ::: members/deletemem.pl @@ +77,2 @@
my $charges = $patron->account->non_issues_charges; +my $countissues = $patron->pending_checkouts->count;
$patron->checkouts->count; should be enough as said in commit message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #33 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 72759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72759 Bug 19935: Replace GetPendingIssues - opac-user.pl Review of attachment 72759: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19935&attachment=72759) ----------------------------------------------------------------- ::: opac/opac-user.pl @@ +180,4 @@
my @overdues; my @issuedat; my $itemtypes = { map { $_->{itemtype} => $_ } @{ Koha::ItemTypes->search_with_localization->unblessed } }; +my $pending_checkouts = $patron->pending_checkouts({}, { order_by => [ { -desc => 'date_due' }, { -asc => 'issue_id' } ] });
I think it should be $patron->pending_checkouts->search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #34 from Josef Moravec <josef.moravec@gmail.com> ---
Created attachment 72761 [details] [review] Bug 19935: Replace GetPendingIssues - SIP
Sounds like we do not need related fields or 'overdue' flag here. No idea how to confirm there is no regression here.
Reading through the code, it even looks like we donẗ need more then barcode... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72752|0 |1 is obsolete| | Attachment #72753|0 |1 is obsolete| | Attachment #72754|0 |1 is obsolete| | Attachment #72755|0 |1 is obsolete| | Attachment #72756|0 |1 is obsolete| | Attachment #72757|0 |1 is obsolete| | Attachment #72758|0 |1 is obsolete| | Attachment #72759|0 |1 is obsolete| | Attachment #72760|0 |1 is obsolete| | Attachment #72761|0 |1 is obsolete| | Attachment #72762|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73557&action=edit Bug 19935: Add Koha::Patron->pending_checkouts To move this subroutine out of the C4 namespace we face the same problematic as bug 17553 (with GetOverduesForPatron). We need to provide an equivalent method and so return all the related value for a given checkout. We can acchieve the easily using Koha::Object->unblessed_all_relateds, but we need to keep in mind that it is a temporary move. Indeed we will want to use our API to only access/retrive values we really need. The whole trick could be removed when the current syntax for notices will be deprecated and removed. Note: this method returns the same number of elements than ->checkouts They indeed returns the same things, but it sounds better to me to have a different method to highlight (from the callers) where does it come from (C4::Members::GetPendingIssues). Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73558&action=edit Bug 19935: Replace GetPendingIssues - IssueSlip Luckily we have a good test coverage here! Test plan: Print issue slips before and after these patches (with overdues, etc.) They should be the same. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73559&action=edit Bug 19935: Replace GetPendingIssues - ILSDI Here we should only access to what we want in the template, but let do it as it for now. Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=542&show_contact=0&show_loans=1 With 42 a borrowernumber with checkouts Before and after these patches the XML must be the same Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73560&action=edit Bug 19935: Replace GetPendingIssues - Discharges We should actually use Koha::Patron->checkouts here to avoid the prefetch. Test plan: A patron with checkouts cannot get a discharge Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73561&action=edit Bug 19935: Replace GetPendingIssues - deletemem.pl Same as previously, we just want Koha::Patron->checkouts->count to know if a patron has checkouts. Test plan: Confirm that you cannot delete a patron's card if they have pending checkouts Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73562&action=edit Bug 19935: Replace GetPendingIssues - summary-print We are in the notices part, so we need to fetch all the data to avoid regressions. Test plan: Print a summary slip before and after this patch. They must be the same Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73563&action=edit Bug 19935: Replace GetPendingIssues - opac-ics.pl We only need the biblio title and the barcode, we should not need the whole prefetch. Test plan: On your OPAC summary page export your checkout list using the "Download as iCal/.ics file" link. Before and after the patchset, the generated files must be the same Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73564&action=edit Bug 19935: Replace GetPendingIssues - opac-user.pl At first glance we just need the biblio title and the subtitle (in addition of the fines info), we should not need the prefetch. Test plan: Loggin at the OPAC, on the summary page you should see your checkouts and overdues with the correct values Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73565&action=edit Bug 19935: Replace GetPendingIssues - sco-main Same as previously, we do not need all the prefetched values here, just a few. Test plan: Use the self checkout module to check some items out Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73566&action=edit Bug 19935: Replace GetPendingIssues - SIP Sounds like we do not need related fields or 'overdue' flag here. No idea how to confirm there is no regression here. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73567&action=edit Bug 19935: Replace GetPendingIssues - Remove the residue Here we are, no more occurrences of GetPendingIssues, we can remove the tests and subroutine \o/ Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73568&action=edit Bug 19935: Use ->checkouts when ->pending_checkouts->count was used -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73569&action=edit Bug 19935: (follow-up) Replace GetPendingIssues - opac-user.pl Syntax issue, can be squashed on pushing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73557|0 |1 is obsolete| | Attachment #73558|0 |1 is obsolete| | Attachment #73559|0 |1 is obsolete| | Attachment #73560|0 |1 is obsolete| | Attachment #73561|0 |1 is obsolete| | Attachment #73562|0 |1 is obsolete| | Attachment #73563|0 |1 is obsolete| | Attachment #73564|0 |1 is obsolete| | Attachment #73565|0 |1 is obsolete| | Attachment #73566|0 |1 is obsolete| | Attachment #73567|0 |1 is obsolete| | Attachment #73568|0 |1 is obsolete| | Attachment #73569|0 |1 is obsolete| | --- Comment #48 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73570&action=edit Bug 19935: Add Koha::Patron->pending_checkouts To move this subroutine out of the C4 namespace we face the same problematic as bug 17553 (with GetOverduesForPatron). We need to provide an equivalent method and so return all the related value for a given checkout. We can acchieve the easily using Koha::Object->unblessed_all_relateds, but we need to keep in mind that it is a temporary move. Indeed we will want to use our API to only access/retrive values we really need. The whole trick could be removed when the current syntax for notices will be deprecated and removed. Note: this method returns the same number of elements than ->checkouts They indeed returns the same things, but it sounds better to me to have a different method to highlight (from the callers) where does it come from (C4::Members::GetPendingIssues). Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #49 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73571&action=edit Bug 19935: Replace GetPendingIssues - IssueSlip Luckily we have a good test coverage here! Test plan: Print issue slips before and after these patches (with overdues, etc.) They should be the same. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #50 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73572&action=edit Bug 19935: Replace GetPendingIssues - ILSDI Here we should only access to what we want in the template, but let do it as it for now. Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=542&show_contact=0&show_loans=1 With 42 a borrowernumber with checkouts Before and after these patches the XML must be the same Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #51 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73573&action=edit Bug 19935: Replace GetPendingIssues - Discharges We should actually use Koha::Patron->checkouts here to avoid the prefetch. Test plan: A patron with checkouts cannot get a discharge Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #52 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73574&action=edit Bug 19935: Replace GetPendingIssues - deletemem.pl Same as previously, we just want Koha::Patron->checkouts->count to know if a patron has checkouts. Test plan: Confirm that you cannot delete a patron's card if they have pending checkouts Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #53 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73575&action=edit Bug 19935: Replace GetPendingIssues - summary-print We are in the notices part, so we need to fetch all the data to avoid regressions. Test plan: Print a summary slip before and after this patch. They must be the same Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #54 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73576&action=edit Bug 19935: Replace GetPendingIssues - opac-ics.pl We only need the biblio title and the barcode, we should not need the whole prefetch. Test plan: On your OPAC summary page export your checkout list using the "Download as iCal/.ics file" link. Before and after the patchset, the generated files must be the same Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #55 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73577&action=edit Bug 19935: Replace GetPendingIssues - opac-user.pl At first glance we just need the biblio title and the subtitle (in addition of the fines info), we should not need the prefetch. Test plan: Loggin at the OPAC, on the summary page you should see your checkouts and overdues with the correct values Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #56 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73578&action=edit Bug 19935: Replace GetPendingIssues - sco-main Same as previously, we do not need all the prefetched values here, just a few. Test plan: Use the self checkout module to check some items out Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #57 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73579&action=edit Bug 19935: Replace GetPendingIssues - SIP Sounds like we do not need related fields or 'overdue' flag here. No idea how to confirm there is no regression here. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #58 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73580&action=edit Bug 19935: Replace GetPendingIssues - Remove the residue Here we are, no more occurrences of GetPendingIssues, we can remove the tests and subroutine \o/ Signed-off-by: Benjamin Rokseth <benjamin.rokseth@deichman.no> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #59 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73581&action=edit Bug 19935: Use ->checkouts when ->pending_checkouts->count was used Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #60 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73582&action=edit Bug 19935: (follow-up) Replace GetPendingIssues - opac-user.pl Syntax issue, can be squashed on pushing. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #61 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Bug 19935 depends on bug 19926, which changed state. Bug 19926 Summary: Add the Koha::Object->unblessed_all_relateds method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19926 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |nick@bywatersolutions.com Resolution|--- |FIXED --- Comment #62 from Nick Clemens <nick@bywatersolutions.com> --- Enhancement, not backporting to 17.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21486 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21486 [Bug 21486] SIP does not return checked out (charged) items on patron_information request -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org