[Bug 5693] New: if parentheses used in ccode then searches against ccode fail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5693 Summary: if parentheses used in ccode then searches against ccode fail Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Searching AssignedTo: gmcharlt@gmail.com ReportedBy: reed@catalyst.net.nz QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 If you set a CCODE value which contains parentheses like "S(B)" then when you search against it the parentheses confuse the search query parser per: opac-search.pl: WARNING: query problem with (mc-ccode=S(B)) ZOOM error 10014 "CCL parsing error" (addinfo: "')' expected") from diag-set 'ZOOM' at /home/reed/Catalyst/koha/koha/C4/Search.pm line 346. Patch provide wraps the mc-ccode value in quotes to get around this. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5693 --- Comment #1 from Reed Wade <reed@catalyst.net.nz> 2011-02-04 03:29:48 UTC --- Created attachment 3065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3065 patch to wrap mc-ccode search limit in quotes -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5693 Reed Wade <reed@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored --- Comment #2 from Reed Wade <reed@catalyst.net.nz> 2011-02-04 03:30:33 UTC --- Work is sponsored by Opus -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5693 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |nengard@gmail.com AssignedTo|gmcharlt@gmail.com |reed@catalyst.net.nz Severity|enhancement |normal --- Comment #3 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-03-03 08:36:58 UTC --- This bug is mentioned in: bug 5693 - mc-ccode parens fix http://lists.koha-community.org/pipermail/koha-patches/2011-February/013766.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5693 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5693 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-05 19:36:43 UTC --- Pushed, please test and mark resolved -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5693 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |julian.maurice@biblibre.com Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5693 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-14 20:28:53 UTC --- This now ends up with a url like this a href="/cgi-bin/koha/opac-search.pl?idx=kw&q=a&limit=mc-ccode:"AF"&sort_by=relevance&limit=su-geo:Alabama." title="Alabama.">Alabama.</a> With the "AF" breaking it obviously, working on a follow up patch to escape the html where limit_cgi is used in the templates -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5693 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |Signed Off --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-14 20:42:16 UTC --- Follow up patch submitted -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5693 --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-14 20:43:45 UTC --- Created attachment 3296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3296 Follow up fix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5693 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-14 21:05:09 UTC --- Follow up patch pushed, please test and mark resolved -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5693 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org