[Bug 4016] New: holds listing wrong pick up location
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4016 Summary: holds listing wrong pick up location Product: Koha Version: HEAD Platform: PC URL: cgi-bin/koha/reserve/request.pl?biblionumber=1 OS/Version: All Status: NEW Severity: blocker Priority: P5 Component: Circulation AssignedTo: henridamien@koha-fr.org ReportedBy: nengard@gmail.com Estimated Hours: 0.0 Change sponsored?: --- Created an attachment (id=1444) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1444) holds list See attached. On the list of holds for a bib record all items say they are being picked up at the first library on the list - even though they each had a different library selected when I put the holds on the items. This does not appear to be just a display problem either. When checking in an item that is on hold it is asking to be transferred to the library shown on this list - not the library I selected when placing the hold in the first place. Assigning Blocker Status since it's impossible to have a patron pick up a hold at a library other than the first one listed - seems like a big deal to me ;) -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4016 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2010-02-10 13:48:30 --- These are the steps: #1 search for bib record http://localhost:8080/cgi-bin/koha/catalogue/detail.pl?biblionumber=1373 #2 click place hold tab http://localhost:8080/cgi-bin/koha/reserve/request.pl?biblionumber=1373 #3 search for edna choose a specific item and to pick up at 'Fairview' http://localhost:8080/cgi-bin/koha/reserve/request.pl?biblionumber=1373 #4 search for Nicole and choose a specific item and to pick up at Centerville http://localhost:8080/cgi-bin/koha/reserve/request.pl?biblionumber=1373 #5 the list of holds on the item says that both people want to pick up at Centerville -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4016 Garry Collum <gcollum@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gcollum@gmail.com --- Comment #2 from Garry Collum <gcollum@gmail.com> 2010-02-13 16:22:21 --- Looks like this might be caused by $searchMyLibraryFirst in C4/branch.pm. Line 163 = selected => (($_ eq $branch) && $searchMyLibraryFirst) ? 1 : 0, If it is changed to selected => (($_ eq $branch)) ? 1 : 0, The holds problem is fixed. But I'm not sure what removing it would break. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4016 --- Comment #3 from Nicole C. Engard <nengard@gmail.com> 2010-02-13 17:04:49 --- K - I'm not sure I completely understand - but you should know that neither of the patrons had Centerville as their home branch ... so that wasn't their library and yet it was what the menu was showing - looks more like the menu is selecting the first branch in the list of branches. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4016 --- Comment #4 from Garry Collum <gcollum@gmail.com> 2010-02-13 17:30:45 --- It means that the holds issue is a fairly simple fix, but if we fix it, something else is going to break. There are a couple of solutions, probably more. 1. searchMyLibraryFirst could be moved out of the C4 level and place in at the pl level. 2. don't use the GetBranchesLoop in reserve.pl. 1 is probably the better solution. Because I have a feeling this may have broken other things branch listings besides the one in holds. Basically it was a difficult problem to identify, and I just wanted to share in case anyone else was also looking. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4016 --- Comment #5 from Garry Collum <gcollum@gmail.com> 2010-02-13 17:58:28 --- Oh I see what you are saying Nicole. Actually, none of the branches are getting selected. The first one appears to be getting selected because it is the first one. If you 'view source' on the page you can see that none of the options have "selected='selected'". -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4016 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2010-02-13 18:33:21 --- BINGO! That's what I'm saying :) -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4016 --- Comment #7 from Garry Collum <gcollum@gmail.com> 2010-02-13 18:42:10 --- searchMyLibraryFirst in the GetBranchesLoop in C4/branch.pm is what's causing it. GetBranchesLoop generates a list of branches, and you can pass a branchcode to indicate that passed branch is the one that is selected. It's not returning the selected branch. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4016 --- Comment #8 from Nicole C. Engard <nengard@gmail.com> 2010-02-19 17:02:38 --- Added problem - if I change the pick up locations and click 'Update hold(s)' my change is not saved - or if it is it's not displayed at changed. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4016 --- Comment #9 from Garry Collum <gcollum@gmail.com> 2010-02-21 02:40:48 --- Created an attachment (id=1654) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1654) Proposed patch. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4016 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nahuel.angelinetti@biblibre. | |com, gmcharlt@gmail.com Depends on| |3778 --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> 2010-02-21 23:02:56 --- The patch as submitted is effectively a revert of commit 2345dc7c27381aad51d5c1a7f566a9ce0b728ac5, which was submitted to fix bug 3778. Adding Nahuel to the CC list in the hopes that he'll comment. As things stand now, I agree that a check of SearchMyLibraryFirst does not belong in GetBranchesLoop and will push the revert. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4016 --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> 2010-02-21 23:05:35 --- Pushed revert as described, please test and close. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4016 --- Comment #12 from Galen Charlton <gmcharlt@gmail.com> 2010-02-21 23:08:09 --- I recommend that the 3.0.x version of the bad commit, 36ae08af3221f8a5073c1576ee53c4ba00a1d153, be reverted as well, as it means that this bug is likely present in 3.0.x as well as HEAD. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4016 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠kohaorg.ec2.liblime.com