[Bug 9810] New: Search limit 'available' does not hide damaged or withdrawn items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Bug ID: 9810 Summary: Search limit 'available' does not hide damaged or withdrawn items Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16094&action=edit Bug 9810 - Search limit 'available' does not hide damaged or withdrawn items Test Plan: 1) Perform a search that will return an a damaged item and a withdrawn item ( for simplicity, have those items be the only one on each record, respectively ) 2) Run the same search but limit to available items only 3) Note those items still appear in the search results 4) Apply this patch 5) Run the search again 6) Note the items no longer appear in the search results -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- It would also be nice to hide waiting items with the availability limit, but that is more difficult. I think it would require adding a 'waiting' field to the items table, mapping it to a marc field, making sure Koha updates the field properly, adding it to the zebra indexes, and then adding it to the availability limit code. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16094|0 |1 is obsolete| | --- Comment #3 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 16402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16402&action=edit Bug 9810 - Search limit 'available' does not hide damaged or withdrawn items Test Plan: 1) Perform a search that will return an a damaged item and a withdrawn item ( for simplicity, have those items be the only one on each record, respectively ) 2) Run the same search but limit to available items only 3) Note those items still appear in the search results 4) Apply this patch 5) Run the search again 6) Note the items no longer appear in the search results Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |matthias.meusburger@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: The patch works but not out of the box! With an UNIMARC installation, the damaged and withdrawn indexes are not defined. So the patch causes an empty results page. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- I will propose a patch for that -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16542&action=edit Bug 9810: Add indexes withdrawn and damaged for UNIMARC After applying this patch, the zebra's index should be rebuild! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Note for RM: The zebra's index should be rebuild on each UNIMARC installation after applying these patches. Switch back to Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Corinne BULAC <corinnebulac@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |corinnebulac@gmail.com --- Comment #8 from Corinne BULAC <corinnebulac@gmail.com> --- 1 - I apply this patch 2 - I create WITHDRAWN list with 0 and 1 values 3 - I change item cataloguing by introduction a 995$3 field link to this list 4 - I modify two item in filling 995$3 with witdrawn = 1 5 - Rebuild zebra index was done 6 - Items are still visible in OPAC and their status is "available" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #8)
1 - I apply this patch 2 - I create WITHDRAWN list with 0 and 1 values 3 - I change item cataloguing by introduction a 995$3 field link to this list 4 - I modify two item in filling 995$3 with witdrawn = 1 5 - Rebuild zebra index was done 6 - Items are still visible in OPAC and their status is "available"
Did you apply changes to the zebra config file (record.abs)? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16542|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Comment on attachment 16542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16542 Bug 9810: Add indexes withdrawn and damaged for UNIMARC These indexes have already been added by a different commit. This patch is no longer needed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28526&action=edit Bug 9810 [Followup] - Hide items with notforloan < 0 when limiting to available items Not for loan statuses of less then 0 are considered 'unavailable' in Koha parlance, whereas items with a not for loan status greater than 0 are considered available, but not checkout-able ( i.g. reference items ). This should be taken into account by the availability filter. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16402|0 |1 is obsolete| | Attachment #28526|0 |1 is obsolete| | --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 29579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29579&action=edit Bug 9810 - Search limit 'available' does not hide damaged or withdrawn items Test Plan: 1) Perform a search that will return an a damaged item and a withdrawn item ( for simplicity, have those items be the only one on each record, respectively ) 2) Run the same search but limit to available items only 3) Note those items still appear in the search results 4) Apply this patch 5) Run the search again 6) Note the items no longer appear in the search results Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 29580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29580&action=edit Bug 9810 [Followup] - Hide items with notforloan < 0 when limiting to available items Not for loan statuses of less then 0 are considered 'unavailable' in Koha parlance, whereas items with a not for loan status greater than 0 are considered available, but not checkout-able ( i.g. reference items ). This should be taken into account by the availability filter. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Both patches work fine for me. But I wonder if the second patch will work for UNIMARC. (I do not find notforloan in the record.abs of UNIMARC) Could a UNIMARC user confirm this please? No problems for qa tools. Changing status to Failed QA for need of clarification. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Small additional remark (apparently outside the scope of this report but observed while testing it): If I toggle the status of Available items and All items, the first time it works but the second time it does no longer work. As you can see below, the query contains kw: the second time, resulting in 0 hits. First URL for limiting to available: /cgi-bin/koha/catalogue/search.pl?q=london%20india%20%23relevance_dsc&sort_by=relevance_dsc&limit=available Second URL: /cgi-bin/koha/catalogue/search.pl?q=kw%3Alondon%20india%20%23relevance_dsc&sort_by=relevance_dsc&limit=available -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #14)
Both patches work fine for me. But I wonder if the second patch will work for UNIMARC. (I do not find notforloan in the record.abs of UNIMARC) Could a UNIMARC user confirm this please?
The notforloan index does not seem to exist, I confirm. I added a patch for withdrawn and damaged indexes (see comment 6). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Jonathan, with no notforloan index, does the feature fail gracefully for unimarc? That is, it may not resolve the issue, but it doesn't break anything. If so, I think we can push the patch and file a separate bug to add the notforloan index for unimarc users. (In reply to Jonathan Druart from comment #16)
(In reply to M. de Rooy from comment #14)
Both patches work fine for me. But I wonder if the second patch will work for UNIMARC. (I do not find notforloan in the record.abs of UNIMARC) Could a UNIMARC user confirm this please?
The notforloan index does not seem to exist, I confirm. I added a patch for withdrawn and damaged indexes (see comment 6).
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Kyle M Hall from comment #17)
Jonathan, with no notforloan index, does the feature fail gracefully for unimarc?
I don't get an "internal server error", but the result list is empty. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #18)
(In reply to Kyle M Hall from comment #17)
Jonathan, with no notforloan index, does the feature fail gracefully for unimarc?
I don't get an "internal server error", but the result list is empty.
Thanks, Jonathan. Sorry, Kyle, but that means that this cannot pass qa in the current form. We would introduce more misinformation (no hits) for unimarc users than only showing a damaged item or so too much. Could you adjust the follow-up and make this notforloan part non-unimarc specific? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29644&action=edit Bug 9810: Add index notforloan for unimarc This patch adds the notforloan index for UNIMARC (GRS-1 and DOM). Not that the original patch does not work out of the box: the notforloan, withdrawn and damaged indexes are not defined in the frameworks and mapping. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #19)
(In reply to Jonathan Druart from comment #18)
(In reply to Kyle M Hall from comment #17)
Jonathan, with no notforloan index, does the feature fail gracefully for unimarc?
I don't get an "internal server error", but the result list is empty.
Thanks, Jonathan. Sorry, Kyle, but that means that this cannot pass qa in the current form. We would introduce more misinformation (no hits) for unimarc users than only showing a damaged item or so too much. Could you adjust the follow-up and make this notforloan part non-unimarc specific?
I wouldn't want to see a test (if marc21 else) here. I would prefer to see this patch pushed to master. I will try to provide a patch for bug 11586 soon (that will fix the problem with the last patch). Switch back to need QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #22 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Former QA and Jonathan's last patch and a small followup for item:w-consistency between notforloan and damaged, withdrawn, etc. in unimarc setup, should altogether be sufficient to make this patch set pass QA now, while looking forward to subsequent work in bug 11586. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29579|0 |1 is obsolete| | Attachment #29580|0 |1 is obsolete| | Attachment #29644|0 |1 is obsolete| | --- Comment #23 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30573&action=edit Bug 9810 - Search limit 'available' does not hide damaged or withdrawn items Test Plan: 1) Perform a search that will return an a damaged item and a withdrawn item ( for simplicity, have those items be the only one on each record, respectively ) 2) Run the same search but limit to available items only 3) Note those items still appear in the search results 4) Apply this patch 5) Run the search again 6) Note the items no longer appear in the search results Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #24 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30574&action=edit Bug 9810 [Followup] - Hide items with notforloan < 0 when limiting to available items Not for loan statuses of less then 0 are considered 'unavailable' in Koha parlance, whereas items with a not for loan status greater than 0 are considered available, but not checkout-able ( i.g. reference items ). This should be taken into account by the availability filter. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #25 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30575&action=edit Bug 9810: Add index notforloan for unimarc This patch adds the notforloan index for UNIMARC (GRS-1 and DOM). Not that the original patch does not work out of the box: the notforloan, withdrawn and damaged indexes are not defined in the frameworks and mapping. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 --- Comment #26 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30576&action=edit Bug 9810: Follow-up for UNIMARC notforloan item:w consistency To make the index defs and record.abs more consistent, adding item:w to notforloan. Please see also damaged, withdrawn, etc. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |tomascohen@gmail.com --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm sorry, this one is not an urgent one and needs regression tests. After the release, I can work on them (we need to make the big tests function run on NORMARC and UNIMARC so this is testable on both). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org