[Bug 9928] New: only superlibrarians can see all suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Bug ID: 9928 Summary: only superlibrarians can see all suggestions Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com This is a huge issue for multi-library systems, and one that was missed obviously. When filtering suggestions to see them all if you select "Any" from the library drop down menu and click "Go" it reverts back to a single library (the library the staff member is from). It is not showing all of the locations as expected - making it impossible for libraries that handle suggestions centrally to do so unless they give their acq staff superlibrarian permissions - which is not feasible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9840 Summary|only superlibrarians can |no way to see all purchase |see all suggestions |suggestions at all --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- I lied - no one - not even superlibrarians can get to see all suggestions anymore. It bug 9840 and bug 7300 made it so that you couldn't see them without selecting 'any' from the pull down - but now you can't select any from the pull down regardless of your permission level. Big blocker! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16891&action=edit Bug 9928 - no way to see all purchase suggestions at all Test Plan: 1) Apply patch 3) Create suggestions for multiple libraries 2) Select 'Any' for the 'For' field under 'Acquisition information' 3) Note you are seeing the suggestions for all branches -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |kyle.m.hall@gmail.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16891|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 16892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16892&action=edit Bug 9928 - no way to see all purchase suggestions at all Test Plan: 1) Apply patch 3) Create suggestions for multiple libraries 2) Select 'Any' for the 'For' field under 'Acquisition information' 3) Note you are seeing the suggestions for all branches Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Works as described -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- I tested this in Koha 3.10.x and master. It's a bug in both versions and this patch fixes it. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- *** Bug 9840 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16892|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 16998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16998&action=edit Bug 9928 - no way to see all purchase suggestions at all Test Plan: 1) Apply patch 3) Create suggestions for multiple libraries 2) Select 'Any' for the 'For' field under 'Acquisition information' 3) Note you are seeing the suggestions for all branches Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Works as described Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16998|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17042&action=edit [PASSED QA] Bug 9928 - no way to see all purchase suggestions at all Test Plan: 1) Apply patch 3) Create suggestions for multiple libraries 2) Select 'Any' for the 'For' field under 'Acquisition information' 3) Note you are seeing the suggestions for all branches Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Works as described Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> http://bugs.koha-community.org/show_bug.cgi?id=9927 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch fixes wrong behaviour. All tests and QA script pass. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Does not apply to 3.10.x please rebase and resubmit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17091&action=edit Bug 9928 - no way to see all purchase suggestions at all [3.10.x] Test Plan: 1) Apply patch 3) Create suggestions for multiple libraries 2) Select 'Any' for the 'For' field under 'Acquisition information' 3) Note you are seeing the suggestions for all branches Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Works as described Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> http://bugs.koha-community.org/show_bug.cgi?id=9927 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch fixes wrong behaviour. All tests and QA script pass. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17042|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Not sure, but should this be "pushed to master" to gain Chris' attention? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #11)
Not sure, but should this be "pushed to master" to gain Chris' attention?
I would put 3.10.X in the report name and leave it Passed QA. Pushed to master would not be the right status.. Chris will see it probably soon enough. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Actually Katrin was right (she usually is), pushed to master is the queue I watch, but Jared alerted me on IRC. When its something like this, that has been pushed to master, and we have a rebased patch for a maintenance branch it's better to leave it pushed to master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10588 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org