[Bug 27998] New: Replace obsolete title-string sorting: Serials templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27998 Bug ID: 27998 Summary: Replace obsolete title-string sorting: Serials templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 27934 This patch will modify the following templates to replace the old "title-string" DataTables sorting method with the built-in method using "data-order" attributes. intranet-tmpl/prog/en/includes/mana/mana-subscription-search-result.inc intranet-tmpl/prog/en/modules/serials/claims.tt intranet-tmpl/prog/en/modules/serials/serials-collection.tt intranet-tmpl/prog/en/modules/serials/serials-search.tt intranet-tmpl/prog/en/modules/serials/subscription-detail.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27934 [Bug 27934] Table sorting using title-string option is obsolete -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27998 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27998 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118551&action=edit Bug 27998: Replace obsolete title-string sorting: Serials templates This patch modifies several serials templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - With the Mana service configured in system preferences, go to Serials -> New subscription and add a subscription for a bibliographic record which will match titles in Mana. In the Mana search results, the "Last import" column should sort correctly. - Serials -> Claims - Serials -> Search - Serials -> Subscription details - The affected table is "Acquisition details," so your subscription must have orders associated with it (I eyeballed this change, so could use extra help testing this area). - Serials -> Subscription details -> Serial collection -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27998 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118551|0 |1 is obsolete| | CC| |amitddng135@gmail.com --- Comment #2 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 118670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118670&action=edit Bug 27998: Replace obsolete title-string sorting: Serials templates To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - With the Mana service configured in system preferences, go to Serials -> New subscription and add a subscription for a bibliographic record which will match titles in Mana. In the Mana search results, the "Last import" column should sort correctly. - Serials -> Claims - Serials -> Search - Serials -> Subscription details - The affected table is "Acquisition details," so your subscription must have orders associated with it (I eyeballed this change, so could use extra help testing this area). - Serials -> Subscription details -> Serial collection -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27998 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27998 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 118790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118790&action=edit Bug 27998: (follow-up) Address missing instanced Remove title-string option from dataTable configurations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27998 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27998 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118670|0 |1 is obsolete| | Attachment #118790|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 118900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118900&action=edit Bug 27998: Replace obsolete title-string sorting: Serials templates This patch modifies several serials templates to replace the use of the "title-string" DataTables sorting method with the newer "data-order" attribute. To test, apply the patch and view the following pages to confirm that columns containing dates sort correctly when using any setting of the "dateformat" system preference: - With the Mana service configured in system preferences, go to Serials -> New subscription and add a subscription for a bibliographic record which will match titles in Mana. In the Mana search results, the "Last import" column should sort correctly. - Serials -> Claims - Serials -> Search - Serials -> Subscription details - The affected table is "Acquisition details," so your subscription must have orders associated with it (I eyeballed this change, so could use extra help testing this area). - Serials -> Subscription details -> Serial collection Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27998 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 118901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118901&action=edit Bug 27998: (follow-up) Address missing instances Remove title-string option from dataTable configurations. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27998 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27998 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27998 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org