[Bug 31962] New: Standardize tooltips on datatable controls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 Bug ID: 31962 Summary: Standardize tooltips on datatable controls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 31861 When you hover over Export and print, there is a tooltip in the form of a speech bubble showing on top. But if you hover over configure, a normal tooltip shows below. To test: * Go to a patron account * Check out any book * Hover over table controls Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 [Bug 31861] Table controls on checkouts table are buttons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 Bug 31962 depends on bug 31861, which changed state. Bug 31861 Summary: Table controls on checkouts table are buttons https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31861 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Standardize tooltips on |Add tooltip to 'configure' |datatable controls |on datatable controls -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145106&action=edit Bug 31962: Add tooltip to 'configure' on datatable controls This makes sure that the last button on the datatable controls also has a tooltip, like the other buttons. To test: * Without the patch: * Check out an item and look at the table of checkouts * Look at the detail page of a record with at least one item * Confirm that the 'configure' button doesn't have a tooltip appear as a bubble like the other buttons * Apply patch * Restart_all and reload pages * Make sure the styling of the 'configure' tooltip now matches that of the other buttons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145106|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 145133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145133&action=edit Bug 31962: Add tooltip to 'configure' on datatable controls This makes sure that the last button on the datatable controls also has a tooltip, like the other buttons. To test: * Without the patch: * Check out an item and look at the table of checkouts * Look at the detail page of a record with at least one item * Confirm that the 'configure' button doesn't have a tooltip appear as a bubble like the other buttons * Apply patch * Restart_all and reload pages * Make sure the styling of the 'configure' tooltip now matches that of the other buttons Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145133|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145851&action=edit Bug 31962: Add tooltip to 'configure' on datatable controls This makes sure that the last button on the datatable controls also has a tooltip, like the other buttons. To test: * Without the patch: * Check out an item and look at the table of checkouts * Look at the detail page of a record with at least one item * Confirm that the 'configure' button doesn't have a tooltip appear as a bubble like the other buttons * Apply patch * Restart_all and reload pages * Make sure the styling of the 'configure' tooltip now matches that of the other buttons Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice consistency improvement, no regressions found. Passing QA, Thanks Katrin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31962 --- Comment #6 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org