[Bug 18734] New: Internal server error in cash_register_stats.pl when exporting to file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18734 Bug ID: 18734 Summary: Internal server error in cash_register_stats.pl when exporting to file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org To reproduce: - Go to Home > Reports > Cash register statistics - Select a date range - Output to screen in browser: Displays OK - Output to a file: Internal Server Error Plack error log says: CGI::param called in list context from package CGI::Compile::ROOT::home_marc_koha_reports_cash_register_stats_2epl line 64, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package CGI::Compile::ROOT::home_marc_koha_reports_cash_register_stats_2epl line 66, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. exited nonzero: 1 at /home/marc/koha/reports/cash_register_stats.pl line 201. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18734 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18694 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18694 [Bug 18694] Translatability: Get rid of exposing [%% FOREACH in csv/cash_register_stats.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18734 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6934 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 [Bug 6934] New report Cash Register Statistics -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18734 --- Comment #1 from Marc Véron <veron@veron.ch> --- The internal server error can be fixed by changing line 174 from exit(1); to exit(0); But then an new issue appears: The export has an empty line above the header line, and the header line is mixed with and without double quotes: mfirstname;card number;firstname;branchname;date;accounttype;amount;title;barcode;"itype" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18734 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18734 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 64137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64137&action=edit Bug 18734 - Internal server error in cash_register_stats.pl when exporting to file To test: Output cash reigster stats report to file Internal server error Apply patch Export to file File is generated and correctly formed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18734 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |nick@bywatersolutions.com CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18734 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64137|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 64142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64142&action=edit Bug 18734 - Internal server error in cash_register_stats.pl when exporting to file To test: Output cash reigster stats report to file Internal server error Apply patch Export to file File is generated and correctly formed Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18734 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18734 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64142|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 64146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64146&action=edit Bug 18734 - Internal server error in cash_register_stats.pl when exporting to file To test: Output cash reigster stats report to file Internal server error Apply patch Export to file File is generated and correctly formed Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18734 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64146|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64230&action=edit Bug 18734 - Internal server error in cash_register_stats.pl when exporting to file To test: Output cash reigster stats report to file Internal server error Apply patch Export to file File is generated and correctly formed Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18734 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18734 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18734 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18734 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18734 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Patchset has conflicts, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18734 --- Comment #10 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #9)
Patchset has conflicts, skipping for 16.05.x
depends on BZ 6934 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org