https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 59633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59633&action=edit Bug 17955 - Implemented working DBIX in place of sql queries throughout the whole of the onboarding.pl script. Modified the onshelfholds if statement logic in the onboarding.pl script. Removed unneccisary use pragmas from onboarding.pl script -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 59634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59634&action=edit Bug 17955 - Implemented working DBIX in place of sql queries throughout the whole of the onboarding.pl script. Modified the onshelfholds if statement logic in the onboarding.pl script. Removed unneccisary use pragmas from onboarding.pl script -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 59636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59636&action=edit bug 17855 - Updated web installer finished The onboarding tool has been implemented and integrated with the updated web installer. The onboarding tool has the following functionality: * After the user has finished the web installer they are automatically redirected to the onboarding tool with no authentication in between required * Ability to create library, patron category, patron (set with superlibrarian priviliages), item type and circulation rule. * If the uaser installed sample libraries, patron categories and/or item types then the step to create one in the onboarding tool will be skipped and a skipping message will be displayed. *HTML regxes on all text input fields in all forms in the onboarding tool this prevents the user from writing in special characters *Working date picker on the patron category form Have moved all data values from mandatory to default. Now all default data values are displayed with a bulletpoint rather than a selectable checkbox stopping users from unticking neccisary data values Test plan: 1. Go through the web installer and onboarding tool with the same steps as outlined in this below guide and check that the functionality outlined in the guide exists in the patch: https://koha-community.org/manual/installation/html/ This is a combination of 67 commits. Initial 3 HTML screens of the onboarding tool and the perl onboarding.pl script Note: The advanced setup option has not yet been implemented, so what you will see is just the basic setup. Altered web installer Moved files from optional to mandatory. Edited MARC screen so that MARC21 is selected by default. Changed mandatory to default for MARC values Changed a few file name descriptions to reduce spacing in installer step 3 screen. Changed the radiobuttons to bulletpoints for default settings removed = sign Fixed bug in installer where a loop was created if you're database structure needed to be updated. Redirected this to the marcflavour screen instead of logging straight into Koha and skipping over the basic configuration steps. Changed the bulletpoints to disabled checkboxes which are checked by default Backup of step3.tt Successfully working insertion of the default options which are shown as bulletpoints Removed test text Working insertion of default and optional options Correctly selected default marc flavour of marc21 NOTE: Mark Tompsett merged several commits - Removed html regex on patron password fields. Ran perltidy to indent and space code appropriately. Ran git bz configuration commands to remove whitespace. Removed unnecissary uses in the summary.pl script - Made arrows in onboarding tool pages -> for consistency. Additionally removed the 'OR' - Added the use CGI qw ( -utf8 ); - Removed the second path to creating a library, patron category, patron, item type, and circulation rule. In onboarding .tt files and summary.tt - Fixed typo in summary.tt - Made consistent single space before and after -> in all onboarding .tt and summary.tt files. - Made single <br> tag before path to create library, patron category, item type, and circulation rule in the onboarding .tt files (patron does not need this as its layout is slightly different) - Changed button and link names in web installer and onboarding tool - Implemented Javascript password check to determine if the values in the 'password' and 'confirm password' fields are consistent. If passwords are not consistent a message informing the user is displayed and they only have to change the password values rather than re-fill out the whole form. - Fixed the errors from the koha qa test - Removed use:C4/Auth from the onboarding.pl - Moved the "select all options" button down to just above the selectable options in the basic setup, and positioned at the top of the page for the advanced setup. - Removed the "there is nothing to do because the sample data is already installed" page so if the user has install sample data in the web installer then the step to create that object in the onboarding tool is skipped altogether. - Removed the "We're just going to setup a few more things" page - Changed the title of the 'Create patron page' - Added clarifying information to the "Add a patron category" page - Added clarifying information to the "Create item type" page - Fixed the capitalization in the onboarding tool - Removed the BackupStep3.tt file which was un-used - Changed the redirect time displayed to user in step3.tt to 10 - Changed the cardnumber on the create patron administrator page so that it is only populated when the user installed sample patrons. Also changed the regex so that it allows letters and number. - Used the HTMl validator to identify errors in the template and have corrected all possible in the onboarding templates. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 59639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59639&action=edit Bug 17955 - Removed unnecessary use pragmas in the onboarding.pl script Replaced all sql code in onboarding.pl script with DBIx Changed the logic of the onshelfholds if statement in onboarding.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Test Plan: 1. Apply bug 17855 and observe the installer/onboarding.pl script has multiple sql queries in it 2. Apply bug 17955 (this bug) and observe that there are no more sql queries in the same onboarding.pl script. The queries have been replaced with DBIx database interaction queries. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Moved back to assigned, so Alex can reuse this or close it as deemed fit. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 Bug 17955 depends on bug 17855, which changed state. Bug 17855 Summary: New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.