https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131534|0 |1 is obsolete| | --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 139815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139815&action=edit Bug 30262: Trim whitespace off tracklinks.pl URLs This patch trims whitespace off tracklinks.pl URLs so that the URL is in the same format as the URLs returned by C4::Biblio::GetMarcUrls, which is used by tracklinks.pl internally. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 2. Add a 856 with $u of 'https://koha-community.org ' (note the space at the end0 3. Save record 4. Change 'TrackClicks' syspref to 'Track' 5. Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 6. Click on the online resource (eg http://localhost:8080/cgi-bin/koha/tracklinks.pl?uri=https%3A%2F%2Fkoha-community.org%20&biblionumber=29 ) 7. Note you are redirected to https://koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139815|0 |1 is obsolete| | --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Created attachment 139817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139817&action=edit Bug 30262: Trim whitespace off tracklinks.pl URLs This patch trims whitespace off tracklinks.pl URLs so that the URL is in the same format as the URLs returned by C4::Biblio::GetMarcUrls, which is used by tracklinks.pl internally. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 2. Add a 856 with $u of 'https://koha-community.org ' (note the space at the end0 3. Save record 4. Change 'TrackClicks' syspref to 'Track' 5. Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 6. Click on the online resource (eg http://localhost:8080/cgi-bin/koha/tracklinks.pl?uri=https%3A%2F%2Fkoha-community.org%20&biblionumber=29 ) 7. Note you are redirected to https://koha-community.org Signed-off-by: Magnus Enger <magnus@libriotech.no> Added the link with a space at the end. Verified that without the patch, clickin on "Click here to access online" gives a 404. After applying the patch the redirect works as expected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139817|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 139909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139909&action=edit Bug 30262: Trim whitespace off tracklinks.pl URLs This patch trims whitespace off tracklinks.pl URLs so that the URL is in the same format as the URLs returned by C4::Biblio::GetMarcUrls, which is used by tracklinks.pl internally. Test plan: 0. Apply patch and koha-plack --restart kohadev 1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=29 2. Add a 856 with $u of 'https://koha-community.org ' (note the space at the end0 3. Save record 4. Change 'TrackClicks' syspref to 'Track' 5. Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 6. Click on the online resource (eg http://localhost:8080/cgi-bin/koha/tracklinks.pl?uri=https%3A%2F%2Fkoha-community.org%20&biblionumber=29 ) 7. Note you are redirected to https://koha-community.org Signed-off-by: Magnus Enger <magnus@libriotech.no> Added the link with a space at the end. Verified that without the patch, clickin on "Click here to access online" gives a 404. After applying the patch the redirect works as expected. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.07 |22.11.00, 22.05.07, released in| |21.11.14 CC| |arthur.suzuki@biblibre.com --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.14 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30262 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.