https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37292 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

SHOW CREATE TABLE oauth_access_tokens; => FAIL: There's no 'KEY' entry for the `expires` column

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37292 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 175029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175029&action=edit Bug 37292: Add an index on oauth_access_tokens.expires This patch adds a needed index to the column. To test: 1. On a fresh KTD, run: $ ktd --shell k$ koha-mysql kohadev 2. Apply this patch 3. Run: k$ updatedatabase => SUCCESS: A message tells the index was added 4. Repeat 1 => SUCCESS: The index was actually added to the DB 5. Run: k$ reset_all 6. Repeat 1 => SUCCESS: The index is created at install time too! 7. Run: k$ updatedatabase => SUCCESS: Nothing explodes, no message about index being created 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

SHOW CREATE TABLE oauth_access_tokens; => FAIL: There's no 'KEY' entry for the `expires` column

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37292 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175029|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 175036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175036&action=edit Bug 37292: Add an index on oauth_access_tokens.expires This patch adds a needed index to the column. To test: 1. On a fresh KTD, run: $ ktd --shell k$ koha-mysql kohadev 2. Apply this patch 3. Run: k$ updatedatabase => SUCCESS: A message tells the index was added 4. Repeat 1 => SUCCESS: The index was actually added to the DB 5. Run: k$ reset_all 6. Repeat 1 => SUCCESS: The index is created at install time too! 7. Run: k$ updatedatabase => SUCCESS: Nothing explodes, no message about index being created 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

SHOW CREATE TABLE oauth_access_tokens; => FAIL: There's no 'KEY' entry for the `expires` column

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37292 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175036|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175047&action=edit Bug 37292: Add an index on oauth_access_tokens.expires This patch adds a needed index to the column. To test: 1. On a fresh KTD, run: $ ktd --shell k$ koha-mysql kohadev 2. Apply this patch 3. Run: k$ updatedatabase => SUCCESS: A message tells the index was added 4. Repeat 1 => SUCCESS: The index was actually added to the DB 5. Run: k$ reset_all 6. Repeat 1 => SUCCESS: The index is created at install time too! 7. Run: k$ updatedatabase => SUCCESS: Nothing explodes, no message about index being created 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37292 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is this a bug or an enh? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37292 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37292 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.01 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37292 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Makes sens but I prefer not backport to 23.11.x for database stability -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37292 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #9 from David Nind <david@davidnind.com> --- Not covered in the manual, no updates required. -- You are receiving this mail because: You are watching all bug changes.