[Bug 28682] New: Record detail page fails if error with search for analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 Bug ID: 28682 Summary: Record detail page fails if error with search for analytics Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org In record detail page, there is a search for analytics, see Bug 15851. If for any reason this search fails, the page will be broken with 'Internal server error'. I propose to protect with eval. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28513 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28513 [Bug 28513] Analytic search links formed incorrectly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 122661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122661&action=edit Bug 28682: Protect search for analytics in record detail page In record detail page, there is a search for analytics, see Bug 15851. If for any reason this search fails, the page will be broken with 'Internal server error'. This patch adds a protection with eval. Test plan : 1) Use a Zebra install with no Elasticsearch configuration 2) Go to staff interface 3) Go to any record detail page : no error 4) Change preference 'SearchEngine' to 'Elasticsearch' 5) Refresh ecord detail page : check you have no error 6) Check a record with analytics link 7) Repeat 3 to 6 on OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- The one case reported to me (Koha 20.11 with ES) is a title : Viva la revolution ! I don't know why analytics search fails but it should not block the page. And in UNIMARC seems analytics search is not used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- 28513 (edit) (In reply to Fridolin Somers from comment #2)
The one case reported to me (Koha 20.11 with ES) is a title : Viva la revolution !
I don't know why analytics search fails but it should not block the page. And in UNIMARC seems analytics search is not used.
And fails even with apply of Bug 28513 :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 Bug 28682 depends on bug 28513, which changed state. Bug 28513 Summary: Analytic search links formed incorrectly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28513 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 Didier Gautheron <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |didier.gautheron@biblibre.c | |om Status|Needs Signoff |Failed QA --- Comment #4 from Didier Gautheron <didier.gautheron@biblibre.com> --- Missing a ; in opac/opac-detail.pl compilation error: Could not compile /home/koha/src/opac/opac-detail.pl: syntax error at /home/koha/src/opac/opac-detail.pl line 199, near "my " -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Oupsy :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122661|0 |1 is obsolete| | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 123800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123800&action=edit Bug 28682: Protect search for analytics in record detail page In record detail page, there is a search for analytics, see Bug 15851. If for any reason this search fails, the page will be broken with 'Internal server error'. This patch adds a protection with eval. Test plan : 1) Use a Zebra install with no Elasticsearch configuration 2) Go to staff interface 3) Go to any record detail page : no error 4) Change preference 'SearchEngine' to 'Elasticsearch' 5) Refresh ecord detail page : check you have no error 6) Check a record with analytics link 7) Repeat 3 to 6 on OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- I rise to major because it can block one of the most important page, and impact OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm not so sure about this.. bug 28316 and bug 28484 resolve at a lower level by cleaning the search query so you yield the right results rather than hiding any results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28316 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28484 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Martin Renvoize from comment #8)
I'm not so sure about this.. bug 28316 and bug 28484 resolve at a lower level by cleaning the search query so you yield the right results rather than hiding any results.
OK maybe we just keep this fix for versions < 21.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29284 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 29284 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28682 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice adds a similar patch, but I prefer his scope and output so I'll QA that one in preference.. Marking as duplicate. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org