https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|make sure the extra |Make it possible to add |subfields are in a search |custom item subfields to |index |item search fields --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Do you mean capital letter subfields? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77640|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 79554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79554&action=edit Bug 20689: Replace marc (sub)field pull downs with input fields on item search fields config The pull down for marc subfields on the item search fields config page is long and hard to use. It also doesn't include the commonly used upper case letters for custom item subfields. Also hard to use with its 999 entries is the marc field list. It doesn't allow for tags like 01e, which exist in our MARC21 default framework. To test: - Go to Administration > Item search fields - Add different mappings with and without subfields - Verify the entered values are stored correctly - Edit mappings - Verify editing works and changes save correctly -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79554|0 |1 is obsolete| | --- Comment #5 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 79779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79779&action=edit Bug 20689: Replace marc (sub)field pull downs with input fields on item search fields config The pull down for marc subfields on the item search fields config page is long and hard to use. It also doesn't include the commonly used upper case letters for custom item subfields. Also hard to use with its 999 entries is the marc field list. It doesn't allow for tags like 01e, which exist in our MARC21 default framework. To test: - Go to Administration > Item search fields - Add different mappings with and without subfields - Verify the entered values are stored correctly - Edit mappings - Verify editing works and changes save correctly Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Séverine Queune from comment #6)

Great enhancement Katrin ! Thanks a lot !

Thx for testing! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We don't do this in the MARC frameworks and I think some odd characters would be allowed in the standard... I've thought about it and tried to implement an HTML filter, but didn't succeed. But we are not that strict in other places and I think a list with 999+ elements is not the solution :) As I said, we even fields with letters in our database. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Checking for digits and word characters as per Jonathans suggestion sounds sane to me... is there really a case out there where a field may contain another character outside that range? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80538&action=edit Bug 20689: (follow-up) Make it possible to add capital letter subfields to item search fields This patch adds some custom validation to the MARC tag and subfield fields so that they are limited to alphanumeric characters. To test, apply the patch and test the form by entering a variety of different character combinations. The "MARC field" and "MARC subfield" inputs should only accept alphanumeric entries. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80538|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80539&action=edit Bug 20689: (follow-up) Make it possible to add capital letter subfields to item search fields This patch adds some custom validation to the MARC tag and subfield fields so that they are limited to alphanumeric characters. To test, apply the patch and test the form by entering a variety of different character combinations. The "MARC field" and "MARC subfield" inputs should only accept alphanumeric entries. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We could also start supporting other ASCII characters like ;/% for subfield codes, that would give us more subfields for items to use - but it won't work right now and the upper case letter use is a reality not only for us but other libraries too (see Severine's comment). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80539|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 80713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80713&action=edit Bug 20689: (follow-up) Make it possible to add capital letter subfields to item search fields This patch adds some custom validation to the MARC tag and subfield fields so that they are limited to alphanumeric characters. To test, apply the patch and test the form by entering a variety of different character combinations. The "MARC field" and "MARC subfield" inputs should only accept alphanumeric entries. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- It all works as expected for me and I can't find any regressions. Passing QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sorry but... the validation does not work when a new field is added, only when it is edited. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80713|0 |1 is obsolete| | --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 81137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81137&action=edit Bug 20689: (follow-up) Make it possible to add capital letter subfields to item search fields This patch adds some custom validation to the MARC tag and subfield fields so that they are limited to alphanumeric characters. Both templates (the main view and the edit view) have been modified so that item_search_fields.js can be included in both. To test, apply the patch and test the form by entering a variety of different character combinations. The "MARC field" and "MARC subfield" inputs should only accept alphanumeric entries. Test both "new" and "edit" operations. Test other operations like delete and cancel. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80712|0 |1 is obsolete| | Attachment #81137|0 |1 is obsolete| | --- Comment #22 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 81150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81150&action=edit Bug 20689: Replace marc (sub)field pull downs with input fields on item search fields config The pull down for marc subfields on the item search fields config page is long and hard to use. It also doesn't include the commonly used upper case letters for custom item subfields. Also hard to use with its 999 entries is the marc field list. It doesn't allow for tags like 01e, which exist in our MARC21 default framework. To test: - Go to Administration > Item search fields - Add different mappings with and without subfields - Verify the entered values are stored correctly - Edit mappings - Verify editing works and changes save correctly Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Maybe I'm being stupid.. but this doesn't seem to be working for me. First off the validation doesn't seem to be activating on edit or new for me ( managed to enter 1~$ for example) Second, when I go to edit, I'm faced with an empty form rather than one that contains the existing data for me to edit. What am I doing wrong ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81150|0 |1 is obsolete| | Attachment #81151|0 |1 is obsolete| | --- Comment #25 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 83795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83795&action=edit Bug 20689: Replace marc (sub)field pull downs with input fields on item search fields config The pull down for marc subfields on the item search fields config page is long and hard to use. It also doesn't include the commonly used upper case letters for custom item subfields. Also hard to use with its 999 entries is the marc field list. It doesn't allow for tags like 01e, which exist in our MARC21 default framework. To test: - Go to Administration > Item search fields - Add different mappings with and without subfields - Verify the entered values are stored correctly - Edit mappings - Verify editing works and changes save correctly Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83796|0 |1 is obsolete| | --- Comment #27 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos@inlibro.com> --- Created attachment 83827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83827&action=edit Bug 20689: (follow-up) Make it possible to add capital letter subfields to item search fields This patch adds some custom validation to the MARC tag and subfield fields so that they are limited to alphanumeric characters. Both templates (the main view and the edit view) have been modified so that item_search_fields.js can be included in both. To test, apply the patch and test the form by entering a variety of different character combinations. The "MARC field" and "MARC subfield" inputs should only accept alphanumeric entries. Test both "new" and "edit" operations. Test other operations like delete and cancel. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jose-Mario <jose-mario.monteiro-santos@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Owen, I see pattern="[a-zA-Z0-9]+ and jQuery.validator.addMethod("marcfield", function(value, element) { return this.optional(element) || /^[0-9a-zA-Z]+$/.test(value); }, _("Please enter letters or numbers") ); Should not we have only 1 check? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- My concern it that they must be identical, but nothing indicate it (reading the code). In that case why the JS check when the patterns is enough? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #32 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #30)

My concern it that they must be identical, but nothing indicate it (reading the code).

Similar to how the maxlength attribute on input fields should match the size of database columns and those get out of sync. I can submit a followup which adds comments if you'd like. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83827|0 |1 is obsolete| | --- Comment #34 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 87956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87956&action=edit Bug 20689: (follow-up) Make it possible to add capital letter subfields to item search fields This patch adds some custom validation to the MARC tag and subfield fields so that they are limited to alphanumeric characters. Both templates (the main view and the edit view) have been modified so that item_search_fields.js can be included in both. To test, apply the patch and test the form by entering a variety of different character combinations. The "MARC field" and "MARC subfield" inputs should only accept alphanumeric entries. Test both "new" and "edit" operations. Test other operations like delete and cancel. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jose-Mario <jose-mario.monteiro-santos@inLibro.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #35 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 87957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87957&action=edit Bug 20689 Follow - tiny typo fix -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #39 from Nick Clemens <nick@bywatersolutions.com> --- The problem seems to be in ExtractValue: SELECT ExtractValue(metadata, '//record/datafield[@tag="520"]/subfield[@code="A"]') FROM biblio_metadata WHERE ExtractValue(metadata, '//record/datafield[@tag="520"]/subfield[@code="A"]') !=""; This returns both 'A' and 'a' subfields We need to figure a method to make the query case sensitive -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master --- Comment #41 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Nick Clemens from comment #39)

The problem seems to be in ExtractValue: ... This returns both 'A' and 'a' subfields

Should this be considered another bug, which this bug should be made dependent on? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 13561 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin Somers from comment #40)

(In reply to Nick Clemens from comment #39)

...

We need to figure a method to make the query case sensitive

Looks like we can set COLLATE like : select city_name from cities where city_name='Paris' COLLATE utf8mb4_bin;

I believe that is not quite the solution yet, as it would affect the strings we compare to instead of only the subfield codes, as we intend. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28892 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28892 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28892 [Bug 28892] Item search treats lower and upper case subfields as the same -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87955|0 |1 is obsolete| | Attachment #87956|0 |1 is obsolete| | Attachment #87957|0 |1 is obsolete| | Attachment #88294|0 |1 is obsolete| | --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124056&action=edit Bug 20689: Replace marc (sub)field pull downs with input fields on item search fields config The pull down for marc subfields on the item search fields config page is long and hard to use. It also doesn't include the commonly used upper case letters for custom item subfields. Also hard to use with its 999 entries is the marc field list. It doesn't allow for tags like 01e, which exist in our MARC21 default framework. To test: - Go to Administration > Item search fields - Add different mappings with and without subfields - Verify the entered values are stored correctly - Edit mappings - Verify editing works and changes save correctly Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124058&action=edit Bug 20689: (follow-up) Tiny typo fix Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've fixed a little conflict, signed the patches off, filed bug 28892 for the search issue and... would like to throw them back into the queue. I feel like we should still push these patches, even with the search issue: * To me this patch set provides a great usability improvement to the item search fields form as it gets rid of the mighty long pull downs that were hard to handle. * The search issue already exists right now: if you are using capital subfields you will find their contents already mixed with the configurable lower case subfields. It doesn't work correctly now - that's why I made bug 28892 a "see also" instead of a "blocks" or "depends on". * At the moment you could get around the form limitation by configuring the lower case letter for your upper case subfields. But as the MARC field and subfield are part of the displayed search option description, I think it will be nicer to allow the correct thing to be entered in the first place here. * The search issue is probably only going to 'hit', when upper case subfields are used in bibliographic records. The more common use case for this kind of subfield are item fields, as all the lower case letters and numbers are already used up in MARC21. This also means, that there is a really high chance that only the capital letter subfield will be queried via more_subfields_xml, as the lower case one is very likely to be mapped to a database field. So in this case, the results will be accurate. * The new form allows entering capital letter subfields, but it doesn't advertise it. If people think it's better we could change the bug title to highlight this as a usability improvement ... or we could add a hint explaining the limitation to the configuration page. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #52 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #15)

We could also start supporting other ASCII characters like ;/% for subfield codes..

Does not sound like a good plan to me. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #54 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #53)

I have the feeling here that we took the wrong road and now we are on it, lets just continue following it.

Why? Can you detail? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #56 from Jonathan Druart <jonathan.druart+koha@gmail.com> ---

Refactor instead of staying in between?

The first step took 10 months to be pushed... It's not very motivating to continue. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124056|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131038&action=edit Bug 20689: Replace marc (sub)field pull downs with input fields on item search fields config The pull down for marc subfields on the item search fields config page is long and hard to use. It also doesn't include the commonly used upper case letters for custom item subfields. Also hard to use with its 999 entries is the marc field list. It doesn't allow for tags like 01e, which exist in our MARC21 default framework. To test: - Go to Administration > Item search fields - Add different mappings with and without subfields - Verify the entered values are stored correctly - Edit mappings - Verify editing works and changes save correctly Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124058|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 131040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131040&action=edit Bug 20689: (follow-up) Tiny typo fix Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think the compromises here are reasonable and the timescale it's taken for this to work through makes me feel it's time to let it get in and if someone wishes to work on it further they can do in another bug. Passing QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.