[Bug 26719] New: Replace MSG_NO_RECORD_SELECTED with translatable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26719 Bug ID: 26719 Summary: Replace MSG_NO_RECORD_SELECTED with translatable string Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: aleisha@catalyst.net.nz, lucas@bywatersolutions.com, testopia@bugs.koha-community.org, tomascohen@gmail.com, victor@tuxayo.net Depends on: 25351 The patch for Bug 25351 removed definition of the MSG_NO_RECORD_SELECTED variable but didn't correct all the instances where the variable is used. These instances need to be fixed with a string wrapped in the new i18n function. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25351 [Bug 25351] Move cart-related strings out of opac-bottom.inc and into basket.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26719 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26719 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 111932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111932&action=edit Bug 26719: Replace MSG_NO_RECORD_SELECTED with translatable string This patch cleans up some loose ends left by Bug 25351, replacing instances where the undefined variable MSG_NO_RECORD_SELECTED is used. To test, apply the patch and perform a catalog search in the OPAC. - On the search results page, without checking any checkboxes, use the "Select titles to..." menu to try to add to cart and add to a list. In each case you should get a "No item was selected" message. - View a list which contains one or more titles. Click the "Remove from list" link. You should get a "No item was selected" link. Other instances have been corrected even though they will only be triggered if something has broken. For instance, toolbar items in the cart window which are disabled shouldn't register the click that might trigger the error. And selecting an item for an item-level hold shouldn't ever give a warning because at least one radio button should always be selected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26719 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26719 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111932|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 111933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111933&action=edit Bug 26719: Replace MSG_NO_RECORD_SELECTED with translatable string This patch cleans up some loose ends left by Bug 25351, replacing instances where the undefined variable MSG_NO_RECORD_SELECTED is used. To test, apply the patch and perform a catalog search in the OPAC. - On the search results page, without checking any checkboxes, use the "Select titles to..." menu to try to add to cart and add to a list. In each case you should get a "No item was selected" message. - View a list which contains one or more titles. Click the "Remove from list" link. You should get a "No item was selected" link. Other instances have been corrected even though they will only be triggered if something has broken. For instance, toolbar items in the cart window which are disabled shouldn't register the click that might trigger the error. And selecting an item for an item-level hold shouldn't ever give a warning because at least one radio button should always be selected. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26719 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I've added bug 26720 as the your lists buttons don't seem to be displaying correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26719 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, is there a chance we could add context here or use another word than "item"? A list item and a record's item require different translation in German. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111933|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112033&action=edit Bug 26719: Replace MSG_NO_RECORD_SELECTED with translatable string This patch cleans up some loose ends left by Bug 25351, replacing instances where the undefined variable MSG_NO_RECORD_SELECTED is used. To test, apply the patch and perform a catalog search in the OPAC. - On the search results page, without checking any checkboxes, use the "Select titles to..." menu to try to add to cart and add to a list. In each case you should get a "No item was selected" message. - View a list which contains one or more titles. Click the "Remove from list" link. You should get a "No item was selected" link. Other instances have been corrected even though they will only be triggered if something has broken. For instance, toolbar items in the cart window which are disabled shouldn't register the click that might trigger the error. And selecting an item for an item-level hold shouldn't ever give a warning because at least one radio button should always be selected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26719 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26719 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26719 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- does not apply clean to 20.05.x, no backport if needed please rebase -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org