[Bug 12407] New: phone label or data switched
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 Bug ID: 12407 Summary: phone label or data switched Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 28785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28785&action=edit enter data See attached image. You enter date in the secondary and other phone fields on the patron form and it shows next to the opposite label on the patron record. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 28786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28786&action=edit data display -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 Brendon Ford <brendon.ford@manhattan.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendon.ford@manhattan.edu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 Brendon Ford <brendon.ford@manhattan.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |brendon.ford@manhattan.edu --- Comment #2 from Brendon Ford <brendon.ford@manhattan.edu> --- Created attachment 28878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28878&action=edit Fix for switched phone numbers on patron details page. This patch fixes switched phone numbers on patron details page and also makes phone number labels more uniform. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Brendon, Every patch needs a test plan. So after your description type something like : To Test: 1. 2. etc etc So that people can test to be sure the patch works. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 --- Comment #4 from Brendon Ford <brendon.ford@manhattan.edu> --- Sorry about that Nicole. Thanks for the info. To Test: 1. Create/modify a patron entering some unique data into the "Secondary phone:" and "Other phone:" fields (different data for each). 2. Save the patron record. 3. Go to the patrons details page and make sure the data entered into the "Secondary phone:" field is displaying next to the "Secondary phone:" label and that the data entered into the "Other phone:" field is displaying next to the "Other phone:" label. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 Brendon Ford <brendon.ford@manhattan.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28878|0 |1 is obsolete| | --- Comment #5 from Brendon Ford <brendon.ford@manhattan.edu> --- Created attachment 28879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28879&action=edit Fix for switched phone numbers on patron details page. I have added the test plan to the patch and updated it to include actually applying the patch. To Test: 1. Apply the patch. 2. Create/modify a patron entering some unique data into the "Secondary phone:" and "Other phone:" fields (different data for each). 3. Save the patron record. 4. Go to the patrons details page and make sure the data entered into the "Secondary phone:" field is displaying next to the "Secondary phone:" label and that the data entered into the "Other phone:" field is displaying next to the "Other phone:" label. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28879|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 28904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28904&action=edit [SIGNED-OFF] Bug 12407 - phone label or data switched Fix for switched phone numbers on patron details page. This patch fixes switched phone numbers on patron details page and also makes phone number labels more uniform. To Test: 1. Apply the patch. 2. Create/modify a patron entering some unique data into the "Secondary phone:" and "Other phone:" fields (different data for each). 3. Save the patron record. 4. Go to the patrons details page and make sure the data entered into the "Secondary phone:" field is displaying next to the "Secondary phone:" label and that the data entered into the "Other phone:" field is displaying next to the "Other phone:" label. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This looks similar to bug 8760 - maybe someone can take a look? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30393&action=edit Bug 12407 - phone label or data switched Fix for switched phone numbers on patron details page. This patch fixes switched phone numbers on patron details page and also makes phone number labels more uniform. To Test: 1. Apply the patch. 2. Create/modify a patron entering some unique data into the "Secondary phone:" and "Other phone:" fields (different data for each). 3. Save the patron record. 4. Go to the patrons details page and make sure the data entered into the "Secondary phone:" field is displaying next to the "Secondary phone:" label and that the data entered into the "Other phone:" field is displaying next to the "Other phone:" label. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30394&action=edit Bug 12407: [QA Follow-up] Rename Other Phone to Mobile in staff Touches three member templates. Changes label Other into Mobile. This is consistent with database field name and OPAC. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Looks good to me. With reference to bug 8760, I added a QA follow-up to rename Other to Mobile in three member templates. Also note that the field names in the database such as phonepro for secondary phone do not make it easier. Will put a note on the other report too. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- *** Bug 8760 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28904|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #12 from David Cook <dcook@prosentient.com.au> --- (In reply to M. de Rooy from comment #9)
Created attachment 30394 [details] [review] Bug 12407: [QA Follow-up] Rename Other Phone to Mobile in staff
Touches three member templates. Changes label Other into Mobile. This is consistent with database field name and OPAC.
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Yay! I sent a patch for this ages ago ( bug 9383 ), but it was tangled up in a few too many other changes, so I'm happy to see this pass QA finally! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 30549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30549&action=edit Bug 12407: (QA followup) last occurence of 'Other phone' renamed to 'Mobile phone' Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Brendon! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9383 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 Fred P <fred.pierre@smfpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fred.pierre@smfpl.org --- Comment #15 from Fred P <fred.pierre@smfpl.org> --- Great job solving this, but we continue to have issues defining multiple phone numbers. Why do we maintain four separate phone numbers: Primary, secondary, other and SMS number? Most people have a mobile phone - that should be listed first - the SMS number does not need to be a separate field from mobile. Some people have a landline, work phone or alternate number, however Koha doesn't use these alternate numbers, they are only used by Circulation staff, and in our system they are redundant and do not get used. How many people have four phone numbers? Two fields and a duplication of mobile to SMS is sufficient. Maybe a plus sign to add additional numbers if absolutely necessary. By confusing primary, secondary, other and SMS, we get confusion about which field means what. Labeling one number as "Mobile" seems like a logical solution. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 --- Comment #16 from Fred P <fred.pierre@smfpl.org> --- Oops! Looks like I didn't implement the patch yet. Now I see that it is displaying as "mobile." My apologies for the confusion. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13142 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org