https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 --- Comment #2 from Marc Véron <veron@veron.ch> --- See https://lists.katipo.co.nz/pipermail/koha/2017-April/047819.html -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 62498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62498&action=edit Bug 18465 - Patron card creator: Print on duplex card printer Card printers with duplex functionality need as input a PDF file where odd pages contain the front side and even pages the back side of the cards. This patch adds such functionality. To prepare test: - In Patron card creator > Templates, prepare a 1 up template (1 column / 1 row) that fits to a single card. Give it a name like 'Duplex card template' (Attention, Card with and Card height seem to have wrong labels, that will go to a separate bug). - In Patron card creator > Layouts create a layout for the front side and one for the back side. Give them names to easily remember (Card front layout, Card back layout) - Go to Patron card creator > Batches and test both layouts together with the 1 up template. Save and keepp both test files as reference. To test: - Apply patch. Restart memcached and plack. - Go to Patron card creator > Batches - Click "Export" for a batch - In the following screen, note the new field "Select a layout for the back side" with a hint what it is used for - Leave it on 'Back side layout not used', export and compare output with test ooutput from preparation. It should be the same - Select the layout you prepared for the back side. - Export - this file should contain 2 PDF pages per patron, one first with the front side, second with the back side. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marc, we have some probems gettig the setup right, could you share screenshots/information about your configuration (template/layout) maybe? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 63012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63012&action=edit Results duplex card printing based on test settings -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 --- Comment #9 from Marc Véron <veron@veron.ch> --- (In reply to Katrin Fischer from comment #8)

Hi Marc, thx, that's very helpful! Is it ok that both layouts say Page side = Front?

Yes. This is only used for templates with multiple columns. For duplex card print we use only 1 row and 1 column, so it is not needed here. -------- Explanation for page side used with multiple columns: Workflow is to print first the front side, then turn the pages and then pront the back sides. Lets say you have a template with 3 columns and a batch with 3 patrons. The layout for the front prints the names: Name 1 | Name 2 | Name 3 And another layout for the back side prints the first names. Output should be: First name 3 | First name 2 | First name 1 ...to print 'First name 1' on the back of 'Name 1' Page side: 'Back' shuffles data to do that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Mine were not quite as pretty as yours - but it works really well! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62498|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 63046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63046&action=edit [SIGNED OFF] Bug 18465 - Patron card creator: Print on duplex card printer Card printers with duplex functionality need as input a PDF file where odd pages contain the front side and even pages the back side of the cards. This patch adds such functionality. To prepare test: - In Patron card creator > Templates, prepare a 1 up template (1 column / 1 row) that fits to a single card. Give it a name like 'Duplex card template' (Attention, Card with and Card height seem to have wrong labels, that will go to a separate bug). - In Patron card creator > Layouts create a layout for the front side and one for the back side. Give them names to easily remember (Card front layout, Card back layout) - Go to Patron card creator > Batches and test both layouts together with the 1 up template. Save and keepp both test files as reference. To test: - Apply patch. Restart memcached and plack. - Go to Patron card creator > Batches - Click "Export" for a batch - In the following screen, note the new field "Select a layout for the back side" with a hint what it is used for - Leave it on 'Back side layout not used', export and compare output with test ooutput from preparation. It should be the same - Select the layout you prepared for the back side. - Export - this file should contain 2 PDF pages per patron, one first with the front side, second with the back side. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 --- Comment #13 from Marc Véron <veron@veron.ch> --- Still applies on current master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- create-pdf.pl 135 #my $print_layout_xml = $layout_back_xml; 136 my $print_layout_xml = (( ($cardscount % 2 == 1) && ( $layout_back_id ) ) ? 137 clone($layout_back_xml) : clone($layout_xml) ); Fist line looks like debug, is Clone being added as a dependency here? can we just make a copy? Otherwise worked well in testing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 --- Comment #17 from Marc Véron <veron@veron.ch> --- Ok, I tested without clone, it seems to work. Followup follows. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64599|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 --- Comment #19 from Marc Véron <veron@veron.ch> --- Created attachment 64600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64600&action=edit Bug 18465: (followup) Fix issue with patron lists an ddo notuse clone This followup fixes duplex printing with patron lists. Additionaly, it uses simple copy instead of clone and removes a superfluous line, see comments #15 - #17 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 --- Comment #20 from Marc Véron <veron@veron.ch> --- Created attachment 64601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64601&action=edit Bug 18465: (followup) Fix issue with patron lists an do not use clone This followup fixes duplex printing with patron lists. Additionaly, it uses simple copy instead of clone and removes a superfluous line, see comments #15 - #17 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63046|0 |1 is obsolete| | Attachment #64601|0 |1 is obsolete| | --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 64606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64606&action=edit Bug 18465 - Patron card creator: Print on duplex card printer Card printers with duplex functionality need as input a PDF file where odd pages contain the front side and even pages the back side of the cards. This patch adds such functionality. To prepare test: - In Patron card creator > Templates, prepare a 1 up template (1 column / 1 row) that fits to a single card. Give it a name like 'Duplex card template' (Attention, Card with and Card height seem to have wrong labels, that will go to a separate bug). - In Patron card creator > Layouts create a layout for the front side and one for the back side. Give them names to easily remember (Card front layout, Card back layout) - Go to Patron card creator > Batches and test both layouts together with the 1 up template. Save and keepp both test files as reference. To test: - Apply patch. Restart memcached and plack. - Go to Patron card creator > Batches - Click "Export" for a batch - In the following screen, note the new field "Select a layout for the back side" with a hint what it is used for - Leave it on 'Back side layout not used', export and compare output with test ooutput from preparation. It should be the same - Select the layout you prepared for the back side. - Export - this file should contain 2 PDF pages per patron, one first with the front side, second with the back side. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18465 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8604 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image -- You are receiving this mail because: You are watching all bug changes.