https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16856 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |mtompset@hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16856 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 53121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53121&action=edit Bug 16856 - unimarc plugin 4xx template noise While fixing 10148, prove t/db_dependent/FrameworkPlugin.t was run. This triggers UNIMARC 4xx plugin noise. The issue is that itypeloo.selected is not a property that exists in the hash parameter to the template. git grep cataloguing/value_builder/unimarc_field_4XX.tt | grep -v [.]po: The above was used to confirm that there is only one file which affects that template: cataloguing/value_builder/unimarc_field_4XX.pl There is only one way for the Search value to evaluate to true: the else case of the $op check (right at the bottom of the file). The value passed to the itypeloop parameter is a full search from Koha::ItemTypes->search, which has no parameters passed to it, and does not return a 'selected' key as part of the array of hashes. The logic to try to set "selected" in the template makes no sense, as a result, since it is only called with a value that never has "selected" set. The fix is easy: cut the useless code. TEST PLAN --------- 1) prove t/db_dependent/FrameworkPlugin.t -- see unimarc 4xx related noise. 2) apply patch 3) prove t/db_dependent/FrameworkPlugin.t -- no more unimarc 4xx related noise. 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16856 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53121|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 53409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53409&action=edit Bug 16856 - unimarc plugin 4xx template noise While fixing 10148, prove t/db_dependent/FrameworkPlugin.t was run. This triggers UNIMARC 4xx plugin noise. The issue is that itypeloo.selected is not a property that exists in the hash parameter to the template. git grep cataloguing/value_builder/unimarc_field_4XX.tt | grep -v [.]po: The above was used to confirm that there is only one file which affects that template: cataloguing/value_builder/unimarc_field_4XX.pl There is only one way for the Search value to evaluate to true: the else case of the $op check (right at the bottom of the file). The value passed to the itypeloop parameter is a full search from Koha::ItemTypes->search, which has no parameters passed to it, and does not return a 'selected' key as part of the array of hashes. The logic to try to set "selected" in the template makes no sense, as a result, since it is only called with a value that never has "selected" set. The fix is easy: cut the useless code. TEST PLAN --------- 1) prove t/db_dependent/FrameworkPlugin.t -- see unimarc 4xx related noise. 2) apply patch 3) prove t/db_dependent/FrameworkPlugin.t -- no more unimarc 4xx related noise. 4) run koha qa test tools Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16856 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** This bug has been marked as a duplicate of bug 16449 *** -- You are receiving this mail because: You are watching all bug changes.