[Bug 15193] New: Perl scripts missing exec permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 Bug ID: 15193 Summary: Perl scripts missing exec permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Some perl scripts have 644 permissions instead of 755. I think some are special like install-CPAN.pl but others are incorrect for no reason : $ find . -name '*.pl' -exec ls -l {} \; | grep -v "rwx" -rw-rw-r-- 1 fsomers fsomers 4679 oct. 29 15:12 ./misc/cronjobs/nl-sync-from-koha.pl -rw-rw-r-- 1 fsomers fsomers 5697 oct. 29 15:12 ./misc/cronjobs/nl-sync-to-koha.pl -rw-rw-r-- 1 fsomers fsomers 13064 oct. 29 15:12 ./misc/load_testing/benchmark_staff.pl -rw-rw-r-- 1 fsomers fsomers 913 juil. 28 15:17 ./selenium/PERL/Members/AddMember.pl -rw-rw-r-- 1 fsomers fsomers 1287 juil. 28 15:17 ./selenium/PERL/Members/FilterMembers.pl -rw-rw-r-- 1 fsomers fsomers 1020 juil. 28 15:17 ./selenium/PERL/Members/Searchmember.pl -rw-rw-r-- 1 fsomers fsomers 10593 oct. 29 15:12 ./koha-tmpl/intranet-tmpl/lib/tiny_mce/tiny_mce_gzip.pl -rw-r--r-- 1 fsomers fsomers 266 nov. 13 12:28 ./kohaversion.pl -rw-r--r-- 1 fsomers fsomers 1529 nov. 10 16:54 ./install-CPAN.pl -rw-r--r-- 1 fsomers fsomers 3455 nov. 10 16:54 ./cataloguing/value_builder/unimarc_field_100_authorities.pl -rw-r--r-- 1 fsomers fsomers 11552 nov. 13 12:28 ./cataloguing/value_builder/marc21_linking_section.pl -rw-r--r-- 1 fsomers fsomers 5082 nov. 10 16:54 ./cataloguing/value_builder/EXAMPLE.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|gmcharlt@gmail.com |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 44874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44874&action=edit Bug 15193 - Perl scripts missing exec permission Some perl scripts have 644 permissions instead of 755. I think some are special like install-CPAN.pl. This patch corrects some common perl scripts. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- I still find some scripts without execute permissions, is that ok? -rw-r--r-- 1 bgkriegel bgkriegel 266 Oct 15 18:51 ./kohaversion.pl -rw-r--r-- 1 bgkriegel bgkriegel 1287 Oct 15 18:51 ./selenium/PERL/Members/FilterMembers.pl -rw-r--r-- 1 bgkriegel bgkriegel 913 Oct 15 18:51 ./selenium/PERL/Members/AddMember.pl -rw-r--r-- 1 bgkriegel bgkriegel 1020 Oct 15 18:51 ./selenium/PERL/Members/Searchmember.pl -rw-r--r-- 1 bgkriegel bgkriegel 1529 Oct 15 18:51 ./install-CPAN.pl -rw-r--r-- 1 bgkriegel bgkriegel 13064 Oct 15 18:51 ./misc/load_testing/benchmark_staff.pl -rw-r--r-- 1 bgkriegel bgkriegel 5082 Oct 15 18:51 ./cataloguing/value_builder/EXAMPLE.pl -rw-r--r-- 1 bgkriegel bgkriegel 10593 Oct 15 18:51 ./koha-tmpl/intranet-tmpl/lib/tiny_mce/tiny_mce_gzip.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #2)
I still find some scripts without execute permissions, is that ok?
-rw-r--r-- 1 bgkriegel bgkriegel 266 Oct 15 18:51 ./kohaversion.pl I don't see why it could not have execute permissions.
-rw-r--r-- 1 bgkriegel bgkriegel 1287 Oct 15 18:51 ./selenium/PERL/Members/FilterMembers.pl -rw-r--r-- 1 bgkriegel bgkriegel 913 Oct 15 18:51 ./selenium/PERL/Members/AddMember.pl -rw-r--r-- 1 bgkriegel bgkriegel 1020 Oct 15 18:51 ./selenium/PERL/Members/Searchmember.pl Selenium is special I think, keep like this.
-rw-r--r-- 1 bgkriegel bgkriegel 1529 Oct 15 18:51 ./install-CPAN.pl This is like Makefile.PL, maybe not executable to avoid launching by mistake.
-rw-r--r-- 1 bgkriegel bgkriegel 13064 Oct 15 18:51 ./misc/load_testing/benchmark_staff.pl May have execute permissions I'd say.
-rw-r--r-- 1 bgkriegel bgkriegel 5082 Oct 15 18:51 ./cataloguing/value_builder/EXAMPLE.pl Maybe on purpose since it is a sample.
-rw-r--r-- 1 bgkriegel bgkriegel 10593 Oct 15 18:51 ./koha-tmpl/intranet-tmpl/lib/tiny_mce/tiny_mce_gzip.pl This is an imported library so I'd say we don't change.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44874|0 |1 is obsolete| | --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 45348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45348&action=edit [SIGNED-OFF]Bug 15193: Perl scripts missing exec permission Some perl scripts have 644 permissions instead of 755. I think some are special like install-CPAN.pl. This patch corrects some common perl scripts. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45348|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45584&action=edit Bug 15193 - Perl scripts missing exec permission Some perl scripts have 644 permissions instead of 755. I think some are special like install-CPAN.pl. This patch corrects some common perl scripts. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master! Thanks Frido! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15193 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.7. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org