[Bug 18471] New: Receiving order with unitprice greater than 1000 processing incorrectly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Bug ID: 18471 Summary: Receiving order with unitprice greater than 1000 processing incorrectly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Two problems here really: Receiving orders process the comma as a decimal point Invoices are displaying incorrectly when formatting total To recreate: 1 - Open a basket 2 - Place an order for an item with price > 1000, $4367.00 for example 3 - Close basket 4 - Receive order 5 - Note on orderreceive.pl the price is populate as "4,367.00" 6 - Receive/Save 7 - Note the 'Actual Cost' is now $4.00, verify db contains 4 as well 8 - Cancel receipt 9 - Receive again, this time enter price as "4367" 10 - Receive/save 11 - Note actual cost is correct 12 - Finish receiving 13 - Note invoice reads total as $4.00 14 - Check db - price in aqorders is correct but displaying incorrectly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 62530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62530&action=edit Bug 18471 - Receiving order with unitprice greater than 1000 processing incorrectly Receiving orders process the comma as a decimal point Invoices are displaying incorrectly when formatting total Test Plan: 1. Open a basket 2. Place an order for an item with price > 1000, $4367.00 for example 3. Close basket 4. Receive order 5. Note on orderreceive.pl the price is populate as "4,367.00" 6. Receive/Save 7. Note the 'Actual Cost' is now $4.00, verify db contains 4 as well 8. Cancel receipt 9. Receive again, this time enter price as "4367" 10. Receive/save 11. Note actual cost is correct 12. Finish receiving 13. Note invoice reads total as $4.00 14. Check db. price in aqorders is correct but displaying incorrectly 15. Apply this patch 16. Repeat step2 1. 14, note errors are fixed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- I tried to replicate this bug on a clean up to date branch and was unable to, the price of 4367.00 was shown throughout the whole of the purchasing process and was also correct in the db -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Alex Buckley from comment #2)
I tried to replicate this bug on a clean up to date branch and was unable to, the price of 4367.00 was shown throughout the whole of the purchasing process and was also correct in the db
This may be specific to USD and/or browser settings. If the comma is not displaying at any point in the ordering that seems likely -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62530|0 |1 is obsolete| | --- Comment #4 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 62653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62653&action=edit Bug 18471 - Receiving order with unitprice greater than 1000 processing incorrectly Receiving orders process the comma as a decimal point Invoices are displaying incorrectly when formatting total Test Plan: 1. Open a basket 2. Place an order for an item with price > 1000, $4367.00 for example 3. Close basket 4. Receive order 5. Note on orderreceive.pl the price is populate as "4,367.00" 6. Receive/Save 7. Note the 'Actual Cost' is now $4.00, verify db contains 4 as well 8. Cancel receipt 9. Receive again, this time enter price as "4367" 10. Receive/save 11. Note actual cost is correct 12. Finish receiving 13. Note invoice reads total as $4.00 14. Check db. price in aqorders is correct but displaying incorrectly 15. Apply this patch 16. Repeat step2 1. 14, note errors are fixed Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 18491 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why do you unformat on finishreceive.pl? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #6)
Why do you unformat on finishreceive.pl?
Because we have, in the template: 353 <input type="text" size="20" name="unitprice" id="unitprice" value="[% unitprice | $Price %]" /> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62653|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62677&action=edit Bug 18471 - Receiving order with unitprice greater than 1000 processing incorrectly Receiving orders process the comma as a decimal point Invoices are displaying incorrectly when formatting total Test Plan: 1. Open a basket 2. Place an order for an item with price > 1000, $4367.00 for example 3. Close basket 4. Receive order 5. Note on orderreceive.pl the price is populate as "4,367.00" 6. Receive/Save 7. Note the 'Actual Cost' is now $4.00, verify db contains 4 as well 8. Cancel receipt 9. Receive again, this time enter price as "4367" 10. Receive/save 11. Note actual cost is correct 12. Finish receiving 13. Note invoice reads total as $4.00 14. Check db. price in aqorders is correct but displaying incorrectly 15. Apply this patch 16. Repeat step2 1. 14, note errors are fixed Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carlos.cordovas@gmail.com --- Comment #10 from Colin Campbell <colin.campbell@ptfs-europe.com> --- *** Bug 18500 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch doesn't apply to 16.11.x - please rebase/comment if it's needed there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 --- Comment #12 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #11)
Patch doesn't apply to 16.11.x - please rebase/comment if it's needed there.
Yes it is required for 16.11 - I'll rebase the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 --- Comment #13 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 63461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63461&action=edit Patch rebased to use 16.11 Bookseller class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for the rebase patch, Colin! This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #15 from Mason James <mtj@kohaaloha.com> ---
Yes it is required for 16.11 - I'll rebase the patch
hi Folks, does this problem exist in 16.05.x? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 --- Comment #16 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Mason James from comment #15)
Yes it is required for 16.11 - I'll rebase the patch
hi Folks, does this problem exist in 16.05.x?
I think not. 16.11 introduced some price formatting changes that caused a problem when amounts wth a comma were passed. I think 16.5 does the right thing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Colin Campbell from comment #16)
(In reply to Mason James from comment #15)
Yes it is required for 16.11 - I'll rebase the patch
hi Folks, does this problem exist in 16.05.x?
I think not. 16.11 introduced some price formatting changes that caused a problem when amounts wth a comma were passed. I think 16.5 does the right thing
Hi Colin, can you file a bug for any existing problems please? I'd like to get 16.11.x as bug free as possible! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 --- Comment #18 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #17)
(In reply to Colin Campbell from comment #16)
(In reply to Mason James from comment #15)
Yes it is required for 16.11 - I'll rebase the patch
hi Folks, does this problem exist in 16.05.x?
I think not. 16.11 introduced some price formatting changes that caused a problem when amounts wth a comma were passed. I think 16.5 does the right thing
Hi Colin, can you file a bug for any existing problems please? I'd like to get 16.11.x as bug free as possible!
I think the problems are resolved by the applied patch. Problem was the new formatting was being applied twice - patch resolves the effects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18900 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18900 [Bug 18900] Receiving order with unitprice multiples by 1000 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19521 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18723 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19521 | CC| |victor.grousset@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|FIXED |--- CC| |januszop@gmail.com --- Comment #20 from Janusz Kaczmarek <januszop@gmail.com> --- Could you, please, reconsider this patch? After the patch of Bug 20881 extended price filtering with "on_editing" in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt, now (18.05.06), with European (= FR) CurrencyFormat, the 'unformat' makes troubles: the unitprice (which now is passed without formatting) gets multiplied by 100 while receiving orders. Thank you for verifying and reconsidering this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18471 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Janusz, this patch was pushed to all versions - I think we need an new patch on a new bug. There is also a bug report for the problem you describe, that I'd love to see fixed: bug 18723 Dot not recognized as decimal separator on receive -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org