[Bug 6674] New: Collapse display of patron address by default
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6674 Bug #: 6674 Summary: Collapse display of patron address by default Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: enhancement Priority: P5 Component: Circulation AssignedTo: oleonard@myacpl.org ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Use CSS+JS to collapse the display of the patron address in the sidebar on circ and patron related pages. This change is being pulled from Bug 5436 since it's unrelated to patron attributes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6674 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-08-08 14:15:33 UTC --- Created attachment 4889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4889 Proposed fix This patch takes the feature implemented in the original patch for Bug 5436 and reimplements it in a slightly more abstracted way. The JavaScript can now be applied to any pair of elements like this: a block with class "collapsed" followed by a link with class "togglecollapse." In the circ-menu include, both the address info block and the link to show/hide it have unique ids ("contact" and "showcontact" respectively) so that IntranetUserCSS can be used to force the address information to show: #contact { display : block; } #showcontact { display : none; } -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6674 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6674 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-08-08 14:18:53 UTC --- Incidentally, I thought this was an interesting UI problem to solve, but I'm not convinced that it is necessary. I would be interested in hearing from Biblibre about the motivation for developing it. Was it because adding the display of extended patron attributes was pushing the navigation links down too far? If so we'll have to revisit this in reference to patron attributes. This patch groups "contact information" under one heading. We would need to add an additional "group" for extended attributes (something which this patch facilitates). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6674 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Signed Off --- Comment #3 from Nicole C. Engard <nengard@gmail.com> 2011-08-08 17:16:49 UTC --- That is so cool :) signed off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6674 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4889|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2011-09-23 13:39:22 UTC --- Created attachment 5562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5562 Revised fix Revision adds compatibility for display of extended patron attributes and makes changes consistent across includes, including circ-menu.tt. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6674 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2011-09-23 13:41:15 UTC --- Created attachment 5563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5563 Screenshot of collapsed patron info in the sidebar This would be the default view: both the contact information block and the library information block are collapsed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6674 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> 2011-09-23 13:42:36 UTC --- Created attachment 5564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5564 Screenshot of expanded patron info in the sidebar The expanded view shows what information is in each block. Note the "Patron's pets" line is an extended patron attribute. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6674 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6674 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5564|1 |0 is patch| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6674 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5564|text/plain |image/png mime type| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6674 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #7 from Nicole C. Engard <nengard@gmail.com> 2011-09-28 15:07:22 UTC --- Tested in Chrome and FF on Mac and I can't get the information to expand. I click the links and nothing happens. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6674 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5562|0 |1 is obsolete| | --- Comment #8 from Nicole C. Engard <nengard@gmail.com> 2011-09-28 15:35:56 UTC --- Created attachment 5631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5631 [SIGNED-OFF] Fix for Bug 6674 - Collapse display of patron address by default This patch takes the feature implemented in the original patch for Bug 5436 and reimplements it in a slightly more abstracted way. The JavaScript can now be applied to any pair of elements like this: a block with class "collapsed" followed by a link with class "togglecollapse." In the circ-menu include, both the address info block and the link to show/hide it have unique ids ("contact" and "showcontact" respectively) so that IntranetUserCSS can be used to force them to show: #contact { display : block; } #showcontact { display : none; } Revision adds compatibility for display of extended patron attributes and makes changes consistent across includes, including circ-menu.tt. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6674 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6674 --- Comment #9 from Nicole C. Engard <nengard@gmail.com> 2011-09-29 12:59:37 UTC --- Created attachment 5638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5638 [SIGNED-OFF] Bug 6937 - change "Fines" to "Fees & Charges" on circ page Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6674 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5638|0 |1 is obsolete| | --- Comment #10 from Nicole C. Engard <nengard@gmail.com> 2011-09-29 13:00:15 UTC --- Comment on attachment 5638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5638 [SIGNED-OFF] Bug 6937 - change "Fines" to "Fees & Charges" on circ page sorry i attached this to the wrong report -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6674 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Failed QA --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-07 16:01:48 UTC --- QA comment: Is it intended to have the headers *below* the information itself. That's quite strange: in MARC editor, for example, when you expand a field, subfields appear after the field. Marking failed QA unless you convince me that should be that way ! (In reply to comment #2)
Incidentally, I thought this was an interesting UI problem to solve, but I'm not convinced that it is necessary. I would be interested in hearing from Biblibre about the motivation for developing it. Was it because adding the display of extended patron attributes was pushing the navigation links down too far? We were not the original author of the patch, or am I missing something ?
-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6674 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> 2011-10-07 16:10:03 UTC --- (In reply to comment #11)
We were not the original author of the patch, or am I missing something ?
The original changes were found in the patch for Bug 5436. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6674 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org