[Bug 16159] New: guarantor section missing ID on patron add form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159 Bug ID: 16159 Summary: guarantor section missing ID on patron add form Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 49645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49645&action=edit code See attached. The Guarantor section doesn't have an ID. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15928 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Could you please detail what is the bug? Is it related to bug 15928? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51164&action=edit Bug 16159 - guarantor section missing ID on patron add form In the patron entry form template most <fieldset> and <legend> tags have unique ids. This patch adds ids to fieldsets and legends which lack them. To test apply the patch and view the patron entry form. There should be no visual changes. There should be no HTML validation errors triggered by this change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51164|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 51178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51178&action=edit Bug 16159 - guarantor section missing ID on patron add form In the patron entry form template most <fieldset> and <legend> tags have unique ids. This patch adds ids to fieldsets and legends which lack them. To test apply the patch and view the patron entry form. There should be no visual changes. There should be no HTML validation errors triggered by this change. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why do we need an id on the legend elements? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #4)
Why do we need an id on the legend elements?
I don't know. I assume that the IDs were added at some time in the past in order to facilitate some kind of customization. My patch simply makes them consistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7540 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #5)
(In reply to Jonathan Druart from comment #4)
Why do we need an id on the legend elements?
I don't know. I assume that the IDs were added at some time in the past in order to facilitate some kind of customization. My patch simply makes them consistent.
Added by bug 7540. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51178|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51208&action=edit Bug 16159 - guarantor section missing ID on patron add form In the patron entry form template most <fieldset> and <legend> tags have unique ids. This patch adds ids to fieldsets and legends which lack them. To test apply the patch and view the patron entry form. There should be no visual changes. There should be no HTML validation errors triggered by this change. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |unspecified -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16159 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org