https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 141577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141577&action=edit Bug 31729: Enable automatic filesystem refresh in Plack patch uses the following module... https://metacpan.org/pod/Plack::Middleware::Refresh to test: 1/ start ktd 2/ add warn to about.pl file, load page, observe no output in log :( 3/ apply patch to /etc/koha/plack.psgi 4/ restart plack 5/ add warn to about.pl file, load page, observe output in log :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #3 from Mason James <mtj@kohaaloha.com> --- hmm, i've spotted a problem here switching back to ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #5 from Mason James <mtj@kohaaloha.com> --- (In reply to David Cook from comment #4)

(In reply to Mason James from comment #1)

...

to test:

1/ start ktd 2/ add warn to about.pl file, load page, observe no output in log :( 3/ apply patch to /etc/koha/plack.psgi 4/ restart plack 5/ add warn to about.pl file, load page, observe output in log :)

I don't think Plack::Middleware::Refresh would apply in this situation, since Module::Refresh scans the %INC for modified files.

this seems to be a better solution for ktd https://gitlab.com/mjames/koha-reload-starman/-/blob/master/koha-reload-star... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141577|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141596&action=edit Bug 31729: Enable automatic filesystem refresh in Plack patch uses the following module... https://metacpan.org/pod/Plack::Middleware::Refresh to test: 1/ start ktd 2/ add warn to about.pl file, load page, observe no output in log :( 3/ apply patch to /etc/koha/plack.psgi 4/ restart plack 5/ add warn to about.pl file, load page, observe output in log :) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141598&action=edit Bug 31729: Add missing brace (and tidy) This adds a missing closing bracket and runs perltidy over the .psgi scripts. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #12 from Mason James <mtj@kohaaloha.com> --- Created attachment 141715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141715&action=edit Bug 31729: Enable automatic filesystem refresh in Plack (2) fix typo -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #14 from Mason James <mtj@kohaaloha.com> ---

5/ modify file in watched dir echo `date` > /usr/share/koha/xxx1 echo `date` > /usr/share/koha/xxx2

if testing in KTD, try... # echo `date` > /kohadevbox/koha/xxx2 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #16 from Mason James <mtj@kohaaloha.com> --- Created attachment 142043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142043&action=edit Bug 31729: watch only perl files -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142044|0 |1 is obsolete| | --- Comment #18 from Mason James <mtj@kohaaloha.com> --- Created attachment 142050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142050&action=edit Bug 31729: add 2 sec loop to koha-watcher, to avoid reload flooding -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 pierre.genty@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141714|0 |1 is obsolete| | Attachment #141715|0 |1 is obsolete| | Attachment #142043|0 |1 is obsolete| | Attachment #142050|0 |1 is obsolete| | --- Comment #21 from Mason James <mtj@kohaaloha.com> --- Created attachment 148600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148600&action=edit Bug 31729: Enable automatic filesystem refresh in Plack to test (on KTD) - install inotify-tools $ sudo apt install inotify-tools - apply patch $ git bz apply 31729 - manually install files and set perms $ cd /kohadevbox/koha $ sudo cp debian/scripts/koha-plack /usr/sbin $ sudo cp debian/scripts/koha-watcher /usr/sbin $ sudo chmod 755 /usr/sbin/koha-plack $ sudo chmod 755 /usr/sbin/koha-watcher - restart, with --watch arg $ sudo koha-plack --restart --watch kohadev - observe koha-watch process $ ps -ef | grep koha-watcher | grep -v grep | wc -l 3 - modify some perl files in watched dir $ echo `date` > /kohadevbox/koha/xxx.pl $ echo `date` > /kohadevbox/koha/xxx.pm - see HUP/inotify messages in log file $ tail -f /var/log/koha/kohadev/plack-error.log CLOSE_WRITE,CLOSE happened to xxx.pl in /kohadevbox/koha/ CLOSE_WRITE,CLOSE happened to xxx.pm in /kohadevbox/koha/ Sending children hup signal - stop koha-plack $ sudo koha-plack --stop kohadev - observe no koha-watch process $ ps -ef | grep koha-watcher | grep -v grep | wc -l 0 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #23 from Mason James <mtj@kohaaloha.com> --- Created attachment 148602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148602&action=edit Bug 31729: fix quoting and set sh -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #25 from Mason James <mtj@kohaaloha.com> --- Created attachment 148606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148606&action=edit Bug 31729: move $tmpfile to /tmp dir, and add {} -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Why are you logging in plack-error.log? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148612|0 |1 is obsolete| | --- Comment #28 from Mason James <mtj@kohaaloha.com> --- Created attachment 148613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148613&action=edit Bug 31729: renamed log file to plack-watcher.log to test... - modify some perl files in watched dir $ echo `date` > /kohadevbox/koha/xxx.pl $ echo `date` > /kohadevbox/koha/xxx.pm - see HUP/inotify messages in log file $ tail -f /var/log/koha/kohadev/plack-watcher.log \ /var/log/koha/kohadev/plack-error.log CLOSE_WRITE,CLOSE happened to xxx.pl in /kohadevbox/koha/ CLOSE_WRITE,CLOSE happened to xxx.pm in /kohadevbox/koha/ Sending children hup signal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148600|0 |1 is obsolete| | Attachment #148603|0 |1 is obsolete| | Attachment #148606|0 |1 is obsolete| | Attachment #148613|0 |1 is obsolete| | --- Comment #30 from Mason James <mtj@kohaaloha.com> --- Created attachment 148720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148720&action=edit Bug 31729: Enable automatic filesystem refresh in Plack to test (on KTD) - install inotify-tools $ sudo apt install inotify-tools - apply patch $ git bz apply 31729 - manually install files and set perms $ cd /kohadevbox/koha $ sudo cp debian/scripts/koha-plack /usr/sbin $ sudo cp debian/scripts/koha-watcher /usr/sbin $ sudo chmod 755 /usr/sbin/koha-plack $ sudo chmod 755 /usr/sbin/koha-watcher - restart, with --watch arg $ sudo koha-plack --restart --watch kohadev - observe koha-watch process $ ps -ef | grep koha-watcher | grep -v grep | wc -l 3 - modify some perl files in watched dir $ echo `date` > /kohadevbox/koha/xxx.pl $ echo `date` > /kohadevbox/koha/xxx.pm - see HUP/inotify messages in log file $ tail -f /var/log/koha/kohadev/plack-watcher.log CLOSE_WRITE,CLOSE event on /kohadevbox/koha/xxx.pl CLOSE_WRITE,CLOSE event on /kohadevbox/koha/xxx.pm koha-plack reloaded - add syntax error to file in watched dir $ echo `date` > /kohadevbox/koha/C4/Context.pm - see HUP/inotify messages in log file $ tail -f /var/log/koha/kohadev/plack-watcher.log CLOSE_WRITE,CLOSE event on /kohadevbox/koha/C4/Context.pm koha-plack failed! sleeping 2 secs koha-plack failed! sleeping 3 secs koha-plack failed! sleeping 4 secs ... koha-plack failed! sleeping 10 secs - fix syntax error in file in watched dir $ git checkout /kohadevbox/koha/C4/Context.pm - see HUP/inotify messages in log file $ tail -f /var/log/koha/kohadev/plack-watcher.log CLOSE_WRITE,CLOSE event on /kohadevbox/koha/C4/Context.pm koha-plack reloaded ok - stop koha-plack $ sudo koha-plack --stop kohadev - observe no koha-watch process $ ps -ef | grep koha-watcher | grep -v grep | wc -l 0 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31074 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |domm@plix.at -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Pascal Uphaus <pascal.uphaus@gwdg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148720|0 |1 is obsolete| | --- Comment #32 from Pascal Uphaus <pascal.uphaus@gwdg.de> --- Created attachment 154542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154542&action=edit Bug 31729: Enable automatic filesystem refresh in Plack to test (on KTD) - install inotify-tools $ sudo apt install inotify-tools - apply patch $ git bz apply 31729 - manually install files and set perms $ cd /kohadevbox/koha $ sudo cp debian/scripts/koha-plack /usr/sbin $ sudo cp debian/scripts/koha-watcher /usr/sbin $ sudo chmod 755 /usr/sbin/koha-plack $ sudo chmod 755 /usr/sbin/koha-watcher - restart, with --watch arg $ sudo koha-plack --restart --watch kohadev - observe koha-watch process $ ps -ef | grep koha-watcher | grep -v grep | wc -l 3 - modify some perl files in watched dir $ echo `date` > /kohadevbox/koha/xxx.pl $ echo `date` > /kohadevbox/koha/xxx.pm - see HUP/inotify messages in log file $ tail -f /var/log/koha/kohadev/plack-watcher.log CLOSE_WRITE,CLOSE event on /kohadevbox/koha/xxx.pl CLOSE_WRITE,CLOSE event on /kohadevbox/koha/xxx.pm koha-plack reloaded - add syntax error to file in watched dir $ echo `date` > /kohadevbox/koha/C4/Context.pm - see HUP/inotify messages in log file $ tail -f /var/log/koha/kohadev/plack-watcher.log CLOSE_WRITE,CLOSE event on /kohadevbox/koha/C4/Context.pm koha-plack failed! sleeping 2 secs koha-plack failed! sleeping 3 secs koha-plack failed! sleeping 4 secs ... koha-plack failed! sleeping 10 secs - fix syntax error in file in watched dir $ git checkout /kohadevbox/koha/C4/Context.pm - see HUP/inotify messages in log file $ tail -f /var/log/koha/kohadev/plack-watcher.log CLOSE_WRITE,CLOSE event on /kohadevbox/koha/C4/Context.pm koha-plack reloaded ok - stop koha-plack $ sudo koha-plack --stop kohadev - observe no koha-watch process $ ps -ef | grep koha-watcher | grep -v grep | wc -l 0 Signed-off-by: Pascal Uphaus <pascal.uphaus@gwdg.de> Signed-off-by: Thomas Klausner <domm@plix.at> Signed-off-by: Lari Strand <lari.strand@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #34 from David Cook <dcook@prosentient.com.au> --- (In reply to Thomas Klausner from comment #33)

FYI, I have another approach nearly finished, where instead of creating a new daemon and using inotify we start the Plack app via plackup (instead of just usnig starman) and use the -R flag to reload when something changed.

This is the common way to do is in Plack apps, and does not need another service.

I use plackup (without -R) for a different Plack app of mine, and I find it doesn't work very well. Maybe it's how I'm using it or some middleware I'm using, but it tends to be slow and seems to hang on some requests until I send another request. But it's worth a try.

The patch will be ready tomorrow at the latest

(side note: Not sure if you want the patch in this ticket or in a new one?)

I think you could attach it here and just mark it as [Alternate] -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #36 from Mason James <mtj@kohaaloha.com> --- (In reply to Thomas Klausner from comment #33)

FYI, I have another approach nearly finished, where instead of creating a new daemon and using inotify we start the Plack app via plackup (instead of just usnig starman) and use the -R flag to reload when something changed.

This is the common way to do is in Plack apps, and does not need another service.

The patch will be ready tomorrow at the latest

(side note: Not sure if you want the patch in this ticket or in a new one?)

hi Thomas, i think that plack needs to be restarted if template files (.inc and .tt) are modified ...if so, i dont think `plackup -R` with handle modifying template files? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154601|0 |1 is obsolete| | --- Comment #39 from Thomas Klausner <domm@plix.at> --- Created attachment 154605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154605&action=edit Bug 31729: enable plackup hot restart in ktd [Alternate] This patch implements a more idiomatoic way for hot-reloading. Instead of adding a new daemon/watcher+inotify or use a Middleware, we can use `plackup -R /path/to/dir`, which is the standard Perl way to do hot reloading for plack apps. Instead of calling `/usr/bin/perl starman` directly, we use `plackup -s Starman`. And can then use `-R /kohadevbox/koha/Koha` to watch that directory for changes and hot-reload the plack app. I've added a new option `koha-plack --hot-reload`. Only if this option is set AND we're running inside koha-testing-docker (by checking KOHA_INSTANCE = "kohadev") hot reloading is enabled. Test plan: Before applying the patch: * Start koha-testing-docker and enter the container * Stop plack: koha-plack --stop kohadev * Check the log: tail -n 4 /var/log/koha/kohadev/plack-error.log You should see lines like Worker processes cleaned up Server closing! * Start it again: koha-plack --start kohadev Output should be "Starting Plack daemon for kohadev:" And you end back at the interactive shell * Check the log: tail -n 4 /var/log/koha/kohadev/plack-error.log it should look like: Starman::Server (type Net::Server::PreFork) starting! Binding to UNIX socket file "/var/run/koha/kohadev/plack.sock" Starman: Accepting connections at unix://localhost:/var/run/koha/kohadev/plack.sock/ * Stop it again: koha-plack --stop kohadev Now apply the patch. As in koha-testing-docker the koha-plack script (after applying the patch) is NOT installed to /sbin you have to call the dev version. * Start the server with hot-reloading: debian/scripts/koha-plack --start --hot-reload kohadev * Output should be: Starting Plack daemon for kohadev:Watching /kohadevbox/koha/Koha /etc/koha/sites/kohadev/plack.psgi for file updates. * You are now NOT back in the shell, as the plack app is NOT running daemonized * So you need to open another ktd --shell * Check the log: tail -n 4 /var/log/koha/kohadev/plack-error.log Starman::Server (type Net::Server::PreFork) starting! pid(27638) Binding to UNIX socket file "/var/run/koha/kohadev/plack.sock" Starman: Accepting connections at unix://localhost:/var/run/koha/kohadev/plack.sock/ * Update a code file touch Koha/Biblios.pm * in the other shell (where plack is running) you should see: -- /kohadevbox/koha/Koha/Biblios.pm updated. Killing the existing server Successfully killed! Restarting the new server process. * Yay! * If you want to still stop/restart plack manually, you can hit CTRL-C in the shell were you started plack to stop the process. Sponsored-by: HKS3 - https://koha-support.eu -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #43 from David Cook <dcook@prosentient.com.au> --- Created attachment 154677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154677&action=edit Bug 31729: [Alternate][follow-up] watch whole codebase Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #44 from David Cook <dcook@prosentient.com.au> --- Signing off on the "Alternate" patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mtj@kohaaloha.com |domm@plix.at -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #46 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #45)

I think we should: 1. test DEV_INSTALL instead of KOHA_INSTANCE, and watch KOHA_HOME instead of /kohadevbox/koha 2. Rename hot_reload with watch (what we use to rebuild JS: `yarn js:watch`) 3. There is a tab character l.457 >-----hot-reload)

Sounds good to me.

Then, a question: 4. We are moving from starman to plackup. What do we lose/gain? I know I was using plackup before the move to kohadevbox.

Good point. We should double-check that --max-requests and --workers flow through as expected. I was playing around with plackup and Starman on a different project the other day, and there can be subtle differences with options that don't show obvious warnings/errors. Worth taking another look at that.

And, linking to a 2016 related discussion: 5. Found that from a random guy: https://lists.koha-community.org/pipermail/koha-devel/2016-September/043026. html

Also interesting. Personally, I'm not even interested in an automatic filesystem refresh for Plack, so I'm not sure why I'm even still involved in this one. I think I originally just commented so that we didn't go down certain problematic paths 😅 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #48 from Thomas Klausner <domm@plix.at> --- Here is a rather simple bash script that will set all the envs etc and start Koha via plackup with hot-reload. I did not provide this as a patch (yet), because I don't think this script should go into the Koha repo, as it's tailored specifically for koha-testing-docker. But I'd still appreciate some feedback (and some hints on where to add this to ktd; or the OK to add it to Koha itself) cat koha-plack-hotreload set -e instancename='kohadev' instance_user="${instancename}-koha" placksocket="/var/run/koha/${instancename}/plack.sock" psgifile="/etc/koha/plack.psgi" export DEV_INSTALL=1 export KOHA_HOME=/kohadevbox/koha export KOHA_CONF="/etc/koha/sites/${instancename}/koha-conf.xml" export PERL5LIB=/kohadevbox/koha:/kohadevbox/koha/lib:/kohadevbox/koha/installer # run plackup with hot reload /usr/bin/plackup -M FindBin -R /kohadevbox/koha --workers 2 --user=${instance_user} --group ${instance_user} -E deployment --socket ${placksocket} -s Starman ${psgifile} Greetings, domm -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #50 from Olivier Hubert <olivier.hubert@inlibro.com> ---

plackup -R doesn't with --daemonize, could that be a problem?

It's certainly going to be a problem for us, as that is how we run Plack. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Thomas Klausner from comment #51)

I think we should NOT apply any of these patches:

Hot reload is only needed during dev, and it's much easier to (manually) start koha-plack in a non-demaonized way with hot-reload in Koha-Testing-Docker, than to modify this (IMO slightly crazy) script to start Koha in production.

I am not sure if it's only needed during dev time - we have the issue of updating and installing plugins not taking effect without a Plack restart, which would be great to resolve. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #54 from Thomas Klausner <domm@plix.at> --- Here's what I'm using to start a hot-reload server in koha-testing-docker: ktd --shell kohadev-koha@kohadevbox:koha$ koha-plack --stop kohadev Stopping Plack daemon for kohadev:. kohadev-koha@kohadevbox:koha$ DEV_INSTALL=1 KOHA_HOME=/kohadevbox/koha KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml PERL5LIB=/kohadevbox/koha:/kohadevbox/koha/lib:/kohadevbox/koha/installer /usr/bin/plackup -M FindBin -R /kohadevbox/koha --workers 2 --user=kohadev-koha --group=kohadev-koha -E deployment --socket /var/run/koha/kohadev/plack.sock -s Starman /etc/koha/plack.psgi Watching /kohadevbox/koha /etc/koha/plack.psgi for file updates. 2023/11/09-09:15:15 Starman::Server (type Net::Server::PreFork) starting! pid(2344) Binding to UNIX socket file "/var/run/koha/kohadev/plack.sock" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31729 --- Comment #56 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Thomas Klausner from comment #51)

I think we should NOT apply any of these patches:

Hot reload is only needed during dev, and it's much easier to (manually) start koha-plack in a non-demaonized way with hot-reload in Koha-Testing-Docker, than to modify this (IMO slightly crazy) script to start Koha in production.

[...] So I suggest we reject these patches and instead add either docs or a small wrapper script to koha-testing-docker.

Thanks for your manual solution. It would still be great to have hot reload on by default on KTD so it's less error prone for everyone to test patches. (at least the vast majority using KTD) The question is how is it the cleanest. Here in koha-plack. Or with changing the KTD scripts. This ticket has a counter part in the KTD issue tracker: https://gitlab.com/koha-community/koha-testing-docker/-/issues/307 -- You are receiving this mail because: You are watching all bug changes.