[Bug 10595] New: OpacTopissue page still accessible when system preference is turned off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 Bug ID: 10595 Summary: OpacTopissue page still accessible when system preference is turned off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The page for most popular titles should not be accessible when the feature is turned off in the system preferences (OpacTopissues). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 --- Comment #1 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 19698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19698&action=edit Bug 10595 - OpacTopissue page still accessible when system preference is turned off When the syspref is turned off, the link is hidden but the page is still accessible. This patch checks the syspref and redirects to 404 if it is disabled. Test plan: Before applying the patch Enable OpacTopissue Observe there is a link to opac-topissues.pl next to Advanced search etc. Follow that link, observe that opac-topissues.pl is loading Disable OpacTopissue Observe the link is gone Manually open /koha/opac-topissues.pl and check that it is loading even though the feature is disabled Apply patch (OpacTopissue still diabled) Manually open /koha/opac-topissues.pl and observe that you are being redirected to the 404 page. Enable OpacTopissue Follow the link or manuall open opac-topissues.pl and check that it is working Signoff the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |mirko@abunchofthings.net Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19698|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 19703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19703&action=edit [SIGNED-OFF] Bug 10595 - OpacTopissue page still accessible when system preference is turned off When the syspref is turned off, the link is hidden but the page is still accessible. This patch checks the syspref and redirects to 404 if it is disabled. Test plan: Before applying the patch Enable OpacTopissue Observe there is a link to opac-topissues.pl next to Advanced search etc. Follow that link, observe that opac-topissues.pl is loading Disable OpacTopissue Observe the link is gone Manually open /koha/opac-topissues.pl and check that it is loading even though the feature is disabled Apply patch (OpacTopissue still diabled) Manually open /koha/opac-topissues.pl and observe that you are being redirected to the 404 page. Enable OpacTopissue Follow the link or manuall open opac-topissues.pl and check that it is working Signoff the patch. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Simple patch, works as expected. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19703|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19758&action=edit Bug 10595 - OpacTopissue page still accessible when system preference is turned off When the syspref is turned off, the link is hidden but the page is still accessible. This patch checks the syspref and redirects to 404 if it is disabled. Test plan: Before applying the patch Enable OpacTopissue Observe there is a link to opac-topissues.pl next to Advanced search etc. Follow that link, observe that opac-topissues.pl is loading Disable OpacTopissue Observe the link is gone Manually open /koha/opac-topissues.pl and check that it is loading even though the feature is disabled Apply patch (OpacTopissue still diabled) Manually open /koha/opac-topissues.pl and observe that you are being redirected to the 404 page. Enable OpacTopissue Follow the link or manuall open opac-topissues.pl and check that it is working Signoff the patch. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Mirko! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Mirko! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.11 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #8 from Chris Hall <chrish@catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.18 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org