[Bug 34522] New: Suggestion for purchase displays wrong branch in OPAC display if patron suggests for non-home branch code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 Bug ID: 34522 Summary: Suggestion for purchase displays wrong branch in OPAC display if patron suggests for non-home branch code Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: hebah@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Observed in 22.11 To recreate: Log into OPAC as patron of Branch A Make purchase suggestion for Branch B Refresh /cgi-bin/koha/opac-suggestions.pl and see that suggestion appears to have been made for Branch A View suggestion from staff client See that it accurately reflects suggestion having been made for Branch B This display is confusing (and inaccurate) for patrons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- The column that displays inaccurately is "Suggested for" which requires the system preference OPACViewOthersSuggestions to be turned on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 154393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154393&action=edit Bug 34522: Pass the suggestion branchcode, not the suggeter branchcode To test: 1. Turn on OPACViewOthersSuggestions 2. Log into OPAC as patron of Branch A 3. Make purchase suggestion for Branch B 4. Refresh /cgi-bin/koha/opac-suggestions.pl and see that suggestion appears to have been made for Branch A 5. View suggestion from staff client - See that it accurately reflects suggestion having been made for Branch B 6. Apply patch and try steps 2 - 5 again, this time you should see the proper branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com Version|22.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Testing this one right now! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154393|0 |1 is obsolete| | --- Comment #4 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 154496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154496&action=edit Bug 34522: Pass the suggestion branchcode, not the suggeter branchcode To test: 1. Turn on OPACViewOthersSuggestions 2. Log into OPAC as patron of Branch A 3. Make purchase suggestion for Branch B 4. Refresh /cgi-bin/koha/opac-suggestions.pl and see that suggestion appears to have been made for Branch A 5. View suggestion from staff client - See that it accurately reflects suggestion having been made for Branch B 6. Apply patch and try steps 2 - 5 again, this time you should see the proper branch. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Suggestion for purchase |Suggestion for purchase |displays wrong branch in |displays wrong library in |OPAC display if patron |OPAC display if patron |suggests for non-home |suggests for non-home |branch code |library --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If we could get another sign-off here, I could use mine for QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154496|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 154798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154798&action=edit Bug 34522: Pass the suggestion branchcode, not the suggeter branchcode To test: 1. Turn on OPACViewOthersSuggestions 2. Log into OPAC as patron of Branch A 3. Make purchase suggestion for Branch B 4. Refresh /cgi-bin/koha/opac-suggestions.pl and see that suggestion appears to have been made for Branch A 5. View suggestion from staff client - See that it accurately reflects suggestion having been made for Branch B 6. Apply patch and try steps 2 - 5 again, this time you should see the proper branch. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks David, switching this to PQA with my SO converted to QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.04 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.10 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34522 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org