[Bug 17682] New: Change URL for Google Scholar in OPACSearchForTitleIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Bug ID: 17682 Summary: Change URL for Google Scholar in OPACSearchForTitleIn Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: felix.hemme@thulb.uni-jena.de QA Contact: testopia@bugs.koha-community.org Google Scholar is no longer accessible via <a href="http://www.scholar.google.com/scholar?q={TITLE}" target="_blank">Google Scholar</a>. It should be changed to the current url <a href="https://scholar.google.com/scholar?q={TITLE}" target="_blank">Google Scholar</a>. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Felix Hemme <felix.hemme@thulb.uni-jena.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org Version|16.05 |master --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- This will require an update to the default system preferences SQL (variable OPACSearchForTitleIn), and probably a check during update for customized values. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Charlotte Cordwell <charlotte.cordwell123@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 --- Comment #2 from Charlotte Cordwell <charlotte.cordwell123@gmail.com> --- Created attachment 70545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70545&action=edit Bug 17682:Change URL for Google Scholar in OPACSearchForTitleIn 1)apply patch 2) go into administration --> search for OPACSearchForTitleIn 3) *click to edit* 4) look at the link and read the google scholar one. 5) check that the start link is https://scholar.google.com. 6) http://www.scholar.google is incorrect -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70545|0 |1 is obsolete| | --- Comment #3 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 70546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70546&action=edit Bug 17682:Change URL for Google Scholar in OPACSearchForTitleIn 1)apply patch 2) go into administration --> search for OPACSearchForTitleIn 3) *click to edit* 4) look at the link and read the google scholar one. 5) check that the start link is https://scholar.google.com. 6) http://www.scholar.google is incorrect Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |charlotte.cordwell123@gmail |ity.org |.com CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- I think the update needs to target only http://www.scholar.google.com Current code also updates bookfinder URL and breaks it (https seems to work, but requires keeping the 'www.') We can update both above links specifically so we don't hit any extra custom ones -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Charlotte Cordwell <charlotte.cordwell123@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 --- Comment #5 from Charlotte Cordwell <charlotte.cordwell123@gmail.com> --- Created attachment 70568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70568&action=edit Bug 17682: Change URL for Google Scholar in OPACSearchForTitleIn Amended the sql statement so it only affects the http://www.scholar.google.com url Current status: Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- This is ready for testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70546|0 |1 is obsolete| | Attachment #70568|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70738&action=edit Bug 17682:Change URL for Google Scholar in OPACSearchForTitleIn 1)apply patch 2) go into administration --> search for OPACSearchForTitleIn 3) *click to edit* 4) look at the link and read the google scholar one. 5) check that the start link is https://scholar.google.com. 6) http://www.scholar.google is incorrect Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70739&action=edit Bug 17682: Change URL for Google Scholar in OPACSearchForTitleIn Amended the sql statement so it only affects the http://www.scholar.google.com url Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Small change, SO and QA in one step -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70770&action=edit Bug 17682: Replace 2 occurrences in de-DE and nb-NO -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patches pushed to master for 18.05. Congratulations Charlotte for your first patches in! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17682 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.09 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org