http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10795 kenza <kenza.zaki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |10683 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10795 --- Comment #1 from kenza <kenza.zaki@biblibre.com> --- Created attachment 20690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20690&action=edit Bug 10795 - Improvements for GetOpenIssue in C4::Circulation This patch adds some improvements for the routine GetOpenIssue. Now, it verifies if the parameter is given (if not it returns undef) and it returns $sth->fetchrow_hashref() instead of a $issue. To test: prove t/db_dependent/Circulation_issue.t t/db_dependent/Circulation_issue.t .. ok All tests successful. Files=1, Tests=16, 2 wallclock secs ( 0.06 usr 0.01 sys + 1.09 cusr 0.07 csys = 1.23 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10795 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20690|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 20748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20748&action=edit [SIGNED-OFF] Bug 10795 - Improvements for GetOpenIssue in C4::Circulation This patch adds some improvements for the routine GetOpenIssue. Now, it verifies if the parameter is given (if not it returns undef) and it returns $sth->fetchrow_hashref() instead of a $issue. To test: prove t/db_dependent/Circulation_issue.t t/db_dependent/Circulation_issue.t .. ok All tests successful. Files=1, Tests=16, 2 wallclock secs ( 0.06 usr 0.01 sys + 1.09 cusr 0.07 csys = 1.23 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Same situation as the one noted in comment of Bug 10683, test fails unless there is an issuingrule All, All with 1 as renewals allowed. With that condition, it succeeds No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10795 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10795 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kenza! -- You are receiving this mail because: You are watching all bug changes.