[Bug 38339] New: Standard backend _get_core_fields are not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Bug ID: 38339 Summary: Standard backend _get_core_fields are not translatable Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: pedro.amorim@ptfs-europe.com, tomascohen@gmail.com Depends on: 35570 Following FIXME lines on ILL/Backend/Standard.pm: # FIXME: This should all be made translatable as is basically a # code => description mapping. The metadata() sub is using this # descriptions as keys. I thought this was a bug on this backend # but it turns out opac-illrequests.tt is using those descriptions # as keys. for example: # [% IF request.metadata.Author %][% request.metadata.Author | html %][% ELSE %]... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 [Bug 35570] Add a generic master form in ILL -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38340 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180155&action=edit Bug 38339: Preparation: Access value of attribute by its key, not by display label This ensures the value of the intended attribute is displayed, regardless of its translatable description -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180156&action=edit Bug 38339: Make core field descriptions translatable Test plan, before applying patches: 1) Enable ILLModule and create an ILL request (make sure it has an author and a title) 2) Install es-ES, on ktd run: koha-translate -i es-ES --dev kohadev 3) Access the OPAC ILL requests table: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl 4) Notice both the title and author show. 5) Back on the Staff UI, enable es-ES for OPACLanguages and enable opaclanguagesdisplay 6) Repeat 3). Notice: - The title and author column headers are not translated to es-ES - The title and author data values are not displayed on the columns 7) Apply patches, restart plack and update es-ES installation: - koha-plack --restart kohadev - koha-translate --update es-ES --dev kohadev 8) Repeat 3). Notice the column headers are translated and the data is shown. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180155|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180176&action=edit Bug 38339: Preparation: Access value of attribute by its key, not by display label This ensures the value of the intended attribute is displayed, regardless of its translatable description -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180156|0 |1 is obsolete| | --- Comment #4 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 180177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180177&action=edit Bug 38339: Make core field descriptions translatable Test plan, before applying patches: 1) Enable ILLModule and create an ILL request (make sure it has an author and a title) 2) Install es-ES, on ktd run: koha-translate -i es-ES --dev kohadev 3) Access the ILL request on the OPAC: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=view&illrequest_id=1 4) Activate es-ES language from the footer. Notice 'Title' and 'Author' still show as english 5) Apply patches. restart plack and update translation koha-plack --restart kohadev koha-translate --update es-ES --dev kohadev 6) Repeat 3). Notice those labels are now translated. 7) Ensure the table renders correctly and displays the data author and title data: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180177|0 |1 is obsolete| | --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- Created attachment 180529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180529&action=edit Bug 38339: Make core field descriptions translatable Test plan, before applying patches: 1) Enable ILLModule and create an ILL request (make sure it has an author and a title) 2) Install es-ES, on ktd run: koha-translate -i es-ES --dev kohadev 3) Access the ILL request on the OPAC: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=view&illrequest_id=1 4) Activate es-ES language from the footer. Notice 'Title' and 'Author' still show as english 5) Apply patches. restart plack and update translation koha-plack --restart kohadev koha-translate --update es-ES --dev kohadev 6) Repeat 3). Notice those labels are now translated. 7) Ensure the table renders correctly and displays the data author and title data: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl Signed-off-by: Magnus Enger <magnus@libriotech.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Marking this as duplicate of bug 39600 as the work done there implicitly fixes the issue described here. *** This bug has been marked as a duplicate of bug 39600 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|35570 |39600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 [Bug 35570] Add a generic master form in ILL https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 [Bug 39600] Paginate (and modernize) OPAC ILL requests table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Reopening this and leaving just the i18n patch, making it depend on bug 39600 for the reasons stated above. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180176|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180529|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 181136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181136&action=edit Bug 38339: Make core field descriptions translatable Test plan, before applying patches: 1) Enable ILLModule and create an ILL request (make sure it has an author and a title) 2) Install es-ES, on ktd run: koha-translate -i es-ES --dev kohadev 3) Access the ILL request on the OPAC: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?op=view&illrequest_id=1 4) Activate es-ES language from the footer. Notice 'Title' and 'Author' still show as english 5) Apply patches. restart plack and update translation koha-plack --restart kohadev koha-translate --update es-ES --dev kohadev 6) Repeat 3). Notice those labels are now translated. 7) Ensure the table renders correctly and displays the data author and title data: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl Signed-off-by: Magnus Enger <magnus@libriotech.no> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38340 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38340 [Bug 38340] Translatability - Standard form include files are not translatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|39600 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39600 [Bug 39600] Use the API to render the OPAC ILL requests table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is this not breaking this line in the OPAC? <td> [% IF request.metadata.Author %][% request.metadata.Author | html %][% ELSE %]<span>N/A</span>[% END %] </td> If we translate Author? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tomas says this is fixed later on, so adding "additional_work_needed" as a reminder to check back on this once we got through the tree. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39444 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39444 [Bug 39444] Standard form does not consider PubMed ID -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #9)
Is this not breaking this line in the OPAC?
<td> [% IF request.metadata.Author %][% request.metadata.Author | html %][% ELSE %]<span>N/A</span>[% END %] </td>
If we translate Author?
The line in question doesn't appear to exist anymore. Assuming fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not impact 24.11.x since other linked bugs are not backported -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38339 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |aude.charillon@openfifth.co | |.uk --- Comment #14 from Aude Charillon <aude.charillon@openfifth.co.uk> --- No need for any updates to the Manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org