[Bug 22139] New: Fields ACCTDETAILS not working properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Bug ID: 22139 Summary: Fields ACCTDETAILS not working properly Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: muneebkalathil@yahoo.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Some of the fields in ACCTDETAILS is not working properly when we create new patrons. There is no problem in receiving mails. The only field it takes is <<borrowers.password>> The remaining fields in this notice does not showing any values in the mail. <<borrowers.title>> <<borrowers.firstname>> <<borrowers.surname>> <<borrowers.userid>> ##################################### This is the mail I recieved. Hello . Your new Koha account details are: User: Password: 1234 If you have any problems or questions regarding your account, please contact your Koha Administrator. Thank you, Librarian library@xxxx ##################################### * Checkout notice is working fine with ACCTDETAILS details. * Also I imported this DB to 18.05 and it is working perfectly; No issues . * Didn't find any errors in log related to this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Muneeb Kalathil <muneebkalathil@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fields ACCTDETAILS not |Fields of ACCTDETAILS not |working properly |working properly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Muneeb Kalathil <muneebkalathil@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |normal --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
#####################################
* Checkout notice is working fine with ACCTDETAILS details. * Also I imported this DB to 18.05 and it is working perfectly; No issues . * Didn't find any errors in log related to this.
Do you mean it's a regression from 18.05 to 18.11? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens@lancasterseminar | |y.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton@bywatersolutions.com --- Comment #2 from Barton Chittenden <barton@bywatersolutions.com> --- Can confirm; we just had a partner upgrade from 18.05 to 18.11. Was working in 18.05, is not working now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 --- Comment #3 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- We are said partner. As a workaround, we're planning to rewrite the notice so that it is more generic and doesn't use the remaining fields from the borrowers table. It is odd, however, that the notice does pass through borrowers.password but not the others. Thanks for taking a look at this! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 --- Comment #4 from Muneeb Kalathil <muneebkalathil@yahoo.com> --- (In reply to Katrin Fischer from comment #1)
#####################################
* Checkout notice is working fine with ACCTDETAILS details. * Also I imported this DB to 18.05 and it is working perfectly; No issues . * Didn't find any errors in log related to this.
Do you mean it's a regression from 18.05 to 18.11?
New Installation on 18.11 - Not working DB from 18.11 to 18.05 - Its working -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 --- Comment #5 from Lisette Scheer <lisetteslatah@gmail.com> --- We are also having this issue. We are using TT syntax in this notice and it was working yesterday but not today for borrower information. It does work still for branch information. We updated to 18.11.03 overnight. Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Kris Sinnaeve <kris.sinnaeve@etf.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kris.sinnaeve@etf.edu --- Comment #6 from Kris Sinnaeve <kris.sinnaeve@etf.edu> --- Created attachment 88207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88207&action=edit Patch file to fix this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 --- Comment #7 from Kris Sinnaeve <kris.sinnaeve@etf.edu> --- This bug is indeed introduced between Koha 18.05 and Koha 18.11 when moving AddMember and ModMember from Members to Patron. I expect it's fixed by adding the following line after storing the new patron: $newdata{'borrowernumber'} = $borrowernumber; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88207|0 |1 is obsolete| | --- Comment #8 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88216&action=edit Bug 22139: Fields of ACCTDETAILS email not populating To test: * Make sure AutoEmailOpacUser is set to "send" * Create a new patron with a username and password, and an email address * In Kohadevbox, check the mail (usually you can type "mail" and go down to the last message) - these do not go into the message queue and they are processed immediately. notice that the email does not have <<borrowers.title>> <<borrowers.firstname>> <<borrowers.surname>> Apply this patch, restart the things, retest as above. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #9 from Liz Rea <wizzyrea@gmail.com> --- Formatting patch for community guidelines, authorship retained by Kris. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88216|0 |1 is obsolete| | --- Comment #10 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 88245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88245&action=edit Bug 22139: Fields of ACCTDETAILS email not populating To test: * Make sure AutoEmailOpacUser is set to "send" * Create a new patron with a username and password, and an email address * In Kohadevbox, check the mail (usually you can type "mail" and go down to the last message) - these do not go into the message queue and they are processed immediately. notice that the email does not have <<borrowers.title>> <<borrowers.firstname>> <<borrowers.surname>> Apply this patch, restart the things, retest as above. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88245|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88257&action=edit Bug 22139: Fields of ACCTDETAILS email not populating To test: * Make sure AutoEmailOpacUser is set to "send" * Create a new patron with a username and password, and an email address * In Kohadevbox, check the mail (usually you can type "mail" and go down to the last message) - these do not go into the message queue and they are processed immediately. notice that the email does not have <<borrowers.title>> <<borrowers.firstname>> <<borrowers.surname>> Apply this patch, restart the things, retest as above. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Perfect fix, thankyou very much for fixing it before I got down to it in my todo list :) Passing QA and welcome to the team :). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Assignee|koha-bugs@lists.koha-commun |muneebkalathil@yahoo.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 --- Comment #13 from Kris Sinnaeve <kris.sinnaeve@etf.edu> --- For me it was a show stopper to migrate from Koha 3.20 to Koha 18.11. It took me some time to find the root cause. A diff between the Koha 18.05 version of memberentry.pl and the Koha 18.11 version of memberentry.pl pointed me into the right direction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.05 released in| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- not backporting to 18.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- not backporting to 18.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22139 --- Comment #18 from Aman Mishra <aman.mishra77@gmail.com> --- Comment on attachment 88207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88207 Patch file to fix this bug. Review of attachment 88207: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22139&attachment=88207) ----------------------------------------------------------------- Thanks this patch is working fine -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org