[Bug 26406] New: Suggestions filter does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26406 Bug ID: 26406 Summary: Suggestions filter does not work Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org The suggestions filter at the OPAC does not work at all. There is an input box but it does nothing https://snipboard.io/tsGM8h.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26406 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26406 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 109748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109748&action=edit Bug 26406: Fix suggestions filter at the OPAC There is an input filter but it does nothing Test plan: You need 2 differents users, U1 and U2 Create several (at least one) suggestions for each of them Test the following with and without OPACViewOthersSuggestions: With U1 logged in, go to the suggestions tab and use the input to filter the suggestions. It should work correctly. Also play with the "Suggested by" options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26406 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26406 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109748|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 109762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109762&action=edit Bug 26406: Fix suggestions filter at the OPAC There is an input filter but it does nothing Test plan: You need 2 differents users, U1 and U2 Create several (at least one) suggestions for each of them Test the following with and without OPACViewOthersSuggestions: With U1 logged in, go to the suggestions tab and use the input to filter the suggestions. It should work correctly. Also play with the "Suggested by" options Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26406 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Signed Off |Patch doesn't apply --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Patch doesn't apply because of bug 20168 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26406 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26406 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109762|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116630&action=edit Bug 26406: Fix suggestions filter at the OPAC There is an input filter but it does nothing Test plan: You need 2 differents users, U1 and U2 Create several (at least one) suggestions for each of them Test the following with and without OPACViewOthersSuggestions: With U1 logged in, go to the suggestions tab and use the input to filter the suggestions. It should work correctly. Also play with the "Suggested by" options Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26406 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I completely forgot about this patch and, meanwhile, I wrote bug 27047. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26406 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27047 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27047 [Bug 27047] Purchase suggestions search filter is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26406 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Do we still need this patch? The search box on the opac suggestions page seems to work now ? Changing status to reflect need for feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26406 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yes, I think it is. You can filter server-side, better than the DT global filter IMO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26406 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26406 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116630|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116862&action=edit Bug 26406: Fix suggestions filter at the OPAC There is an input filter but it does nothing Test plan: You need 2 differents users, U1 and U2 Create several (at least one) suggestions for each of them Test the following with and without OPACViewOthersSuggestions: With U1 logged in, go to the suggestions tab and use the input to filter the suggestions. It should work correctly. Also play with the "Suggested by" options Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26406 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26406 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26406 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.03 released in| | --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26406 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency from bug 27047, which needs a rebase. Please rebase that for backport if this is needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org