[Bug 19913] New: Embedded HTML5 videos are broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 Bug ID: 19913 Summary: Embedded HTML5 videos are broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 18754 The video element is badly generated. Caused by commit 752aef4593f1aa2d64700bf9738e7e03907eb1cd Bug 18754: Translatability: Get rid of exposed tt directives in opac-detail.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18754 [Bug 18754] Translatability: Get rid of exposed tt directives in opac-detail.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70255&action=edit Bug 19913: Fix embedded HTML5 videos at the OPAC Caused by commit 752aef4593f1aa2d64700bf9738e7e03907eb1cd Bug 18754: Translatability: Get rid of exposed tt directives in opac-detail.tt A space is missing between 'source' and 'src' Test plan: Set HTML5MediaEnabled to OPAC Put a video link to 856$u See the OPAC detail page, tab video, click the video => Should play with this patch applied Note that this does not affect intranet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by George <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70255|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 70333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70333&action=edit Bug 19913: Fix embedded HTML5 videos at the OPAC Caused by commit 752aef4593f1aa2d64700bf9738e7e03907eb1cd Bug 18754: Translatability: Get rid of exposed tt directives in opac-detail.tt A space is missing between 'source' and 'src' Test plan: Set HTML5MediaEnabled to OPAC Put a video link to 856$u See the OPAC detail page, tab video, click the video => Should play with this patch applied Note that this does not affect intranet Signed-off-by: George <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70333|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 70334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70334&action=edit Bug 19913: Fix embedded HTML5 videos at the OPAC Caused by commit 752aef4593f1aa2d64700bf9738e7e03907eb1cd Bug 18754: Translatability: Get rid of exposed tt directives in opac-detail.tt A space is missing between 'source' and 'src' Test plan: Set HTML5MediaEnabled to OPAC Put a video link to 856$u See the OPAC detail page, tab video, click the video => Should play with this patch applied Note that this does not affect intranet Signed-off-by: George <george@nekls.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to sandboxes@biblibre.com from comment #2)
Patch tested with a sandbox, by George <george@nekls.org>
George, I have modified your signed-off-by line to add your surname. I hope it is ok with you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 --- Comment #7 from George Williams (NEKLS) <george@nekls.org> --- (In reply to Jonathan Druart from comment #5)
(In reply to sandboxes@biblibre.com from comment #2)
Patch tested with a sandbox, by George <george@nekls.org>
George, I have modified your signed-off-by line to add your surname. I hope it is ok with you.
Jonathan - not a problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 Bug 19913 depends on bug 18754, which changed state. Bug 18754 Summary: Translatability: Get rid of exposed tt directives in opac-detail.tt https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18754 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org