[Bug 20649] New: C4::Auth should use C4::Context->IsSuperLibrarian()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20649 Bug ID: 20649 Summary: C4::Auth should use C4::Context->IsSuperLibrarian() Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org Depends on: 20479 We had a lot of trouble with superlibrarian checks in the past, which is why we introduced C4::Context->IsSuperLibrarian(). C4::Auth should use it instead of: 06 && $flags && $flags->{superlibrarian} != 1 http://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=C4/Auth.pm;h=e... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20479 [Bug 20479] Superlibrarians cannot log into opac -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20649 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20649 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Probably here too, noting that on bug 20515: 297 if ( $flags && $flags->{superlibrarian} == 1 ) { 298 $template->param( CAN_user_circulate => 1 ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20649 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart@bugs.koha-c | |ommunity.org Resolution|--- |INVALID --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- No, C4::Context->IsSuperlibrarian tells if the logged in user has the superlibrarian flags. In C4::Auth::get_template_and_user the user is not logged in yet. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20649 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Actually yes, userenv is set in checkauth which has been called few lines above. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20649 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20649 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, Jonathan, I don't understand yet. Maybe we can take a look at it together sometime? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20649 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #4)
Sorry, Jonathan, I don't understand yet. Maybe we can take a look at it together sometime?
Scratch comment 2, we could replace it instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org