[Bug 18061] New: Enhance items page (moredetail.pl) with Bootstrap 3 panels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18061 Bug ID: 18061 Summary: Enhance items page (moredetail.pl) with Bootstrap 3 panels Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18061 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16239 Assignee|oleonard@myacpl.org |josef.moravec@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 [Bug 16239] Upgrade Bootstrap in the staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18061 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18061 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 59919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59919&action=edit Bug 18061: Restyle catalogue moredetail page Test plan: 0) apply the patch 1) go to items page on any of catalogue record (catalogue/moredetail.pl) 2) confirm the new fancy bootstrap panels and the basic biblio information in table 3) login with user with cataloguing perrmisions and tryy to edit item, change statuses, add/update notes, it should all work as before patch 4) login with user withou cataloguing permission - you should not see the edit links and form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18061 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18061 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18061 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59919|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 60005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60005&action=edit Bug 18061: Restyle catalogue moredetail page Test plan: 0) apply the patch 1) go to items page on any of catalogue record (catalogue/moredetail.pl) 2) confirm the new fancy bootstrap panels and the basic biblio information in table 3) login with user with cataloguing perrmisions and tryy to edit item, change statuses, add/update notes, it should all work as before patch 4) login with user withou cataloguing permission - you should not see the edit links and form Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18061 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |oleonard@myacpl.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sounds good to me, but I'd like more signoff on this one. Owen maybe? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18061 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18061 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- If I were approaching this interface and thinking to myself that it needed to be improved, I'd ask myself some questions: 1. What are the problems with it the way it is? Is it not readable enough? Are the controls not usable in some way. 2. Based on the problems identified in step 1, what are some ways to directly address them? 3. If this interface follows a pattern which is used in other areas of Koha can we easily apply the new style to those places? If not, can we find a way to adjust the new version to be more universal? I don't find this to be more readable. It also doesn't handle a smaller browser window size very nicely. I feel like this is a change for change's sake rather than a change which accomplishes a goal. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18061 Sarah Kirby <sarahkirby@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sarahkirby@catalyst.net.nz Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Sarah Kirby <sarahkirby@catalyst.net.nz> --- Bug 18061 - Enhance items page (moredetail.pl) with Bootstrap 3 panels 60005 - Bug 18061: Restyle catalogue moredetail page Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 18061: Restyle catalogue moredetail page Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/css/staff-global.css M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/staff-global.css Failed to merge in the changes. Patch failed at 0001 Bug 18061: Restyle catalogue moredetail page The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-18061-Restyle-catalogue-moredetail-page-ctght0.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18061 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21948 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18061 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Patch doesn't apply |RESOLVED --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This no longer applies and the original author is no longer active in the Koha community. Given Owen's veto in comment#4 I am going to mark this as WONTFIX. Please reopen if you disagree! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org