[Bug 6294] New: Add {BIBLIONUMBER} parsing support to SearchForTitleIn syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6294 Bug #: 6294 Summary: Add {BIBLIONUMBER} parsing support to SearchForTitleIn syspref Classification: Unclassified Change sponsored?: Sponsored Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: ian.walls@bywatersolutions.com ReportedBy: ian.walls@bywatersolutions.com QAContact: koha-bugs@lists.koha-community.org By adding parsing support for {BIBLIONUMBER} to the SearchForTitleIn system preference, we can enable support for APIs (like Facebook, Twitter, etc) that could point back to the items detail page for a title. Example code to put into SearchForTitleIn (place after </ul> that comes with default): </div></div><div class="detailtagcell"> <script src="http://connect.facebook.net/en_US/all.js#xfbml=1"></script><fb:like href="http://opac.mylibrary.tld/bib/{BIBLIONUMBER}" show_faces="true" width="450" font=""></fb:like> <div><a href="http://twitter.com/share" class="twitter-share-button" data-url="http://opac.mylibrary.tld/bib/{BIBLIONUMBER}" data-text="I'm reading this" data-count="horizontal">Tweet</a><script type="text/javascript" src="http://platform.twitter.com/widgets.js"></script></div></div><div><div><ul> Replace "http://opac.mylibrary.tld" with your OPAC base URL, and for Twitter, adjust the data-text attribute to whatever you like (you can parse in {TITLE} and {AUTHOR}, but beware character limits!) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6294 --- Comment #1 from Ian Walls <ian.walls@bywatersolutions.com> 2011-05-03 15:40:46 UTC --- Whoops, my mistake... </ul> must be added to make this work: Revised sample code: </ul></div></div><div class="detailtagcell"> <script src="http://connect.facebook.net/en_US/all.js#xfbml=1"></script><fb:like href="http://opac.mylibrary.tld/bib/{BIBLIONUMBER}" show_faces="true" width="450" font=""></fb:like> <div><a href="http://twitter.com/share" class="twitter-share-button" data-url="http://opac.mylibrary.tld/bib/{BIBLIONUMBER}" data-text="I'm reading this" data-count="horizontal">Tweet</a><script type="text/javascript" src="http://platform.twitter.com/widgets.js"></script></div></div><div><div><ul> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6294 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |nengard@gmail.com Patch Status|--- |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6294 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-05-03 15:48:40 UTC --- Created attachment 4032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4032 signed off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6294 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch Status|Signed Off |Passed QA --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2011-05-06 19:46:34 UTC --- Patch itself passes QA. Particular applications, like Facebook 'like' links and such may still require refinement, but are outside the immediate scope of this enhancement (which is just the parsing of {BIBLIONUMBER}). Tested with NULL and incorrect biblionumber values in the URL; 404 page returns as expected. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6294 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-05-07 07:38:02 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6294 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2011-05-17 16:17:00 UTC --- opac-MARCdetail.pl and opac-ISBDdetail also need a fix. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6294 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-05-23 20:32:15 UTC --- I tried- but I need more than copy paste to make it work - so it's on Ian to update. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6294 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This appears to be working. Closing. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org