[Bug 27595] New: Placing Patrons on Hold for Accepted Purchase Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Bug ID: 27595 Summary: Placing Patrons on Hold for Accepted Purchase Suggestions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Currently, Koha does alert a patron when a purchase suggestion has been ordered and also when it is available in Koha. But it would be nice to have a further enhancement to this process and place a hold for the patron on the record once it has been accepted. This is an extra step for libraries, and it would streamline the library's process for this to be done automatically. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Placing Patrons on Hold for |Place holds for patrons on |Accepted Purchase |accepted purchase |Suggestions |suggestions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- +1 on this -- this is a really common request when training new Koha users! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber@cityoffargo.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Amanda Campbell <acampbell@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell@hmcpl.org --- Comment #2 from Amanda Campbell <acampbell@hmcpl.org> --- Yes, we would be interested in this. Manually placing holds is very tedious and time consuming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 29039 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #4 from Christopher Brannon <cbrannon@cdalibrary.org> --- +1 This would be a fantastic and much needed feature! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Mwoo <mary.woodward@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mary.woodward@bedfordtx.gov --- Comment #5 from Mwoo <mary.woodward@bedfordtx.gov> --- Patrons ask us about this all the time. This would be an awesome feature. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 --- Comment #6 from Ashley Johnson <ajohnson@jcls.org> --- Our Collection Development team processes hundreds of patron suggestions each month. This feature would be highly important to our library system. Please develop this feature!!! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #7 from George Williams (NEKLS) <george@nekls.org> --- This would be a great feature to add to Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Felicity Brown <felicity.brown@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felicity.brown@montgomeryco | |untymd.gov --- Comment #8 from Felicity Brown <felicity.brown@montgomerycountymd.gov> --- This would be an awesome feature, especially if we could somehow get it to work with EDI ordering, not just title by title purchasing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Ashley Johnson <ajohnson@jcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ajohnson@jcls.org --- Comment #9 from Ashley Johnson <ajohnson@jcls.org> --- We would definitely be in on helping fund this enhancement. We do a TON of patron suggestions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Kim Gnerre <kgnerre@hotchkiss.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kgnerre@hotchkiss.org --- Comment #10 from Kim Gnerre <kgnerre@hotchkiss.org> --- We are interested in this enhancement. We frequently have people make suggestions and want the book when it's been ordered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We have discovered something similar for acquisition orders the other day and kept wondering how this could work. A suggestion might not be linked to a bibliographic record when it's accepted. So would this be limited to suggestions on existing records or for suggestions, that are also handled through acquisitions? Maybe it would be nice to be able to manually link a suggestion to a bibliographic record? This could make it easier to add this enhancement on top. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28844 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31617 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31617 [Bug 31617] Allow manual editing of suggestions.biblionumber -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 --- Comment #12 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> ---
Maybe it would be nice to be able to manually link a suggestion to a bibliographic record? This could make it easier to add this enhancement on top.
Strong agree! I filed bug 31617 for this. We already have the database field for it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19358 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 vstever@myokaloosa.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vstever@myokaloosa.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Kris <kbecker@jcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kbecker@jcls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org --- Comment #13 from carthur@slolibrary.org <carthur@slolibrary.org> --- Hi, We're [SLO County Libraries] also interested in having this feature added to the Suggest a Title module. Thank you, Charlie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 159524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159524&action=edit Bug 27595: Add new system preference PlaceHoldsOnOrdersFromSuggestions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 159525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159525&action=edit Bug 27595: Add place_hold method to Koha::Suggestion This patch adds anew method to allow placing a hold from a purchase suggestion To test: prove -v t/db_dependent/Suggestions.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 159526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159526&action=edit Bug 27595: Place holds when ordering from a suggestion This patch updates the ordering code to place a hold when adding to a basket from a suggestion if the new preference PlaceHoldsOnOrdersFromSuggestions is enabled. To test: 1 - Apply all patches 2 - updatedatabase 3 - See new system preference PlaceHoldsOnOrdersFromSuggestions 4 - Create a new purchase suggestion, mark it accepted 5 - Go to acquisitions, find a vendor, find a basket, 'Add to basket' -> 'From a suggestion' 6 - Complete order, confirm no hold was placed 7 - Enable the new system preference 8 - Repeast 4-6 9 - Confirm a hold was placed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159524|0 |1 is obsolete| | --- Comment #17 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 159533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159533&action=edit Bug 27595: Add new system preference PlaceHoldsOnOrdersFromSuggestions Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159525|0 |1 is obsolete| | --- Comment #18 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 159534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159534&action=edit Bug 27595: Add place_hold method to Koha::Suggestion This patch adds anew method to allow placing a hold from a purchase suggestion To test: prove -v t/db_dependent/Suggestions.t Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159526|0 |1 is obsolete| | --- Comment #19 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 159535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159535&action=edit Bug 27595: Place holds when ordering from a suggestion This patch updates the ordering code to place a hold when adding to a basket from a suggestion if the new preference PlaceHoldsOnOrdersFromSuggestions is enabled. To test: 1 - Apply all patches 2 - updatedatabase 3 - See new system preference PlaceHoldsOnOrdersFromSuggestions 4 - Create a new purchase suggestion, mark it accepted 5 - Go to acquisitions, find a vendor, find a basket, 'Add to basket' -> 'From a suggestion' 6 - Complete order, confirm no hold was placed 7 - Enable the new system preference 8 - Repeast 4-6 9 - Confirm a hold was placed Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #20 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- I want to note here that this feature will create holds that would not otherwise be allowed. It'll put holds on bibs without items and on bibs where all items are of an unholdable item type. I guess that shouldn't be an issue, since staff are purposefully ordering the title, but I wanted to make sure it was explicitly acknowledged. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159533|0 |1 is obsolete| | --- Comment #21 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 159537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159537&action=edit Bug 27595: Add new system preference PlaceHoldsOnOrdersFromSuggestions Signed-off-by: Kelly <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159534|0 |1 is obsolete| | --- Comment #22 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 159538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159538&action=edit Bug 27595: Add place_hold method to Koha::Suggestion This patch adds anew method to allow placing a hold from a purchase suggestion To test: prove -v t/db_dependent/Suggestions.t Signed-off-by: Kelly <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159535|0 |1 is obsolete| | --- Comment #23 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 159539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159539&action=edit Bug 27595: Place holds when ordering from a suggestion This patch updates the ordering code to place a hold when adding to a basket from a suggestion if the new preference PlaceHoldsOnOrdersFromSuggestions is enabled. To test: 1 - Apply all patches 2 - updatedatabase 3 - See new system preference PlaceHoldsOnOrdersFromSuggestions 4 - Create a new purchase suggestion, mark it accepted 5 - Go to acquisitions, find a vendor, find a basket, 'Add to basket' -> 'From a suggestion' 6 - Complete order, confirm no hold was placed 7 - Enable the new system preference 8 - Repeast 4-6 9 - Confirm a hold was placed Signed-off-by: Kelly <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159537|0 |1 is obsolete| | --- Comment #24 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 159540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159540&action=edit Bug 27595: Add new system preference PlaceHoldsOnOrdersFromSuggestions Signed-off-by: Kelly <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159538|0 |1 is obsolete| | --- Comment #25 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 159541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159541&action=edit Bug 27595: Add place_hold method to Koha::Suggestion This patch adds anew method to allow placing a hold from a purchase suggestion To test: prove -v t/db_dependent/Suggestions.t Signed-off-by: Kelly <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159539|0 |1 is obsolete| | --- Comment #26 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 159542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159542&action=edit Bug 27595: Place holds when ordering from a suggestion This patch updates the ordering code to place a hold when adding to a basket from a suggestion if the new preference PlaceHoldsOnOrdersFromSuggestions is enabled. To test: 1 - Apply all patches 2 - updatedatabase 3 - See new system preference PlaceHoldsOnOrdersFromSuggestions 4 - Create a new purchase suggestion, mark it accepted 5 - Go to acquisitions, find a vendor, find a basket, 'Add to basket' -> 'From a suggestion' 6 - Complete order, confirm no hold was placed 7 - Enable the new system preference 8 - Repeast 4-6 9 - Confirm a hold was placed Signed-off-by: Kelly <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159540|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159786&action=edit Bug 27595: Add new system preference PlaceHoldsOnOrdersFromSuggestions Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159541|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159787&action=edit Bug 27595: Add place_hold method to Koha::Suggestion This patch adds anew method to allow placing a hold from a purchase suggestion To test: prove -v t/db_dependent/Suggestions.t Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159542|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159788&action=edit Bug 27595: Place holds when ordering from a suggestion This patch updates the ordering code to place a hold when adding to a basket from a suggestion if the new preference PlaceHoldsOnOrdersFromSuggestions is enabled. To test: 1 - Apply all patches 2 - updatedatabase 3 - See new system preference PlaceHoldsOnOrdersFromSuggestions 4 - Create a new purchase suggestion, mark it accepted 5 - Go to acquisitions, find a vendor, find a basket, 'Add to basket' -> 'From a suggestion' 6 - Complete order, confirm no hold was placed 7 - Enable the new system preference 8 - Repeast 4-6 9 - Confirm a hold was placed Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All working well and no regressions, QA scripts happy. Great addition, thanks Nick Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31617 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31617 [Bug 31617] Allow manual editing of suggestions.biblionumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Dave <ddaghita@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ddaghita@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch no longer applies and I'd prefer a rebase by the author. With the new list on the dashboard this should come right back up in the queue. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27595: Add new system preference PlaceHoldsOnOrdersFromSuggestions Using index info to reconstruct a base tree... M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql Applying: Bug 27595: Add place_hold method to Koha::Suggestion Applying: Bug 27595: Place holds when ordering from a suggestion Using index info to reconstruct a base tree... M acqui/addorder.pl Falling back to patching base and 3-way merge... Auto-merging acqui/addorder.pl CONFLICT (content): Merge conflict in acqui/addorder.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 27595: Place holds when ordering from a suggestion hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-27595-Place-holds-when-ordering-from-a-suggest-4__rodz_.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159786|0 |1 is obsolete| | --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163331&action=edit Bug 27595: Add new system preference PlaceHoldsOnOrdersFromSuggestions Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159787|0 |1 is obsolete| | --- Comment #33 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163332&action=edit Bug 27595: Add place_hold method to Koha::Suggestion This patch adds anew method to allow placing a hold from a purchase suggestion To test: prove -v t/db_dependent/Suggestions.t Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159788|0 |1 is obsolete| | --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 163333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163333&action=edit Bug 27595: Place holds when ordering from a suggestion This patch updates the ordering code to place a hold when adding to a basket from a suggestion if the new preference PlaceHoldsOnOrdersFromSuggestions is enabled. To test: 1 - Apply all patches 2 - updatedatabase 3 - See new system preference PlaceHoldsOnOrdersFromSuggestions 4 - Create a new purchase suggestion, mark it accepted 5 - Go to acquisitions, find a vendor, find a basket, 'Add to basket' -> 'From a suggestion' 6 - Complete order, confirm no hold was placed 7 - Enable the new system preference 8 - Repeast 4-6 9 - Confirm a hold was placed Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Back on this one, thanks for the rebase, Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Keywords| |release-notes-needed Status|Pushed to master |Needs documenting --- Comment #37 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de --- Comment #38 from Philip Orr <philip.orr@lmscloud.de> --- Hmm, I was just documenting this and noticed that the new syspref is in the Subgroup "Printing" of the Acquisitions system preferences. Why "Printing"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Philip Orr contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Philip Orr from comment #38)
Hmm, I was just documenting this and noticed that the new syspref is in the Subgroup "Printing" of the Acquisitions system preferences. Why "Printing"?
That does indeed seem odd... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #39)
(In reply to Philip Orr from comment #38)
Hmm, I was just documenting this and noticed that the new syspref is in the Subgroup "Printing" of the Acquisitions system preferences. Why "Printing"?
That does indeed seem odd...
Could you please file a bug to move into a better spot? We are in string frezee bug can fix that for .01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 --- Comment #41 from Philip Orr <philip.orr@lmscloud.de> --- Done! Bug 36936: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36926 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks! Can I also squeeze for your some release notes? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 --- Comment #43 from Philip Orr <philip.orr@lmscloud.de> --- Sure thing, but it will be first thing tomorrow morning, I'm busy with other things rest of the day today :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Philip Orr from comment #43)
Sure thing, but it will be first thing tomorrow morning, I'm busy with other things rest of the day today :)
This week is fine - thanks!! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This patch adds a new release notes| |system preference | |“PlaceHoldsOnOrdersFromSugg | |estions” that allows | |accepted suggestions to | |automatically be put on | |hold for the suggesting | |patron as soon as the | |suggested item is ordered. | | | |The default value is | |“Don't” automatically place | |a hold when ordering from a | |suggestion. | | | |**Sponsored | |by** *Bedford Public | |Library* | |**Sponsored by** | |*Altadena Library District* | |**Sponsored by** *St. | |Paul's School* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 --- Comment #45 from Kim Gnerre <kgnerre@hotchkiss.org> --- Will this be available in the upcoming 24.05 upgrade? I have an acquisitions person who is anxious to use it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kim Gnerre from comment #45)
Will this be available in the upcoming 24.05 upgrade? I have an acquisitions person who is anxious to use it.
You can always see the versions a feature is included in in the "Version(s) released in:" in the right column on the left. This was first release din 24.05.00, so will be included. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 --- Comment #47 from Kim Gnerre <kgnerre@hotchkiss.org> --- Thank you! I completely missed that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation|Philip Orr |Aude Charillon contact| | CC| |aude.charillon@openfifth.co | |.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1090 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27595 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #48 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Added to the Koha Manual. Special documentation thanks to Andrew Fuerste-Henry for his comment alerting to the fact this feature can create holds that are not otherwise allowed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org