[Bug 16205] New: MARC editor settings menu should use a Font Awesome icon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16205 Bug ID: 16205 Summary: MARC editor settings menu should use a Font Awesome icon Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/cataloguing/addbiblio.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: brendan@bywatersolutions.com, hector.hecaxmmx@gmail.com, m.de.rooy@rijksmuseum.nl, testopia@bugs.koha-community.org Depends on: 15859 The new MARC editor settings menu uses a Glyphicon. It should use a Font Awesome icon instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15859 [Bug 15859] Move some basic MARC editor controls into settings menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16205 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16205 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49921&action=edit Bug 16205 - MARC editor settings menu should use a Font Awesome icon When I added the MARC editor settings menu in Bug 15859 I accidentally used a Glyphicon. This patch corrects it to use a Font Awesome icon. To test, apply the patch and open the basic cataloging editor. The "Settings" menu should use a Font Awesome icon instead of a Glyphicon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16205 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49921|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 49922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49922&action=edit Bug 16205: MARC editor settings menu should use a Font Awesome icon When I added the MARC editor settings menu in Bug 15859 I accidentally used a Glyphicon. This patch corrects it to use a Font Awesome icon. To test, apply the patch and open the basic cataloging editor. The "Settings" menu should use a Font Awesome icon instead of a Glyphicon. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Icon changed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16205 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16205 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16205 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49923&action=edit Bug 16205 - MARC editor settings menu should use a Font Awesome icon When I added the MARC editor settings menu in Bug 15859 I accidentally used a Glyphicon. This patch corrects it to use a Font Awesome icon. To test, apply the patch and open the basic cataloging editor. The "Settings" menu should use a Font Awesome icon instead of a Glyphicon. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Icons changed Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> Works as expected, no qa errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16205 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49922|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16205 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org