[Bug 17946] New: Show number of subscriptions on tab in OPAC record details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 Bug ID: 17946 Summary: Show number of subscriptions on tab in OPAC record details Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org The OPAC detail page for a biblio shows the number Items, Holdings etc in brackets after the tab title (like 'Holdings ( 1 )'), it should do the same for subscriptions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 59288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59288&action=edit Bug 17946: Show number of subscriptions on tab in OPAC record details To test: 1) Edit at least one subscription (or add a new one) to have a record 2) Find that record on the OPAC 3) Confirm that the Subscriptions tab reads the correct number of subscriptions attached to the record Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|oleonard@myacpl.org |aleishaamohia@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 59288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59288 Bug 17946: Show number of subscriptions on tab in OPAC record details Review of attachment 59288: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17946&attachment=59288) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ +576,4 @@
[% IF ( subscriptionsnumber ) %] [% IF ( defaulttab == 'subscriptions' ) %]<li id="tab_subscriptions" class="ui-tabs-active">[% ELSE %]<li id="tab_subscriptions">[% END %] + <a href="#subscriptions">Subscriptions ( [% subscriptions.size || 0 %] )</a>
Why not just subscriptionsnumber? See line 796ish where it puts it in the sentence. There is no need for || 0, because subscriptions.size should be equal to subscriptionsnumber. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to M. Tompsett from comment #2)
Why not just subscriptionsnumber? See line 796ish where it puts it in the sentence. There is no need for || 0, because subscriptions.size should be equal to subscriptionsnumber.
I think maybe the code that creates subscriptionsnumber is unnecessary since template toolkit provides the .size method. I will attach a patch that removes this -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Aleisha Amohia from comment #3)
I think maybe the code that creates subscriptionsnumber is unnecessary since template toolkit provides the .size method. I will attach a patch that removes this
Classic case of "should've looked at the code before making a comment"... subscriptions number is actually used for a few things in the code so I will change my patch to use it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59288|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 59832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59832&action=edit Bug 17946: Show number of subscriptions on tab in OPAC record details This patch removes some duplicate code. To test: 1) Edit at least one subscription (or add a new one) to have a record 2) Find that record on the OPAC 3) Confirm that the Subscriptions tab reads the correct number of subscriptions attached to the record Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by JMBroust <jean-manuel.broust@univ-lyon2.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59832|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 61326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61326&action=edit Bug 17946: Show number of subscriptions on tab in OPAC record details This patch removes some duplicate code. To test: 1) Edit at least one subscription (or add a new one) to have a record 2) Find that record on the OPAC 3) Confirm that the Subscriptions tab reads the correct number of subscriptions attached to the record Sponsored-by: Catalyst IT Signed-off-by: JMBroust <jean-manuel.broust@univ-lyon2.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust@univ-lyo | |n2.fr --- Comment #8 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- Not introduced by this patch but i noticed that the library is no more displayed in opac subscription tab view. There is "Library :" but the name of the library is missing. Shall I fill a new bug ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61326|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61342&action=edit Bug 17946: Show number of subscriptions on tab in OPAC record details This patch removes some duplicate code. To test: 1) Edit at least one subscription (or add a new one) to have a record 2) Find that record on the OPAC 3) Confirm that the Subscriptions tab reads the correct number of subscriptions attached to the record Sponsored-by: Catalyst IT Signed-off-by: JMBroust <jean-manuel.broust@univ-lyon2.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to jmbroust from comment #8)
Not introduced by this patch but i noticed that the library is no more displayed in opac subscription tab view. There is "Library :" but the name of the library is missing. Shall I fill a new bug ?
Yes please. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18307 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18307 [Bug 18307] Branchname is no more displayed in subscription tab wiew -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17946 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Nice! This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org