[Bug 29606] New: Include items from host record in XML for XSLT processing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606 Bug ID: 29606 Summary: Include items from host record in XML for XSLT processing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Searching Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org If EasyAnalyticalRecords is enabled, items from host records should be included in the XML. Otherwise, OPAC search results show no items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 128118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128118&action=edit Bug 29606: Include items from host record in XML for XSLT processing If EasyAnalyticalRecords is enabled, items from host records should be included in the XML. Otherwise, OPAC search results show no items. Test plan: 0. Do not apply the patch yet 1. Enable syspref EasyAnalyticalRecords and set OPACXSLTResultsDisplay to 'default' 2. Create a biblio record with title "parent" and create an item with a barcode for this biblio 3. Create a biblio record with title "child" with no items. On the biblio detail page, in the toolbar, click "Edit -> Link to host record" and enter the barcode for the item you created at step 2 4. Duplicate this biblio record, to be sure you will have at least two results with the search "child" (and not be redirected to the detail page) 5. Make sure your search index (zebra or elasticsearch) is up to date 6. Go to OPAC and search "child". You should see two results, no items. Click on one of them. On the detail page you should see one item (the one from the host record) 7. Apply the patch 8. Go to OPAC and search "child". You should now see one item (the same item) for each result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128118|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 137450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137450&action=edit Bug 29606: Include items from host record in XML for XSLT processing If EasyAnalyticalRecords is enabled, items from host records should be included in the XML. Otherwise, OPAC search results show no items. Test plan: 0. Do not apply the patch yet 1. Enable syspref EasyAnalyticalRecords and set OPACXSLTResultsDisplay to 'default' 2. Create a biblio record with title "parent" and create an item with a barcode for this biblio 3. Create a biblio record with title "child" with no items. On the biblio detail page, in the toolbar, click "Edit -> Link to host record" and enter the barcode for the item you created at step 2 4. Duplicate this biblio record, to be sure you will have at least two results with the search "child" (and not be redirected to the detail page) 5. Make sure your search index (zebra or elasticsearch) is up to date 6. Go to OPAC and search "child". You should see two results, no items. Click on one of them. On the detail page you should see one item (the one from the host record) 7. Apply the patch 8. Go to OPAC and search "child". You should now see one item (the same item) for each result. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28702 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Can you add a unit test for the change to buildKohaItemsNamespace? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- This could slow down the (already slow) search results a lot... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- At a minimum, I'd say this should be wrapped in a system preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32463 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Maybe use Koha::Biblio->host_items() -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- This still needs a system preference defaulting to "off"... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29606 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to David Cook from comment #7)
This still needs a system preference defaulting to "off"...
+1 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org